linux-gpio.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Paul Gortmaker <paul.gortmaker@windriver.com>
To: linux-kernel@vger.kernel.org
Cc: Paul Gortmaker <paul.gortmaker@windriver.com>,
	Linus Walleij <linus.walleij@linaro.org>,
	Alexander Shiyan <shc_work@mail.ru>,
	linux-gpio@vger.kernel.org
Subject: [PATCH 02/19] pinctrl: imx1: make it explicitly non-modular
Date: Sat, 25 Jun 2016 22:46:35 -0400	[thread overview]
Message-ID: <20160626024652.5081-3-paul.gortmaker@windriver.com> (raw)
In-Reply-To: <20160626024652.5081-1-paul.gortmaker@windriver.com>

The Kconfig currently controlling compilation of this code is:

drivers/pinctrl/freescale/Kconfig:config PINCTRL_IMX1
drivers/pinctrl/freescale/Kconfig:	bool "IMX1 pinctrl driver"

...meaning that it currently is not being built as a module by anyone.

Lets remove the modular code that is essentially orphaned, so that
when reading the driver there is no doubt it is builtin-only.

Since module_platform_driver() uses the same init level priority as
builtin_platform_driver() the init ordering remains unchanged with
this commit.

Also note that MODULE_DEVICE_TABLE is a no-op for non-modular code.

We also delete the MODULE_LICENSE tag etc. since all that information
is already contained at the top of the file in the comments.

Cc: Linus Walleij <linus.walleij@linaro.org>
Cc: Alexander Shiyan <shc_work@mail.ru>
Cc: linux-gpio@vger.kernel.org
Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com>
---
 drivers/pinctrl/freescale/pinctrl-imx1.c | 9 ++-------
 1 file changed, 2 insertions(+), 7 deletions(-)

diff --git a/drivers/pinctrl/freescale/pinctrl-imx1.c b/drivers/pinctrl/freescale/pinctrl-imx1.c
index 04723455db58..fc8efc748734 100644
--- a/drivers/pinctrl/freescale/pinctrl-imx1.c
+++ b/drivers/pinctrl/freescale/pinctrl-imx1.c
@@ -9,7 +9,7 @@
  * (at your option) any later version.
  */
 
-#include <linux/module.h>
+#include <linux/init.h>
 #include <linux/of.h>
 #include <linux/platform_device.h>
 #include <linux/pinctrl/pinctrl.h>
@@ -262,7 +262,6 @@ static const struct of_device_id imx1_pinctrl_of_match[] = {
 	{ .compatible = "fsl,imx1-iomuxc", },
 	{ }
 };
-MODULE_DEVICE_TABLE(of, imx1_pinctrl_of_match);
 
 static struct platform_driver imx1_pinctrl_driver = {
 	.driver	= {
@@ -270,8 +269,4 @@ static struct platform_driver imx1_pinctrl_driver = {
 		.of_match_table	= imx1_pinctrl_of_match,
 	},
 };
-module_platform_driver_probe(imx1_pinctrl_driver, imx1_pinctrl_probe);
-
-MODULE_AUTHOR("Alexander Shiyan <shc_work@mail.ru>");
-MODULE_DESCRIPTION("Freescale i.MX1 pinctrl driver");
-MODULE_LICENSE("GPL");
+builtin_platform_driver_probe(imx1_pinctrl_driver, imx1_pinctrl_probe);
-- 
2.8.4


  parent reply	other threads:[~2016-06-26  2:47 UTC|newest]

Thread overview: 39+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-06-26  2:46 [PATCH 00/19] pinctrl/freescale: fix module usage in non-modular code Paul Gortmaker
2016-06-26  2:46 ` [PATCH 01/19] pinctrl: freescale: remove needless module.h include Paul Gortmaker
2016-06-29  7:30   ` Linus Walleij
2016-06-26  2:46 ` Paul Gortmaker [this message]
2016-06-29  7:31   ` [PATCH 02/19] pinctrl: imx1: make it explicitly non-modular Linus Walleij
2016-06-26  2:46 ` [PATCH 03/19] pinctrl: imx21: " Paul Gortmaker
2016-06-29  7:32   ` Linus Walleij
2016-06-26  2:46 ` [PATCH 04/19] pinctrl: imx25: " Paul Gortmaker
2016-06-29  7:33   ` Linus Walleij
2016-06-26  2:46 ` [PATCH 05/19] pinctrl: imx27: " Paul Gortmaker
2016-06-29  7:34   ` Linus Walleij
2016-06-26  2:46 ` [PATCH 06/19] pinctrl: imx35: " Paul Gortmaker
2016-06-29  7:35   ` Linus Walleij
2016-06-26  2:46 ` [PATCH 07/19] pinctrl: imx50: " Paul Gortmaker
2016-06-29  7:36   ` Linus Walleij
2016-06-26  2:46 ` [PATCH 08/19] pinctrl: imx51: " Paul Gortmaker
2016-06-29  7:37   ` Linus Walleij
2016-06-26  2:46 ` [PATCH 09/19] pinctrl: imx53: " Paul Gortmaker
2016-06-29  7:38   ` Linus Walleij
2016-06-26  2:46 ` [PATCH 10/19] pinctrl: imx6dl: " Paul Gortmaker
2016-06-29  7:39   ` Linus Walleij
2016-06-26  2:46 ` [PATCH 11/19] pinctrl: imx6q: " Paul Gortmaker
2016-06-29  7:49   ` Linus Walleij
2016-06-26  2:46 ` [PATCH 12/19] pinctrl: imx6sl: " Paul Gortmaker
2016-06-29  7:50   ` Linus Walleij
2016-06-26  2:46 ` [PATCH 13/19] pinctrl: imx6sx: " Paul Gortmaker
2016-06-29  7:51   ` Linus Walleij
2016-06-26  2:46 ` [PATCH 14/19] pinctrl: imx6ul: " Paul Gortmaker
2016-06-29  7:52   ` Linus Walleij
2016-06-26  2:46 ` [PATCH 15/19] pinctrl: imx7d: " Paul Gortmaker
2016-06-29  7:53   ` Linus Walleij
2016-06-26  2:46 ` [PATCH 16/19] pinctrl: vf610: " Paul Gortmaker
2016-06-29  7:54   ` Linus Walleij
2016-06-26  2:46 ` [PATCH 17/19] pinctrl: imx23: " Paul Gortmaker
2016-06-29  7:55   ` Linus Walleij
2016-06-26  2:46 ` [PATCH 18/19] pinctrl: imx28: " Paul Gortmaker
2016-06-29  7:55   ` Linus Walleij
2016-06-26  2:46 ` [PATCH 19/19] pinctrl: remove orphaned exported ".remove" function Paul Gortmaker
2016-06-29  7:56   ` Linus Walleij

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160626024652.5081-3-paul.gortmaker@windriver.com \
    --to=paul.gortmaker@windriver.com \
    --cc=linus.walleij@linaro.org \
    --cc=linux-gpio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=shc_work@mail.ru \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).