From: Mika Westerberg <mika.westerberg@linux.intel.com>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: linux-gpio@vger.kernel.org,
Linus Walleij <linus.walleij@linaro.org>,
David Cohen <david.a.cohen@linux.intel.com>,
"Wood, Brian J" <brian.j.wood@intel.com>
Subject: Re: [PATCH v2 1/1] gpio: merrifield: Introduce GPIO driver to support Merrifield
Date: Mon, 11 Jul 2016 07:55:03 +0300 [thread overview]
Message-ID: <20160711045503.GF14693@lahna.fi.intel.com> (raw)
In-Reply-To: <1467976103-133151-1-git-send-email-andriy.shevchenko@linux.intel.com>
On Fri, Jul 08, 2016 at 02:08:23PM +0300, Andy Shevchenko wrote:
> +static void mrfld_irq_ack(struct irq_data *d)
> +{
> + struct mrfld_gpio *priv = irq_data_get_irq_chip_data(d);
> + u32 gpio = irqd_to_hwirq(d);
> + void __iomem *gisr = gpio_reg(&priv->chip, gpio, GISR);
> +
> + writel(BIT(gpio % 32), gisr);
It just occured me that you actually need to take the lock here. If
another thread is doing series of updates on the same register this
might step over what the other thread is doing.
next prev parent reply other threads:[~2016-07-11 4:55 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-08 11:08 [PATCH v2 1/1] gpio: merrifield: Introduce GPIO driver to support Merrifield Andy Shevchenko
2016-07-08 13:16 ` Mika Westerberg
2016-07-08 16:54 ` Wood, Brian J
2016-07-08 17:05 ` Andy Shevchenko
2016-07-11 9:12 ` Linus Walleij
2016-07-11 4:55 ` Mika Westerberg [this message]
2016-07-11 9:13 ` Linus Walleij
2016-07-11 9:43 ` Andy Shevchenko
2016-07-11 10:08 ` Andy Shevchenko
2016-07-11 9:06 ` Linus Walleij
2016-07-11 9:45 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160711045503.GF14693@lahna.fi.intel.com \
--to=mika.westerberg@linux.intel.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=brian.j.wood@intel.com \
--cc=david.a.cohen@linux.intel.com \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).