[PATCH 0/2] pinctrl: add missing dependencies on CONFIG_OF

[PATCH 0/2] pinctrl: add missing dependencies on CONFIG_OF

[Jérémy Lefaure]

These two patches fix a missing dependency on CONFIG_OF for
PINCTRL_CYGNUS_MUX and PINCTRL_NSP_MUX Kconfig symbols.

Since these two changes concern two different drivers, I split into
two commits:
[PATCH 1/2] pinctrl: cygnus-mux: add missing dependency on CONFIG_OF
[PATCH 2/2] pinctrl: nsp: add missing dependency on CONFIG_OF

Thank you for your time,
Jérémy Lefaure
--
To unsubscribe from this list: send the line "unsubscribe linux-gpio" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[PATCH 1/2] pinctrl: cygnus-mux: add missing dependency on CONFIG_OF

[Jérémy Lefaure]

There is a build error when CONFIG_OF is disabled (tested with
COMPILE_TEST enabled):

drivers/pinctrl/bcm/pinctrl-cygnus-mux.c:739:20: error:
‘pinconf_generic_dt_node_to_map_group’ undeclared here (not in a
function)
  .dt_node_to_map = pinconf_generic_dt_node_to_map_group,

This commit adds a dependency on CONFIG_OF for PINCTRL_CYGNUS_MUX
Kconfig symbol to fix this problem.

Signed-off-by: Jérémy Lefaure <jeremy.lefaure@lse.epita.fr>
---
 drivers/pinctrl/bcm/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/pinctrl/bcm/Kconfig b/drivers/pinctrl/bcm/Kconfig
index 7967c67..6351028 100644
--- a/drivers/pinctrl/bcm/Kconfig
+++ b/drivers/pinctrl/bcm/Kconfig
@@ -59,7 +59,7 @@ config PINCTRL_IPROC_GPIO
 
 config PINCTRL_CYGNUS_MUX
 	bool "Broadcom Cygnus IOMUX driver"
-	depends on (ARCH_BCM_CYGNUS || COMPILE_TEST)
+	depends on OF && (ARCH_BCM_CYGNUS || COMPILE_TEST)
 	select PINMUX
 	select GENERIC_PINCONF
 	default ARCH_BCM_CYGNUS
-- 
2.9.0

--
To unsubscribe from this list: send the line "unsubscribe linux-gpio" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[PATCH 2/2] pinctrl: nsp: add missing dependency on CONFIG_OF

[Jérémy Lefaure]

There is a build error when CONFIG_OF is disabled (tested with
COMPILE_TEST enabled):

drivers/pinctrl/bcm/pinctrl-nsp-mux.c:356:20: error:
‘pinconf_generic_dt_node_to_map_group’ undeclared here (not in a
function)
  .dt_node_to_map = pinconf_generic_dt_node_to_map_group,

This commit adds a dependency on CONFIG_OF for PINCTRL_NSP_MUX
Kconfig symbol to fix this problem.

Signed-off-by: Jérémy Lefaure <jeremy.lefaure@lse.epita.fr>
---
 drivers/pinctrl/bcm/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/pinctrl/bcm/Kconfig b/drivers/pinctrl/bcm/Kconfig
index 6351028..2a2df55 100644
--- a/drivers/pinctrl/bcm/Kconfig
+++ b/drivers/pinctrl/bcm/Kconfig
@@ -102,7 +102,7 @@ config PINCTRL_NS2_MUX
 
 config PINCTRL_NSP_MUX
 	bool "Broadcom NSP IOMUX driver"
-	depends on (ARCH_BCM_NSP || COMPILE_TEST)
+	depends on OF && (ARCH_BCM_NSP || COMPILE_TEST)
 	select PINMUX
 	select GENERIC_PINCONF
 	default ARCH_BCM_NSP
-- 
2.9.0

--
To unsubscribe from this list: send the line "unsubscribe linux-gpio" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH 0/2] pinctrl: add missing dependencies on CONFIG_OF

[Linus Walleij]

On Sat, Jul 16, 2016 at 7:16 PM, Jérémy Lefaure
<jeremy.lefaure@lse.epita.fr> wrote:

> These two patches fix a missing dependency on CONFIG_OF for
> PINCTRL_CYGNUS_MUX and PINCTRL_NSP_MUX Kconfig symbols.
>
> Since these two changes concern two different drivers, I split into
> two commits:
> [PATCH 1/2] pinctrl: cygnus-mux: add missing dependency on CONFIG_OF
> [PATCH 2/2] pinctrl: nsp: add missing dependency on CONFIG_OF

I got a similar patch from Arnd Bergmann which is already merged.

Yours,
Linus Walleij
--
To unsubscribe from this list: send the line "unsubscribe linux-gpio" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html