From: Krzysztof Kozlowski <k.kozlowski@samsung.com>
To: perr <strongbox8@zoho.com>
Cc: tomasz.figa@gmail.com, k.kozlowski@samsung.com,
s.nawrocki@samsung.com, linus.walleij@linaro.org,
kgene@kernel.org, linux-arm-kernel@lists.infradead.org,
linux-samsung-soc@vger.kernel.org, linux-gpio@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] pinctrl: exynos: remove duplicate calls in irq handler
Date: Mon, 15 Aug 2016 18:59:41 +0200 [thread overview]
Message-ID: <20160815165941.GA3769@kozik-lap> (raw)
In-Reply-To: <1471256227-6282-1-git-send-email-strongbox8@zoho.com>
On Mon, Aug 15, 2016 at 06:17:07PM +0800, perr wrote:
> Because chained_irq_enter() has already called chip->irq_mask() and
> chip->irq_ack(), also chained_irq_exit() will call chip->irq_unmask(),
> so it's not necessary to call chip->irq_*() here.
>
> Signed-off-by: perr <strongbox8@zoho.com>
>
> ---
> drivers/pinctrl/samsung/pinctrl-exynos.c | 6 +-----
> 1 file changed, 1 insertion(+), 5 deletions(-)
>
Looks correct so for the patch itself:
Reviewed-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
However, your name "Perr" confuses me a little bit. For the
Signed-off-by statement, as mentioned in
Documentation/SubmittingPatches, a real name is required. The name
should match the author.
Would you be so kind as to use a full, real name? Unless Perr is your
full, real name... then sorry for the trouble.
Best regards,
Krzysztof
next prev parent reply other threads:[~2016-08-15 16:59 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-15 10:17 [PATCH] pinctrl: exynos: remove duplicate calls in irq handler perr
2016-08-15 11:34 ` Tomasz Figa
2016-08-15 16:59 ` Krzysztof Kozlowski [this message]
2016-08-15 23:58 ` perr perr
2016-08-16 6:04 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160815165941.GA3769@kozik-lap \
--to=k.kozlowski@samsung.com \
--cc=kgene@kernel.org \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=s.nawrocki@samsung.com \
--cc=strongbox8@zoho.com \
--cc=tomasz.figa@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).