From: Shawn Guo <shawnguo@kernel.org>
To: Vladimir Zapolskiy <vladimir_zapolskiy@mentor.com>
Cc: Linus Walleij <linus.walleij@linaro.org>,
Sascha Hauer <kernel@pengutronix.de>,
Fabio Estevam <fabio.estevam@nxp.com>,
linux-gpio@vger.kernel.org, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] pinctrl: imx: output one pin/config pair per line in pinconf-groups
Date: Mon, 29 Aug 2016 11:29:04 +0800 [thread overview]
Message-ID: <20160829032904.GA31367@tiger> (raw)
In-Reply-To: <1471644337-10162-1-git-send-email-vladimir_zapolskiy@mentor.com>
On Sat, Aug 20, 2016 at 01:05:37AM +0300, Vladimir Zapolskiy wrote:
> cat /sys/kernel/debug/pinctrl/${pinctrl}/pinconf-groups output is
> hardly readable, if a pin group contains more than one pin the output
> is glued and looks like this:
>
> MX6Q_PAD_SD1_DAT0: 0x17071MX6Q_PAD_SD1_CMD: 0x17071MX6Q_PAD_SD1_CLK: 0x17071
>
> Add two space indentation and a new line separator to improve
> readability of the output.
>
> Signed-off-by: Vladimir Zapolskiy <vladimir_zapolskiy@mentor.com>
Acked-by: Shawn Guo <shawnguo@kernel.org>
> ---
> drivers/pinctrl/freescale/pinctrl-imx.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/pinctrl/freescale/pinctrl-imx.c b/drivers/pinctrl/freescale/pinctrl-imx.c
> index 71391757938b..56fd88013850 100644
> --- a/drivers/pinctrl/freescale/pinctrl-imx.c
> +++ b/drivers/pinctrl/freescale/pinctrl-imx.c
> @@ -501,7 +501,7 @@ static void imx_pinconf_group_dbg_show(struct pinctrl_dev *pctldev,
> ret = imx_pinconf_get(pctldev, pin->pin, &config);
> if (ret)
> return;
> - seq_printf(s, "%s: 0x%lx", name, config);
> + seq_printf(s, " %s: 0x%lx\n", name, config);
> }
> }
>
> --
> 2.8.1
>
>
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2016-08-29 3:29 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-19 22:05 [PATCH] pinctrl: imx: output one pin/config pair per line in pinconf-groups Vladimir Zapolskiy
2016-08-29 3:29 ` Shawn Guo [this message]
2016-09-05 22:19 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160829032904.GA31367@tiger \
--to=shawnguo@kernel.org \
--cc=fabio.estevam@nxp.com \
--cc=kernel@pengutronix.de \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-gpio@vger.kernel.org \
--cc=vladimir_zapolskiy@mentor.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).