From: Lee Jones <lee.jones@linaro.org>
To: Keerthy <a0393675@ti.com>
Cc: Keerthy <j-keerthy@ti.com>,
broonie@kernel.org, linus.walleij@linaro.org,
linux-omap@vger.kernel.org, robh+dt@kernel.org,
linux-gpio@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v8 1/3] mfd: lp873x: Add lp873x PMIC support
Date: Wed, 31 Aug 2016 12:16:04 +0100 [thread overview]
Message-ID: <20160831111604.GG27357@dell> (raw)
In-Reply-To: <c54c042b-1661-07a4-53f9-c67550a41e68@ti.com>
On Wed, 31 Aug 2016, Keerthy wrote:
> On Wednesday 31 August 2016 01:26 PM, Lee Jones wrote:
> > On Fri, 12 Aug 2016, Keerthy wrote:
> >
> > > The LP873X chip is a power management IC for Portable Navigation Systems
> > > and Tablet Computing devices. It contains the following components:
> > >
> > > - Regulators.
> > > - Configurable General Purpose Output Signals(GPO).
[...]
> > > +static const struct i2c_device_id lp873x_id_table[] = {
> > > + { "lp873x", LP873X },
> > > + { },
> > > +};
> > > +MODULE_DEVICE_TABLE(i2c, lp873x_id_table);
> >
> > Don't set the ID in this table.
>
> I did not understand this. Could you please elaborate?
> You mean no need of LP873X can just be a '0' as i am seeing in other mfd
> drivers?
Just leave it blank. No need for the second attribute.
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
next prev parent reply other threads:[~2016-08-31 11:16 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-12 4:58 [PATCH v8 0/3] mfd: lp873x: Add lp873x PMIC support Keerthy
2016-08-12 4:58 ` [PATCH v8 1/3] " Keerthy
2016-08-31 7:56 ` Lee Jones
2016-08-31 8:13 ` Keerthy
2016-08-31 11:16 ` Lee Jones [this message]
[not found] ` <1470977889-27991-1-git-send-email-j-keerthy-l0cyMroinI0@public.gmane.org>
2016-08-12 4:58 ` [PATCH v8 2/3] gpio: lp873x: Add support for General Purpose Outputs Keerthy
2016-08-12 4:58 ` [PATCH v8 3/3] regulator: lp873x: Change the MFD config option as per latest naming Keerthy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160831111604.GG27357@dell \
--to=lee.jones@linaro.org \
--cc=a0393675@ti.com \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=j-keerthy@ti.com \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).