* [PATCH] gpio: pca953x: initialize ret to zero to avoid returning garbage
@ 2016-09-09 8:31 Colin King
2016-09-12 13:40 ` Linus Walleij
0 siblings, 1 reply; 7+ messages in thread
From: Colin King @ 2016-09-09 8:31 UTC (permalink / raw)
To: Linus Walleij, Alexandre Courbot, linux-gpio; +Cc: linux-kernel
From: Colin Ian King <colin.king@canonical.com>
ret is not initialized so it contains garbage. Ensure garbage
is not returned in the case that pdata && pdata->teardown is false
by initializing ret to 0.
Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
drivers/gpio/gpio-pca953x.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpio/gpio-pca953x.c b/drivers/gpio/gpio-pca953x.c
index cbe2824..52f3d5c 100644
--- a/drivers/gpio/gpio-pca953x.c
+++ b/drivers/gpio/gpio-pca953x.c
@@ -845,7 +845,7 @@ static int pca953x_remove(struct i2c_client *client)
{
struct pca953x_platform_data *pdata = dev_get_platdata(&client->dev);
struct pca953x_chip *chip = i2c_get_clientdata(client);
- int ret;
+ int ret = 0;
if (pdata && pdata->teardown) {
ret = pdata->teardown(client, chip->gpio_chip.base,
--
2.9.3
^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [PATCH] gpio: pca953x: initialize ret to zero to avoid returning garbage
2016-09-09 8:31 [PATCH] gpio: pca953x: initialize ret to zero to avoid returning garbage Colin King
@ 2016-09-12 13:40 ` Linus Walleij
2016-09-13 4:04 ` Phil Reid
0 siblings, 1 reply; 7+ messages in thread
From: Linus Walleij @ 2016-09-12 13:40 UTC (permalink / raw)
To: Colin King
Cc: Alexandre Courbot, linux-gpio@vger.kernel.org,
linux-kernel@vger.kernel.org
On Fri, Sep 9, 2016 at 10:31 AM, Colin King <colin.king@canonical.com> wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> ret is not initialized so it contains garbage. Ensure garbage
> is not returned in the case that pdata && pdata->teardown is false
> by initializing ret to 0.
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
Patch applied.
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] gpio: pca953x: initialize ret to zero to avoid returning garbage
2016-09-12 13:40 ` Linus Walleij
@ 2016-09-13 4:04 ` Phil Reid
2016-09-13 11:49 ` Linus Walleij
2016-09-13 12:31 ` Arnd Bergmann
0 siblings, 2 replies; 7+ messages in thread
From: Phil Reid @ 2016-09-13 4:04 UTC (permalink / raw)
To: Linus Walleij, Colin King
Cc: Alexandre Courbot, linux-gpio@vger.kernel.org,
linux-kernel@vger.kernel.org, Arnd Bergmann
On 12/09/2016 21:40, Linus Walleij wrote:
> On Fri, Sep 9, 2016 at 10:31 AM, Colin King <colin.king@canonical.com> wrote:
>
>> From: Colin Ian King <colin.king@canonical.com>
>>
>> ret is not initialized so it contains garbage. Ensure garbage
>> is not returned in the case that pdata && pdata->teardown is false
>> by initializing ret to 0.
>>
>> Signed-off-by: Colin Ian King <colin.king@canonical.com>
>
> Patch applied.
G'day Linus,
I believe this does the same as Arnd Bergmanns patch from 26 Aug.
[PATCH 1/5] gpio: pca954x: fix undefined error code from remove
IMO Colin's is the cleaner solution.
Arnd's could be removed.
--
Regards
Phil Reid
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] gpio: pca953x: initialize ret to zero to avoid returning garbage
2016-09-13 4:04 ` Phil Reid
@ 2016-09-13 11:49 ` Linus Walleij
2016-09-13 12:31 ` Arnd Bergmann
1 sibling, 0 replies; 7+ messages in thread
From: Linus Walleij @ 2016-09-13 11:49 UTC (permalink / raw)
To: Phil Reid
Cc: Colin King, Alexandre Courbot, linux-gpio@vger.kernel.org,
linux-kernel@vger.kernel.org, Arnd Bergmann
On Tue, Sep 13, 2016 at 6:04 AM, Phil Reid <preid@electromag.com.au> wrote:
> On 12/09/2016 21:40, Linus Walleij wrote:
>>
>> On Fri, Sep 9, 2016 at 10:31 AM, Colin King <colin.king@canonical.com>
>> wrote:
>>
>>> From: Colin Ian King <colin.king@canonical.com>
>>>
>>> ret is not initialized so it contains garbage. Ensure garbage
>>> is not returned in the case that pdata && pdata->teardown is false
>>> by initializing ret to 0.
>>>
>>> Signed-off-by: Colin Ian King <colin.king@canonical.com>
>>
>>
>> Patch applied.
>
> G'day Linus,
>
>
> I believe this does the same as Arnd Bergmanns patch from 26 Aug.
> [PATCH 1/5] gpio: pca954x: fix undefined error code from remove
>
> IMO Colin's is the cleaner solution.
> Arnd's could be removed.
OK you're right. I reverted Arnd's patch.
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] gpio: pca953x: initialize ret to zero to avoid returning garbage
2016-09-13 4:04 ` Phil Reid
2016-09-13 11:49 ` Linus Walleij
@ 2016-09-13 12:31 ` Arnd Bergmann
2016-09-13 12:46 ` Linus Walleij
1 sibling, 1 reply; 7+ messages in thread
From: Arnd Bergmann @ 2016-09-13 12:31 UTC (permalink / raw)
To: Phil Reid
Cc: Linus Walleij, Colin King, Alexandre Courbot,
linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org
On Tuesday, September 13, 2016 12:04:00 PM CEST Phil Reid wrote:
> On 12/09/2016 21:40, Linus Walleij wrote:
> > On Fri, Sep 9, 2016 at 10:31 AM, Colin King <colin.king@canonical.com> wrote:
> >
> >> From: Colin Ian King <colin.king@canonical.com>
> >>
> >> ret is not initialized so it contains garbage. Ensure garbage
> >> is not returned in the case that pdata && pdata->teardown is false
> >> by initializing ret to 0.
> >>
> >> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> >
> > Patch applied.
> G'day Linus,
>
>
> I believe this does the same as Arnd Bergmanns patch from 26 Aug.
> [PATCH 1/5] gpio: pca954x: fix undefined error code from remove
>
> IMO Colin's is the cleaner solution.
> Arnd's could be removed.
>
Please try to avoid adding initializations in the local variable
declaration, they just hide otherwise useful warnings when
you get a function that actually does something incorrect
in some code paths.
See also https://rusty.ozlabs.org/?p=232
Arnd
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] gpio: pca953x: initialize ret to zero to avoid returning garbage
2016-09-13 12:46 ` Linus Walleij
@ 2016-09-13 12:45 ` Colin Ian King
0 siblings, 0 replies; 7+ messages in thread
From: Colin Ian King @ 2016-09-13 12:45 UTC (permalink / raw)
To: Linus Walleij, Arnd Bergmann
Cc: Phil Reid, Alexandre Courbot, linux-gpio@vger.kernel.org,
linux-kernel@vger.kernel.org
On 13/09/16 13:46, Linus Walleij wrote:
> On Tue, Sep 13, 2016 at 2:31 PM, Arnd Bergmann <arnd@arndb.de> wrote:
>
>> Please try to avoid adding initializations in the local variable
>> declaration, they just hide otherwise useful warnings when
>> you get a function that actually does something incorrect
>> in some code paths.
>
> Agreed, sorry for my ignorance :(
>
> I duly corrected the git and reverted the other patch instead of yours.
>
> Yours,
> Linus Walleij
>
Makes sense. Thanks Linus
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] gpio: pca953x: initialize ret to zero to avoid returning garbage
2016-09-13 12:31 ` Arnd Bergmann
@ 2016-09-13 12:46 ` Linus Walleij
2016-09-13 12:45 ` Colin Ian King
0 siblings, 1 reply; 7+ messages in thread
From: Linus Walleij @ 2016-09-13 12:46 UTC (permalink / raw)
To: Arnd Bergmann
Cc: Phil Reid, Colin King, Alexandre Courbot,
linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org
On Tue, Sep 13, 2016 at 2:31 PM, Arnd Bergmann <arnd@arndb.de> wrote:
> Please try to avoid adding initializations in the local variable
> declaration, they just hide otherwise useful warnings when
> you get a function that actually does something incorrect
> in some code paths.
Agreed, sorry for my ignorance :(
I duly corrected the git and reverted the other patch instead of yours.
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2016-09-13 12:46 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-09-09 8:31 [PATCH] gpio: pca953x: initialize ret to zero to avoid returning garbage Colin King
2016-09-12 13:40 ` Linus Walleij
2016-09-13 4:04 ` Phil Reid
2016-09-13 11:49 ` Linus Walleij
2016-09-13 12:31 ` Arnd Bergmann
2016-09-13 12:46 ` Linus Walleij
2016-09-13 12:45 ` Colin Ian King
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).