* [PATCH] pinctrl: qcom: fix masking of pinmux functions
@ 2016-09-12 9:36 John Crispin
2016-09-26 6:36 ` Stephen Boyd
0 siblings, 1 reply; 7+ messages in thread
From: John Crispin @ 2016-09-12 9:36 UTC (permalink / raw)
To: Linus Walleij, Stephen Boyd
Cc: Bjorn Andersson, linux-gpio, linux-kernel, John Crispin
The following commit introduced a regression by not properly masking the
calculated value.
commit 47a01ee9a6c39fe1 ("pinctrl: qcom: Clear all function selection bits")
Signed-off-by: John Crispin <john@phrozen.org>
---
drivers/pinctrl/qcom/pinctrl-msm.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/pinctrl/qcom/pinctrl-msm.c b/drivers/pinctrl/qcom/pinctrl-msm.c
index 51c42d7..775c883 100644
--- a/drivers/pinctrl/qcom/pinctrl-msm.c
+++ b/drivers/pinctrl/qcom/pinctrl-msm.c
@@ -156,7 +156,7 @@ static int msm_pinmux_set_mux(struct pinctrl_dev *pctldev,
spin_lock_irqsave(&pctrl->lock, flags);
val = readl(pctrl->regs + g->ctl_reg);
- val &= mask;
+ val &= ~mask;
val |= i << g->mux_bit;
writel(val, pctrl->regs + g->ctl_reg);
--
1.7.10.4
^ permalink raw reply related [flat|nested] 7+ messages in thread* Re: [PATCH] pinctrl: qcom: fix masking of pinmux functions
2016-09-12 9:36 [PATCH] pinctrl: qcom: fix masking of pinmux functions John Crispin
@ 2016-09-26 6:36 ` Stephen Boyd
2016-09-26 15:52 ` Bjorn Andersson
0 siblings, 1 reply; 7+ messages in thread
From: Stephen Boyd @ 2016-09-26 6:36 UTC (permalink / raw)
To: John Crispin
Cc: Linus Walleij, Bjorn Andersson, linux-gpio,
Linux Kernel Mailing List
On Mon, Sep 12, 2016 at 2:36 AM, John Crispin <john@phrozen.org> wrote:
> The following commit introduced a regression by not properly masking the
> calculated value.
>
> commit 47a01ee9a6c39fe1 ("pinctrl: qcom: Clear all function selection bits")
>
> Signed-off-by: John Crispin <john@phrozen.org>
Now I'm confused how it ever worked.... but agreed, the code looks wrong.
Reviewed-by: Stephen Boyd <stephen.boyd@linaro.org>
> ---
> drivers/pinctrl/qcom/pinctrl-msm.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/pinctrl/qcom/pinctrl-msm.c b/drivers/pinctrl/qcom/pinctrl-msm.c
> index 51c42d7..775c883 100644
> --- a/drivers/pinctrl/qcom/pinctrl-msm.c
> +++ b/drivers/pinctrl/qcom/pinctrl-msm.c
> @@ -156,7 +156,7 @@ static int msm_pinmux_set_mux(struct pinctrl_dev *pctldev,
> spin_lock_irqsave(&pctrl->lock, flags);
>
> val = readl(pctrl->regs + g->ctl_reg);
> - val &= mask;
> + val &= ~mask;
> val |= i << g->mux_bit;
> writel(val, pctrl->regs + g->ctl_reg);
>
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [PATCH] pinctrl: qcom: fix masking of pinmux functions
2016-09-26 6:36 ` Stephen Boyd
@ 2016-09-26 15:52 ` Bjorn Andersson
2016-10-03 13:31 ` Linus Walleij
0 siblings, 1 reply; 7+ messages in thread
From: Bjorn Andersson @ 2016-09-26 15:52 UTC (permalink / raw)
To: Stephen Boyd, Linus Walleij
Cc: John Crispin, linux-gpio, Linux Kernel Mailing List
On Sun 25 Sep 23:36 PDT 2016, Stephen Boyd wrote:
> On Mon, Sep 12, 2016 at 2:36 AM, John Crispin <john@phrozen.org> wrote:
> > The following commit introduced a regression by not properly masking the
> > calculated value.
> >
> > commit 47a01ee9a6c39fe1 ("pinctrl: qcom: Clear all function selection bits")
Please use the format: Fixes: %h (\"%s\")
> >
> > Signed-off-by: John Crispin <john@phrozen.org>
>
> Now I'm confused how it ever worked.... but agreed, the code looks wrong.
I agree, we should have seen some issues based on this, I presume we
where "lucky".
>
> Reviewed-by: Stephen Boyd <stephen.boyd@linaro.org>
>
Reviewed-by: Bjorn Andersson <bjorn.andersson@linaro.org>
@Linus, the corrected patch appeared in v4.8-rc1, would you mind
including this in a pull for v4.8?
Regards,
Bjorn
> > ---
> > drivers/pinctrl/qcom/pinctrl-msm.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/pinctrl/qcom/pinctrl-msm.c b/drivers/pinctrl/qcom/pinctrl-msm.c
> > index 51c42d7..775c883 100644
> > --- a/drivers/pinctrl/qcom/pinctrl-msm.c
> > +++ b/drivers/pinctrl/qcom/pinctrl-msm.c
> > @@ -156,7 +156,7 @@ static int msm_pinmux_set_mux(struct pinctrl_dev *pctldev,
> > spin_lock_irqsave(&pctrl->lock, flags);
> >
> > val = readl(pctrl->regs + g->ctl_reg);
> > - val &= mask;
> > + val &= ~mask;
> > val |= i << g->mux_bit;
> > writel(val, pctrl->regs + g->ctl_reg);
> >
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [PATCH] pinctrl: qcom: fix masking of pinmux functions
2016-09-26 15:52 ` Bjorn Andersson
@ 2016-10-03 13:31 ` Linus Walleij
2016-10-03 14:24 ` John Crispin
2016-10-03 20:53 ` Stephen Boyd
0 siblings, 2 replies; 7+ messages in thread
From: Linus Walleij @ 2016-10-03 13:31 UTC (permalink / raw)
To: Bjorn Andersson
Cc: Stephen Boyd, John Crispin, linux-gpio@vger.kernel.org,
Linux Kernel Mailing List
On Mon, Sep 26, 2016 at 5:52 PM, Bjorn Andersson
<bjorn.andersson@linaro.org> wrote:
> On Sun 25 Sep 23:36 PDT 2016, Stephen Boyd wrote:
>
>> On Mon, Sep 12, 2016 at 2:36 AM, John Crispin <john@phrozen.org> wrote:
>> > The following commit introduced a regression by not properly masking the
>> > calculated value.
>> >
>> > commit 47a01ee9a6c39fe1 ("pinctrl: qcom: Clear all function selection bits")
>
> Please use the format: Fixes: %h (\"%s\")
>
>> >
>> > Signed-off-by: John Crispin <john@phrozen.org>
>>
>> Now I'm confused how it ever worked.... but agreed, the code looks wrong.
>
> I agree, we should have seen some issues based on this, I presume we
> where "lucky".
>
>>
>> Reviewed-by: Stephen Boyd <stephen.boyd@linaro.org>
>>
>
> Reviewed-by: Bjorn Andersson <bjorn.andersson@linaro.org>
>
> @Linus, the corrected patch appeared in v4.8-rc1, would you mind
> including this in a pull for v4.8?
I would have, had I been more attentive. And you even told me in person to
look at this :/ sorry.
Now I have the problem that I don't have the original patch in my inbox
at all: it might have been sent to some qcom-specific mailing list?
John: can you include the ACKs and resend with me on the To: line?
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [PATCH] pinctrl: qcom: fix masking of pinmux functions
2016-10-03 13:31 ` Linus Walleij
@ 2016-10-03 14:24 ` John Crispin
2016-10-03 22:38 ` Linus Walleij
2016-10-03 20:53 ` Stephen Boyd
1 sibling, 1 reply; 7+ messages in thread
From: John Crispin @ 2016-10-03 14:24 UTC (permalink / raw)
To: Linus Walleij, Bjorn Andersson
Cc: Stephen Boyd, linux-gpio@vger.kernel.org,
Linux Kernel Mailing List
On 03/10/2016 15:31, Linus Walleij wrote:
> On Mon, Sep 26, 2016 at 5:52 PM, Bjorn Andersson
> <bjorn.andersson@linaro.org> wrote:
>> On Sun 25 Sep 23:36 PDT 2016, Stephen Boyd wrote:
>>
>>> On Mon, Sep 12, 2016 at 2:36 AM, John Crispin <john@phrozen.org> wrote:
>>>> The following commit introduced a regression by not properly masking the
>>>> calculated value.
>>>>
>>>> commit 47a01ee9a6c39fe1 ("pinctrl: qcom: Clear all function selection bits")
>>
>> Please use the format: Fixes: %h (\"%s\")
>>
>>>>
>>>> Signed-off-by: John Crispin <john@phrozen.org>
>>>
>>> Now I'm confused how it ever worked.... but agreed, the code looks wrong.
>>
>> I agree, we should have seen some issues based on this, I presume we
>> where "lucky".
>>
>>>
>>> Reviewed-by: Stephen Boyd <stephen.boyd@linaro.org>
>>>
>>
>> Reviewed-by: Bjorn Andersson <bjorn.andersson@linaro.org>
>>
>> @Linus, the corrected patch appeared in v4.8-rc1, would you mind
>> including this in a pull for v4.8?
>
> I would have, had I been more attentive. And you even told me in person to
> look at this :/ sorry.
>
> Now I have the problem that I don't have the original patch in my inbox
> at all: it might have been sent to some qcom-specific mailing list?
>
> John: can you include the ACKs and resend with me on the To: line?
>
> Yours,
> Linus Walleij
>
Sure, is there a patchwork where i can export it with all the Acks ?
John
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [PATCH] pinctrl: qcom: fix masking of pinmux functions
2016-10-03 14:24 ` John Crispin
@ 2016-10-03 22:38 ` Linus Walleij
0 siblings, 0 replies; 7+ messages in thread
From: Linus Walleij @ 2016-10-03 22:38 UTC (permalink / raw)
To: John Crispin
Cc: Bjorn Andersson, Stephen Boyd, linux-gpio@vger.kernel.org,
Linux Kernel Mailing List
On Mon, Oct 3, 2016 at 4:24 PM, John Crispin <john@phrozen.org> wrote:
> On 03/10/2016 15:31, Linus Walleij wrote:
>> Now I have the problem that I don't have the original patch in my inbox
>> at all: it might have been sent to some qcom-specific mailing list?
>>
>> John: can you include the ACKs and resend with me on the To: line?
>>
>> Yours,
>> Linus Walleij
>>
>
> Sure, is there a patchwork where i can export it with all the Acks ?
Nevermind, I found the patch in my spam folder and applied it!
Thanks!
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] pinctrl: qcom: fix masking of pinmux functions
2016-10-03 13:31 ` Linus Walleij
2016-10-03 14:24 ` John Crispin
@ 2016-10-03 20:53 ` Stephen Boyd
1 sibling, 0 replies; 7+ messages in thread
From: Stephen Boyd @ 2016-10-03 20:53 UTC (permalink / raw)
To: Linus Walleij
Cc: Bjorn Andersson, John Crispin, linux-gpio@vger.kernel.org,
Linux Kernel Mailing List
On Mon, Oct 3, 2016 at 6:31 AM, Linus Walleij <linus.walleij@linaro.org> wrote:
> On Mon, Sep 26, 2016 at 5:52 PM, Bjorn Andersson
> <bjorn.andersson@linaro.org> wrote:
>> On Sun 25 Sep 23:36 PDT 2016, Stephen Boyd wrote:
>>
>>> On Mon, Sep 12, 2016 at 2:36 AM, John Crispin <john@phrozen.org> wrote:
>>> > The following commit introduced a regression by not properly masking the
>>> > calculated value.
>>> >
>>> > commit 47a01ee9a6c39fe1 ("pinctrl: qcom: Clear all function selection bits")
>>
>> Please use the format: Fixes: %h (\"%s\")
>>
>>> >
>>> > Signed-off-by: John Crispin <john@phrozen.org>
>>>
>>> Now I'm confused how it ever worked.... but agreed, the code looks wrong.
>>
>> I agree, we should have seen some issues based on this, I presume we
>> where "lucky".
>>
>>>
>>> Reviewed-by: Stephen Boyd <stephen.boyd@linaro.org>
>>>
>>
>> Reviewed-by: Bjorn Andersson <bjorn.andersson@linaro.org>
>>
>> @Linus, the corrected patch appeared in v4.8-rc1, would you mind
>> including this in a pull for v4.8?
>
> I would have, had I been more attentive. And you even told me in person to
> look at this :/ sorry.
>
> Now I have the problem that I don't have the original patch in my inbox
> at all: it might have been sent to some qcom-specific mailing list?
It hit my (linaro) spam for some reason. Must be a problem between the
sending side and how google mail classifies spam.
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2016-10-03 22:38 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-09-12 9:36 [PATCH] pinctrl: qcom: fix masking of pinmux functions John Crispin
2016-09-26 6:36 ` Stephen Boyd
2016-09-26 15:52 ` Bjorn Andersson
2016-10-03 13:31 ` Linus Walleij
2016-10-03 14:24 ` John Crispin
2016-10-03 22:38 ` Linus Walleij
2016-10-03 20:53 ` Stephen Boyd
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).