From: Viresh Kumar <viresh.kumar@linaro.org>
To: Stefan Agner <stefan@agner.ch>
Cc: Vladimir Zapolskiy <vladimir_zapolskiy@mentor.com>,
linus.walleij@linaro.org, shawnguo@kernel.org,
aalonso@freescale.com, b38343@freescale.com,
ldewangan@nvidia.com, van.freenix@gmail.com,
p.zabel@pengutronix.de, linux-gpio@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] pinctrl: freescale: avoid overwriting pin config when freeing GPIO
Date: Wed, 28 Sep 2016 07:30:52 +0530 [thread overview]
Message-ID: <20160928020052.GB2551@vireshk-i7> (raw)
In-Reply-To: <671a23a9ccdbdd6594ad89bf496c1490@agner.ch>
On 27-09-16, 12:34, Stefan Agner wrote:
> Added Viresh Kumar to the discussion, he implemented the I2C recovery
> functions.
>
> Yes, reordering the pinctrl/gpio_free calls would fix the problem too.
>
> However, I guess there is no explicit rule to that ("request/free GPIOs
> only when they are muxed as GPIO"), so I think of it that the issue is
> actually in the pinctrl driver.
>
> On top of that it is not entirely trivial to reorder the calls the way
> i2c_generic_gpio_recovery and i2c_generic_recovery are set up right now.
AFAICT, these routines don't touch the muxing part at all. Perhaps it is done
internally by the GPIO calls. Can you please elaborate the exact change you are
hinting towards here ?
--
viresh
next prev parent reply other threads:[~2016-09-28 2:00 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-27 0:26 [PATCH] pinctrl: freescale: avoid overwriting pin config when freeing GPIO Stefan Agner
2016-09-27 12:12 ` Vladimir Zapolskiy
2016-09-27 16:37 ` Stefan Agner
2016-09-27 18:17 ` Vladimir Zapolskiy
2016-09-27 19:34 ` Stefan Agner
2016-09-27 20:28 ` Vladimir Zapolskiy
2016-09-28 2:00 ` Viresh Kumar [this message]
2016-09-28 3:38 ` Stefan Agner
2016-09-28 4:14 ` Viresh Kumar
2016-09-29 16:33 ` Stefan Agner
2016-09-30 2:12 ` Viresh Kumar
2016-10-10 8:32 ` Linus Walleij
2016-09-28 12:07 ` Vladimir Zapolskiy
2016-09-29 6:46 ` Viresh Kumar
2016-09-29 12:16 ` Vladimir Zapolskiy
2016-09-30 2:22 ` Viresh Kumar
2016-10-10 8:33 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160928020052.GB2551@vireshk-i7 \
--to=viresh.kumar@linaro.org \
--cc=aalonso@freescale.com \
--cc=b38343@freescale.com \
--cc=ldewangan@nvidia.com \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=p.zabel@pengutronix.de \
--cc=shawnguo@kernel.org \
--cc=stefan@agner.ch \
--cc=van.freenix@gmail.com \
--cc=vladimir_zapolskiy@mentor.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox