* [PATCH 1/2] gpio: ath79: Fix module autoload
@ 2016-10-18 20:44 Javier Martinez Canillas
2016-10-18 20:44 ` [PATCH 2/2] gpio: ts4800: " Javier Martinez Canillas
` (2 more replies)
0 siblings, 3 replies; 6+ messages in thread
From: Javier Martinez Canillas @ 2016-10-18 20:44 UTC (permalink / raw)
To: linux-kernel
Cc: Javier Martinez Canillas, linux-gpio, Alban Bedel, Linus Walleij,
Alexandre Courbot
If the driver is built as a module, autoload won't work because the module
alias information is not filled. So user-space can't match the registered
device with the corresponding module.
Export the module alias information using the MODULE_DEVICE_TABLE() macro.
Before this patch:
$ modinfo drivers/gpio/gpio-ath79.ko | grep alias
$
After this patch:
$ modinfo drivers/gpio/gpio-ath79.ko | grep alias
alias: of:N*T*Cqca,ar9340-gpioC*
alias: of:N*T*Cqca,ar9340-gpio
alias: of:N*T*Cqca,ar7100-gpioC*
alias: of:N*T*Cqca,ar7100-gpio
Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com>
---
drivers/gpio/gpio-ath79.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/gpio/gpio-ath79.c b/drivers/gpio/gpio-ath79.c
index 9457e2022bf6..dc37dbe4b46d 100644
--- a/drivers/gpio/gpio-ath79.c
+++ b/drivers/gpio/gpio-ath79.c
@@ -219,6 +219,7 @@ static const struct of_device_id ath79_gpio_of_match[] = {
{ .compatible = "qca,ar9340-gpio" },
{},
};
+MODULE_DEVICE_TABLE(of, ath79_gpio_of_match);
static int ath79_gpio_probe(struct platform_device *pdev)
{
--
2.7.4
^ permalink raw reply related [flat|nested] 6+ messages in thread* [PATCH 2/2] gpio: ts4800: Fix module autoload
2016-10-18 20:44 [PATCH 1/2] gpio: ath79: Fix module autoload Javier Martinez Canillas
@ 2016-10-18 20:44 ` Javier Martinez Canillas
2016-10-21 12:55 ` Linus Walleij
2016-10-19 17:10 ` [PATCH 1/2] gpio: ath79: " Alban
2016-10-23 22:23 ` Linus Walleij
2 siblings, 1 reply; 6+ messages in thread
From: Javier Martinez Canillas @ 2016-10-18 20:44 UTC (permalink / raw)
To: linux-kernel
Cc: Javier Martinez Canillas, linux-gpio, Linus Walleij,
Alexandre Courbot
If the driver is built as a module, autoload won't work because the module
alias information is not filled. So user-space can't match the registered
device with the corresponding module.
Export the module alias information using the MODULE_DEVICE_TABLE() macro.
Before this patch:
$ modinfo drivers/gpio/gpio-ts4800.ko | grep alias
$
After this patch:
$ modinfo drivers/gpio/gpio-ts4800.ko | grep alias
alias: of:N*T*Ctechnologic,ts4800-gpioC*
alias: of:N*T*Ctechnologic,ts4800-gpio
Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com>
---
drivers/gpio/gpio-ts4800.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/gpio/gpio-ts4800.c b/drivers/gpio/gpio-ts4800.c
index 99256115bea5..c2a80b4cbf32 100644
--- a/drivers/gpio/gpio-ts4800.c
+++ b/drivers/gpio/gpio-ts4800.c
@@ -66,6 +66,7 @@ static const struct of_device_id ts4800_gpio_of_match[] = {
{ .compatible = "technologic,ts4800-gpio", },
{},
};
+MODULE_DEVICE_TABLE(of, ts4800_gpio_of_match);
static struct platform_driver ts4800_gpio_driver = {
.driver = {
--
2.7.4
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH 2/2] gpio: ts4800: Fix module autoload
2016-10-18 20:44 ` [PATCH 2/2] gpio: ts4800: " Javier Martinez Canillas
@ 2016-10-21 12:55 ` Linus Walleij
2016-10-21 13:32 ` Javier Martinez Canillas
0 siblings, 1 reply; 6+ messages in thread
From: Linus Walleij @ 2016-10-21 12:55 UTC (permalink / raw)
To: Javier Martinez Canillas
Cc: linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org,
Alexandre Courbot
On Tue, Oct 18, 2016 at 10:44 PM, Javier Martinez Canillas
<javier@osg.samsung.com> wrote:
> If the driver is built as a module, autoload won't work because the module
> alias information is not filled. So user-space can't match the registered
> device with the corresponding module.
>
> Export the module alias information using the MODULE_DEVICE_TABLE() macro.
>
> Before this patch:
>
> $ modinfo drivers/gpio/gpio-ts4800.ko | grep alias
> $
>
> After this patch:
>
> $ modinfo drivers/gpio/gpio-ts4800.ko | grep alias
> alias: of:N*T*Ctechnologic,ts4800-gpioC*
> alias: of:N*T*Ctechnologic,ts4800-gpio
>
> Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com>
Patch applied for fixes.
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 2/2] gpio: ts4800: Fix module autoload
2016-10-21 12:55 ` Linus Walleij
@ 2016-10-21 13:32 ` Javier Martinez Canillas
0 siblings, 0 replies; 6+ messages in thread
From: Javier Martinez Canillas @ 2016-10-21 13:32 UTC (permalink / raw)
To: Linus Walleij
Cc: linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org,
Alexandre Courbot
Hello Linus,
On 10/21/2016 09:55 AM, Linus Walleij wrote:
> On Tue, Oct 18, 2016 at 10:44 PM, Javier Martinez Canillas
> <javier@osg.samsung.com> wrote:
>
>> If the driver is built as a module, autoload won't work because the module
>> alias information is not filled. So user-space can't match the registered
>> device with the corresponding module.
>>
>> Export the module alias information using the MODULE_DEVICE_TABLE() macro.
>>
>> Before this patch:
>>
>> $ modinfo drivers/gpio/gpio-ts4800.ko | grep alias
>> $
>>
>> After this patch:
>>
>> $ modinfo drivers/gpio/gpio-ts4800.ko | grep alias
>> alias: of:N*T*Ctechnologic,ts4800-gpioC*
>> alias: of:N*T*Ctechnologic,ts4800-gpio
>>
>> Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com>
>
> Patch applied for fixes.
>
Thanks, I guess this also applies to Patch 1/2?
> Yours,
> Linus Walleij
>
Best regards,
--
Javier Martinez Canillas
Open Source Group
Samsung Research America
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 1/2] gpio: ath79: Fix module autoload
2016-10-18 20:44 [PATCH 1/2] gpio: ath79: Fix module autoload Javier Martinez Canillas
2016-10-18 20:44 ` [PATCH 2/2] gpio: ts4800: " Javier Martinez Canillas
@ 2016-10-19 17:10 ` Alban
2016-10-23 22:23 ` Linus Walleij
2 siblings, 0 replies; 6+ messages in thread
From: Alban @ 2016-10-19 17:10 UTC (permalink / raw)
To: Javier Martinez Canillas
Cc: Aban Bedel, linux-kernel, linux-gpio, Linus Walleij,
Alexandre Courbot
[-- Attachment #1: Type: text/plain, Size: 841 bytes --]
On Tue, 18 Oct 2016 17:44:01 -0300
Javier Martinez Canillas <javier@osg.samsung.com> wrote:
> If the driver is built as a module, autoload won't work because the module
> alias information is not filled. So user-space can't match the registered
> device with the corresponding module.
>
> Export the module alias information using the MODULE_DEVICE_TABLE() macro.
>
> Before this patch:
>
> $ modinfo drivers/gpio/gpio-ath79.ko | grep alias
> $
>
> After this patch:
>
> $ modinfo drivers/gpio/gpio-ath79.ko | grep alias
> alias: of:N*T*Cqca,ar9340-gpioC*
> alias: of:N*T*Cqca,ar9340-gpio
> alias: of:N*T*Cqca,ar7100-gpioC*
> alias: of:N*T*Cqca,ar7100-gpio
>
> Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com>
Acked-by: Aban Bedel <albeu@free.fr>
Alban
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 1/2] gpio: ath79: Fix module autoload
2016-10-18 20:44 [PATCH 1/2] gpio: ath79: Fix module autoload Javier Martinez Canillas
2016-10-18 20:44 ` [PATCH 2/2] gpio: ts4800: " Javier Martinez Canillas
2016-10-19 17:10 ` [PATCH 1/2] gpio: ath79: " Alban
@ 2016-10-23 22:23 ` Linus Walleij
2 siblings, 0 replies; 6+ messages in thread
From: Linus Walleij @ 2016-10-23 22:23 UTC (permalink / raw)
To: Javier Martinez Canillas
Cc: linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org,
Alban Bedel, Alexandre Courbot
On Tue, Oct 18, 2016 at 10:44 PM, Javier Martinez Canillas
<javier@osg.samsung.com> wrote:
> If the driver is built as a module, autoload won't work because the module
> alias information is not filled. So user-space can't match the registered
> device with the corresponding module.
>
> Export the module alias information using the MODULE_DEVICE_TABLE() macro.
>
> Before this patch:
>
> $ modinfo drivers/gpio/gpio-ath79.ko | grep alias
> $
>
> After this patch:
>
> $ modinfo drivers/gpio/gpio-ath79.ko | grep alias
> alias: of:N*T*Cqca,ar9340-gpioC*
> alias: of:N*T*Cqca,ar9340-gpio
> alias: of:N*T*Cqca,ar7100-gpioC*
> alias: of:N*T*Cqca,ar7100-gpio
>
> Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com>
Patch applied with Alban's ACK.
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2016-10-23 22:23 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-10-18 20:44 [PATCH 1/2] gpio: ath79: Fix module autoload Javier Martinez Canillas
2016-10-18 20:44 ` [PATCH 2/2] gpio: ts4800: " Javier Martinez Canillas
2016-10-21 12:55 ` Linus Walleij
2016-10-21 13:32 ` Javier Martinez Canillas
2016-10-19 17:10 ` [PATCH 1/2] gpio: ath79: " Alban
2016-10-23 22:23 ` Linus Walleij
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).