[PATCH v2] gpio: em: depnd on ARCH_SHMOBILE

[PATCH v2] gpio: em: depnd on ARCH_SHMOBILE

[Peter Robinson]

The GPIO_EM is part of the Renesas SoCs so depend on the arch.

Signed-off-by: Peter Robinson <pbrobinson@gmail.com>
---
 drivers/gpio/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

v1->v2:
        - Add COMPILE_TEST

diff --git a/drivers/gpio/Kconfig b/drivers/gpio/Kconfig
index d011cb8..a09e237 100644
--- a/drivers/gpio/Kconfig
+++ b/drivers/gpio/Kconfig
@@ -171,7 +171,7 @@ config GPIO_DWAPB
 
 config GPIO_EM
 	tristate "Emma Mobile GPIO"
-	depends on ARM && OF_GPIO
+	depends on (ARCH_SHMOBILE || COMPILE_TEST) && OF_GPIO
 	help
 	  Say yes here to support GPIO on Renesas Emma Mobile SoCs.
 
-- 
2.9.3

Re: [PATCH v2] gpio: em: depnd on ARCH_SHMOBILE

[Linus Walleij]

On Sun, Nov 20, 2016 at 6:48 PM, Peter Robinson <pbrobinson@gmail.com> wrote:

> The GPIO_EM is part of the Renesas SoCs so depend on the arch.
>
> Signed-off-by: Peter Robinson <pbrobinson@gmail.com>

Patch applied.

Yours,
Linus Walleij

Re: [PATCH v2] gpio: em: depnd on ARCH_SHMOBILE

[Geert Uytterhoeven]

CC linux-renesas-soc

On Sun, Nov 20, 2016 at 6:48 PM, Peter Robinson <pbrobinson@gmail.com> wrote:
> The GPIO_EM is part of the Renesas SoCs so depend on the arch.
>
> Signed-off-by: Peter Robinson <pbrobinson@gmail.com>
> ---
>  drivers/gpio/Kconfig | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> v1->v2:
>         - Add COMPILE_TEST
>
> diff --git a/drivers/gpio/Kconfig b/drivers/gpio/Kconfig
> index d011cb8..a09e237 100644
> --- a/drivers/gpio/Kconfig
> +++ b/drivers/gpio/Kconfig
> @@ -171,7 +171,7 @@ config GPIO_DWAPB
>
>  config GPIO_EM
>         tristate "Emma Mobile GPIO"
> -       depends on ARM && OF_GPIO
> +       depends on (ARCH_SHMOBILE || COMPILE_TEST) && OF_GPIO

For ARM SoCs, ARCH_SHMOBILE is being phased out in favor of ARCH_RENESAS.
Note that ARCH_SHMOBILE is also set for some SuperH SoCs.

However, ARCH_EMEV2 is even more suitable here.

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

Re: [PATCH v2] gpio: em: depnd on ARCH_SHMOBILE

[Linus Walleij]

On Thu, Nov 24, 2016 at 10:38 AM, Geert Uytterhoeven
<geert@linux-m68k.org> wrote:
> On Sun, Nov 20, 2016 at 6:48 PM, Peter Robinson <pbrobinson@gmail.com> wrote:
>> The GPIO_EM is part of the Renesas SoCs so depend on the arch.

>>  config GPIO_EM
>>         tristate "Emma Mobile GPIO"
>> -       depends on ARM && OF_GPIO
>> +       depends on (ARCH_SHMOBILE || COMPILE_TEST) && OF_GPIO
>
> For ARM SoCs, ARCH_SHMOBILE is being phased out in favor of ARCH_RENESAS.
> Note that ARCH_SHMOBILE is also set for some SuperH SoCs.
>
> However, ARCH_EMEV2 is even more suitable here.

I fixed the patch in-tree to use ARCH_EMEV2 instead.

Thanks!

Yours,
Linus Walleij

Re: [PATCH v2] gpio: em: depnd on ARCH_SHMOBILE

[Peter Robinson]

On Thu, Nov 24, 2016 at 3:19 PM, Linus Walleij <linus.walleij@linaro.org> wrote:
> On Thu, Nov 24, 2016 at 10:38 AM, Geert Uytterhoeven
> <geert@linux-m68k.org> wrote:
>> On Sun, Nov 20, 2016 at 6:48 PM, Peter Robinson <pbrobinson@gmail.com> wrote:
>>> The GPIO_EM is part of the Renesas SoCs so depend on the arch.
>
>>>  config GPIO_EM
>>>         tristate "Emma Mobile GPIO"
>>> -       depends on ARM && OF_GPIO
>>> +       depends on (ARCH_SHMOBILE || COMPILE_TEST) && OF_GPIO
>>
>> For ARM SoCs, ARCH_SHMOBILE is being phased out in favor of ARCH_RENESAS.
>> Note that ARCH_SHMOBILE is also set for some SuperH SoCs.
>>
>> However, ARCH_EMEV2 is even more suitable here.
>
> I fixed the patch in-tree to use ARCH_EMEV2 instead.

Awesome, thanks, I was going to do a follow up patch.

Peter