* [PATCH v2] gpio: em: depnd on ARCH_SHMOBILE
@ 2016-11-20 17:48 Peter Robinson
2016-11-22 9:23 ` Linus Walleij
2016-11-24 9:38 ` Geert Uytterhoeven
0 siblings, 2 replies; 5+ messages in thread
From: Peter Robinson @ 2016-11-20 17:48 UTC (permalink / raw)
To: Linus Walleij, Alexandre Courbot, linux-gpio; +Cc: Peter Robinson
The GPIO_EM is part of the Renesas SoCs so depend on the arch.
Signed-off-by: Peter Robinson <pbrobinson@gmail.com>
---
drivers/gpio/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
v1->v2:
- Add COMPILE_TEST
diff --git a/drivers/gpio/Kconfig b/drivers/gpio/Kconfig
index d011cb8..a09e237 100644
--- a/drivers/gpio/Kconfig
+++ b/drivers/gpio/Kconfig
@@ -171,7 +171,7 @@ config GPIO_DWAPB
config GPIO_EM
tristate "Emma Mobile GPIO"
- depends on ARM && OF_GPIO
+ depends on (ARCH_SHMOBILE || COMPILE_TEST) && OF_GPIO
help
Say yes here to support GPIO on Renesas Emma Mobile SoCs.
--
2.9.3
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [PATCH v2] gpio: em: depnd on ARCH_SHMOBILE
2016-11-20 17:48 [PATCH v2] gpio: em: depnd on ARCH_SHMOBILE Peter Robinson
@ 2016-11-22 9:23 ` Linus Walleij
2016-11-24 9:38 ` Geert Uytterhoeven
1 sibling, 0 replies; 5+ messages in thread
From: Linus Walleij @ 2016-11-22 9:23 UTC (permalink / raw)
To: Peter Robinson; +Cc: Alexandre Courbot, linux-gpio@vger.kernel.org
On Sun, Nov 20, 2016 at 6:48 PM, Peter Robinson <pbrobinson@gmail.com> wrote:
> The GPIO_EM is part of the Renesas SoCs so depend on the arch.
>
> Signed-off-by: Peter Robinson <pbrobinson@gmail.com>
Patch applied.
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH v2] gpio: em: depnd on ARCH_SHMOBILE
2016-11-20 17:48 [PATCH v2] gpio: em: depnd on ARCH_SHMOBILE Peter Robinson
2016-11-22 9:23 ` Linus Walleij
@ 2016-11-24 9:38 ` Geert Uytterhoeven
2016-11-24 15:19 ` Linus Walleij
1 sibling, 1 reply; 5+ messages in thread
From: Geert Uytterhoeven @ 2016-11-24 9:38 UTC (permalink / raw)
To: Peter Robinson
Cc: Linus Walleij, Alexandre Courbot, linux-gpio@vger.kernel.org,
Linux-Renesas
CC linux-renesas-soc
On Sun, Nov 20, 2016 at 6:48 PM, Peter Robinson <pbrobinson@gmail.com> wrote:
> The GPIO_EM is part of the Renesas SoCs so depend on the arch.
>
> Signed-off-by: Peter Robinson <pbrobinson@gmail.com>
> ---
> drivers/gpio/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> v1->v2:
> - Add COMPILE_TEST
>
> diff --git a/drivers/gpio/Kconfig b/drivers/gpio/Kconfig
> index d011cb8..a09e237 100644
> --- a/drivers/gpio/Kconfig
> +++ b/drivers/gpio/Kconfig
> @@ -171,7 +171,7 @@ config GPIO_DWAPB
>
> config GPIO_EM
> tristate "Emma Mobile GPIO"
> - depends on ARM && OF_GPIO
> + depends on (ARCH_SHMOBILE || COMPILE_TEST) && OF_GPIO
For ARM SoCs, ARCH_SHMOBILE is being phased out in favor of ARCH_RENESAS.
Note that ARCH_SHMOBILE is also set for some SuperH SoCs.
However, ARCH_EMEV2 is even more suitable here.
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH v2] gpio: em: depnd on ARCH_SHMOBILE
2016-11-24 9:38 ` Geert Uytterhoeven
@ 2016-11-24 15:19 ` Linus Walleij
2016-11-24 15:59 ` Peter Robinson
0 siblings, 1 reply; 5+ messages in thread
From: Linus Walleij @ 2016-11-24 15:19 UTC (permalink / raw)
To: Geert Uytterhoeven
Cc: Peter Robinson, Alexandre Courbot, linux-gpio@vger.kernel.org,
Linux-Renesas
On Thu, Nov 24, 2016 at 10:38 AM, Geert Uytterhoeven
<geert@linux-m68k.org> wrote:
> On Sun, Nov 20, 2016 at 6:48 PM, Peter Robinson <pbrobinson@gmail.com> wrote:
>> The GPIO_EM is part of the Renesas SoCs so depend on the arch.
>> config GPIO_EM
>> tristate "Emma Mobile GPIO"
>> - depends on ARM && OF_GPIO
>> + depends on (ARCH_SHMOBILE || COMPILE_TEST) && OF_GPIO
>
> For ARM SoCs, ARCH_SHMOBILE is being phased out in favor of ARCH_RENESAS.
> Note that ARCH_SHMOBILE is also set for some SuperH SoCs.
>
> However, ARCH_EMEV2 is even more suitable here.
I fixed the patch in-tree to use ARCH_EMEV2 instead.
Thanks!
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH v2] gpio: em: depnd on ARCH_SHMOBILE
2016-11-24 15:19 ` Linus Walleij
@ 2016-11-24 15:59 ` Peter Robinson
0 siblings, 0 replies; 5+ messages in thread
From: Peter Robinson @ 2016-11-24 15:59 UTC (permalink / raw)
To: Linus Walleij
Cc: Geert Uytterhoeven, Alexandre Courbot, linux-gpio@vger.kernel.org,
Linux-Renesas
On Thu, Nov 24, 2016 at 3:19 PM, Linus Walleij <linus.walleij@linaro.org> wrote:
> On Thu, Nov 24, 2016 at 10:38 AM, Geert Uytterhoeven
> <geert@linux-m68k.org> wrote:
>> On Sun, Nov 20, 2016 at 6:48 PM, Peter Robinson <pbrobinson@gmail.com> wrote:
>>> The GPIO_EM is part of the Renesas SoCs so depend on the arch.
>
>>> config GPIO_EM
>>> tristate "Emma Mobile GPIO"
>>> - depends on ARM && OF_GPIO
>>> + depends on (ARCH_SHMOBILE || COMPILE_TEST) && OF_GPIO
>>
>> For ARM SoCs, ARCH_SHMOBILE is being phased out in favor of ARCH_RENESAS.
>> Note that ARCH_SHMOBILE is also set for some SuperH SoCs.
>>
>> However, ARCH_EMEV2 is even more suitable here.
>
> I fixed the patch in-tree to use ARCH_EMEV2 instead.
Awesome, thanks, I was going to do a follow up patch.
Peter
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2016-11-24 15:59 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-11-20 17:48 [PATCH v2] gpio: em: depnd on ARCH_SHMOBILE Peter Robinson
2016-11-22 9:23 ` Linus Walleij
2016-11-24 9:38 ` Geert Uytterhoeven
2016-11-24 15:19 ` Linus Walleij
2016-11-24 15:59 ` Peter Robinson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).