linux-gpio.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Lee Jones <lee.jones-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
To: Keerthy <j-keerthy-l0cyMroinI0@public.gmane.org>
Cc: tony-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org,
	robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org,
	linux-omap-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	linux-gpio-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	nm-l0cyMroinI0@public.gmane.org,
	t-kristo-l0cyMroinI0@public.gmane.org
Subject: Re: [PATCH v2 2/5] mfd: palmas: Remove redundant check in palmas_power_off
Date: Tue, 22 Nov 2016 13:02:08 +0000	[thread overview]
Message-ID: <20161122130208.GD316@dell.lan> (raw)
In-Reply-To: <1478754560-27923-3-git-send-email-j-keerthy-l0cyMroinI0@public.gmane.org>

On Thu, 10 Nov 2016, Keerthy wrote:

> palmas_dev and palmas_power_off are always assigned together.
> So the check for palmas_dev inside palmas_power_off function
> is redundant. Removing the same.
> 
> Signed-off-by: Keerthy <j-keerthy-l0cyMroinI0@public.gmane.org>
> ---
>  drivers/mfd/palmas.c | 3 ---
>  1 file changed, 3 deletions(-)

Applied, thanks.

> diff --git a/drivers/mfd/palmas.c b/drivers/mfd/palmas.c
> index 8f8bacb..ee9e9ea 100644
> --- a/drivers/mfd/palmas.c
> +++ b/drivers/mfd/palmas.c
> @@ -431,9 +431,6 @@ static void palmas_power_off(void)
>  	unsigned int addr;
>  	int ret, slave;
>  
> -	if (!palmas_dev)
> -		return;
> -
>  	slave = PALMAS_BASE_TO_SLAVE(PALMAS_PMU_CONTROL_BASE);
>  	addr = PALMAS_BASE_TO_REG(PALMAS_PMU_CONTROL_BASE, PALMAS_DEV_CTRL);
>  

-- 
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

  parent reply	other threads:[~2016-11-22 13:02 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-11-10  5:09 [PATCH v2 0/5] mfd: palmas: add powerhold overriding during power off Keerthy
2016-11-10  5:09 ` [PATCH v2 1/5] Documentation: pinctrl: palmas: Add ti,palmas-powerhold-override property definition Keerthy
2016-11-15  1:43   ` Rob Herring
2016-11-24  5:28     ` Keerthy
2016-11-24  8:45       ` Lee Jones
2016-11-28  3:51         ` Keerthy
2016-11-10  5:09 ` [PATCH v2 2/5] mfd: palmas: Remove redundant check in palmas_power_off Keerthy
     [not found]   ` <1478754560-27923-3-git-send-email-j-keerthy-l0cyMroinI0@public.gmane.org>
2016-11-22 13:02     ` Lee Jones [this message]
     [not found] ` <1478754560-27923-1-git-send-email-j-keerthy-l0cyMroinI0@public.gmane.org>
2016-11-10  5:09   ` [PATCH v2 3/5] mfd: palmas: Reset the POWERHOLD mux during power off Keerthy
2016-11-22 13:03     ` Lee Jones
2017-03-24 10:00       ` Keerthy
2017-03-24 11:30         ` Lee Jones
2017-03-24 11:36           ` Keerthy
2016-11-10  5:09 ` [PATCH v2 4/5] arm: dts: am57xx-beagle-x15-common: Add overide powerhold property Keerthy
2016-11-15  0:08   ` Tony Lindgren
     [not found]     ` <20161115000849.GD4082-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org>
2016-11-23  3:35       ` Keerthy
2016-11-23  8:33         ` Lee Jones
2016-11-23  8:32           ` Keerthy
     [not found]             ` <3a05871c-0512-8a84-4ac3-889c661c8638-l0cyMroinI0@public.gmane.org>
2016-11-23 16:08               ` Tony Lindgren
2016-11-24  3:45                 ` Keerthy
2016-11-10  5:09 ` [PATCH v2 5/5] arm: dts: am57xx-idk-common: " Keerthy
2016-11-15  0:09   ` Tony Lindgren

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20161122130208.GD316@dell.lan \
    --to=lee.jones-qsej5fyqhm4dnm+yrofe0a@public.gmane.org \
    --cc=devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=j-keerthy-l0cyMroinI0@public.gmane.org \
    --cc=linux-gpio-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=linux-omap-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=nm-l0cyMroinI0@public.gmane.org \
    --cc=robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
    --cc=t-kristo-l0cyMroinI0@public.gmane.org \
    --cc=tony-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).