* Re: [PATCH] pinctrl: imx: fix imx_pinctrl_desc initialization
2016-11-24 18:11 [PATCH] pinctrl: imx: fix imx_pinctrl_desc initialization Gary Bisson
@ 2016-11-24 18:14 ` Gary Bisson
2016-11-24 20:17 ` Vladimir Zapolskiy
` (2 subsequent siblings)
3 siblings, 0 replies; 5+ messages in thread
From: Gary Bisson @ 2016-11-24 18:14 UTC (permalink / raw)
To: shawnguo
Cc: linus.walleij, vladimir_zapolskiy, van.freenix, linux-gpio,
linux-kernel
Hi all,
Just resending this email since there was a typo in Shawn's e-mail
address.
Regards,
Gary
On Thu, Nov 24, 2016 at 07:11:51PM +0100, Gary Bisson wrote:
> Was introduced by:
> 6e408ed pinctrl: imx: fix initialization of imx_pinctrl_desc
>
> Signed-off-by: Gary Bisson <gary.bisson@boundarydevices.com>
> ---
> drivers/pinctrl/freescale/pinctrl-imx.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/pinctrl/freescale/pinctrl-imx.c b/drivers/pinctrl/freescale/pinctrl-imx.c
> index 79c4e14..5ef7e87 100644
> --- a/drivers/pinctrl/freescale/pinctrl-imx.c
> +++ b/drivers/pinctrl/freescale/pinctrl-imx.c
> @@ -778,10 +778,10 @@ int imx_pinctrl_probe(struct platform_device *pdev,
> imx_pinctrl_desc->name = dev_name(&pdev->dev);
> imx_pinctrl_desc->pins = info->pins;
> imx_pinctrl_desc->npins = info->npins;
> - imx_pinctrl_desc->pctlops = &imx_pctrl_ops,
> - imx_pinctrl_desc->pmxops = &imx_pmx_ops,
> - imx_pinctrl_desc->confops = &imx_pinconf_ops,
> - imx_pinctrl_desc->owner = THIS_MODULE,
> + imx_pinctrl_desc->pctlops = &imx_pctrl_ops;
> + imx_pinctrl_desc->pmxops = &imx_pmx_ops;
> + imx_pinctrl_desc->confops = &imx_pinconf_ops;
> + imx_pinctrl_desc->owner = THIS_MODULE;
>
> ret = imx_pinctrl_probe_dt(pdev, info);
> if (ret) {
> --
> 2.9.3
>
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] pinctrl: imx: fix imx_pinctrl_desc initialization
2016-11-24 18:11 [PATCH] pinctrl: imx: fix imx_pinctrl_desc initialization Gary Bisson
2016-11-24 18:14 ` Gary Bisson
@ 2016-11-24 20:17 ` Vladimir Zapolskiy
2016-11-25 1:16 ` Peng Fan
2016-11-25 13:11 ` Linus Walleij
3 siblings, 0 replies; 5+ messages in thread
From: Vladimir Zapolskiy @ 2016-11-24 20:17 UTC (permalink / raw)
To: Gary Bisson, shawnguo
Cc: linus.walleij, van.freenix, linux-gpio, linux-kernel
Hi Gary,
On 11/24/2016 08:11 PM, Gary Bisson wrote:
> Was introduced by:
> 6e408ed pinctrl: imx: fix initialization of imx_pinctrl_desc
>
> Signed-off-by: Gary Bisson <gary.bisson@boundarydevices.com>
> ---
> drivers/pinctrl/freescale/pinctrl-imx.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/pinctrl/freescale/pinctrl-imx.c b/drivers/pinctrl/freescale/pinctrl-imx.c
> index 79c4e14..5ef7e87 100644
> --- a/drivers/pinctrl/freescale/pinctrl-imx.c
> +++ b/drivers/pinctrl/freescale/pinctrl-imx.c
> @@ -778,10 +778,10 @@ int imx_pinctrl_probe(struct platform_device *pdev,
> imx_pinctrl_desc->name = dev_name(&pdev->dev);
> imx_pinctrl_desc->pins = info->pins;
> imx_pinctrl_desc->npins = info->npins;
> - imx_pinctrl_desc->pctlops = &imx_pctrl_ops,
> - imx_pinctrl_desc->pmxops = &imx_pmx_ops,
> - imx_pinctrl_desc->confops = &imx_pinconf_ops,
> - imx_pinctrl_desc->owner = THIS_MODULE,
> + imx_pinctrl_desc->pctlops = &imx_pctrl_ops;
> + imx_pinctrl_desc->pmxops = &imx_pmx_ops;
> + imx_pinctrl_desc->confops = &imx_pinconf_ops;
> + imx_pinctrl_desc->owner = THIS_MODULE;
>
> ret = imx_pinctrl_probe_dt(pdev, info);
> if (ret) {
>
excellent catch, my compiler does not report the issue.
Subject and commit message are not quite informative, but
the change is trivial, so please feel free to add my
Reviewed-by: Vladimir Zapolskiy <vladimir_zapolskiy@mentor.com>
--
With best wishes,
Vladimir
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] pinctrl: imx: fix imx_pinctrl_desc initialization
2016-11-24 18:11 [PATCH] pinctrl: imx: fix imx_pinctrl_desc initialization Gary Bisson
2016-11-24 18:14 ` Gary Bisson
2016-11-24 20:17 ` Vladimir Zapolskiy
@ 2016-11-25 1:16 ` Peng Fan
2016-11-25 13:11 ` Linus Walleij
3 siblings, 0 replies; 5+ messages in thread
From: Peng Fan @ 2016-11-25 1:16 UTC (permalink / raw)
To: Gary Bisson
Cc: hawnguo, linus.walleij, vladimir_zapolskiy, linux-gpio,
linux-kernel
Hi Gary,
On Thu, Nov 24, 2016 at 07:11:51PM +0100, Gary Bisson wrote:
>Was introduced by:
>6e408ed pinctrl: imx: fix initialization of imx_pinctrl_desc
>
>Signed-off-by: Gary Bisson <gary.bisson@boundarydevices.com>
>---
> drivers/pinctrl/freescale/pinctrl-imx.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
>diff --git a/drivers/pinctrl/freescale/pinctrl-imx.c b/drivers/pinctrl/freescale/pinctrl-imx.c
>index 79c4e14..5ef7e87 100644
>--- a/drivers/pinctrl/freescale/pinctrl-imx.c
>+++ b/drivers/pinctrl/freescale/pinctrl-imx.c
>@@ -778,10 +778,10 @@ int imx_pinctrl_probe(struct platform_device *pdev,
> imx_pinctrl_desc->name = dev_name(&pdev->dev);
> imx_pinctrl_desc->pins = info->pins;
> imx_pinctrl_desc->npins = info->npins;
>- imx_pinctrl_desc->pctlops = &imx_pctrl_ops,
>- imx_pinctrl_desc->pmxops = &imx_pmx_ops,
>- imx_pinctrl_desc->confops = &imx_pinconf_ops,
>- imx_pinctrl_desc->owner = THIS_MODULE,
>+ imx_pinctrl_desc->pctlops = &imx_pctrl_ops;
>+ imx_pinctrl_desc->pmxops = &imx_pmx_ops;
>+ imx_pinctrl_desc->confops = &imx_pinconf_ops;
>+ imx_pinctrl_desc->owner = THIS_MODULE;
Thanks for the fix.
Reviewed-by: Peng Fan <peng.fan@nxp.com>
>
> ret = imx_pinctrl_probe_dt(pdev, info);
> if (ret) {
>--
>2.9.3
>
--
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] pinctrl: imx: fix imx_pinctrl_desc initialization
2016-11-24 18:11 [PATCH] pinctrl: imx: fix imx_pinctrl_desc initialization Gary Bisson
` (2 preceding siblings ...)
2016-11-25 1:16 ` Peng Fan
@ 2016-11-25 13:11 ` Linus Walleij
3 siblings, 0 replies; 5+ messages in thread
From: Linus Walleij @ 2016-11-25 13:11 UTC (permalink / raw)
To: Gary Bisson
Cc: hawnguo, Vladimir Zapolskiy, Peng Fan, linux-gpio@vger.kernel.org,
linux-kernel@vger.kernel.org
On Thu, Nov 24, 2016 at 7:11 PM, Gary Bisson
<gary.bisson@boundarydevices.com> wrote:
> Was introduced by:
> 6e408ed pinctrl: imx: fix initialization of imx_pinctrl_desc
>
> Signed-off-by: Gary Bisson <gary.bisson@boundarydevices.com>
Patch applied with the review tags.
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 5+ messages in thread