From: Beniamino Galvani <b.galvani@gmail.com>
To: Neil Armstrong <narmstrong@baylibre.com>
Cc: linus.walleij@linaro.org, carlo@caione.org, khilman@baylibre.com,
linux-gpio@vger.kernel.org, linux-amlogic@lists.infradead.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] pinctrl: meson: fix gpio request disabling other modes
Date: Sun, 11 Dec 2016 22:50:28 +0100 [thread overview]
Message-ID: <20161211215028.GA22499@gmail.com> (raw)
In-Reply-To: <20161206140817.11708-1-narmstrong@baylibre.com>
On Tue, Dec 06, 2016 at 03:08:16PM +0100, Neil Armstrong wrote:
> The pinctrl_gpio_request is called with the "full" gpio number, already
> containing the base, then meson_pmx_request_gpio is then called with the
> final pin number.
> Remove the base addition when calling meson_pmx_disable_other_groups.
>
> Fixes: 6ac730951104 ("pinctrl: add driver for Amlogic Meson SoCs")
> CC: Beniamino Galvani <b.galvani@gmail.com>
> Signed-off-by: Neil Armstrong <narmstrong@baylibre.com>
Acked-by: Beniamino Galvani <b.galvani@gmail.com>
next prev parent reply other threads:[~2016-12-11 21:50 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-06 14:08 [PATCH] pinctrl: meson: fix gpio request disabling other modes Neil Armstrong
2016-12-07 0:47 ` Kevin Hilman
2016-12-11 21:50 ` Beniamino Galvani [this message]
2016-12-28 12:41 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161211215028.GA22499@gmail.com \
--to=b.galvani@gmail.com \
--cc=carlo@caione.org \
--cc=khilman@baylibre.com \
--cc=linus.walleij@linaro.org \
--cc=linux-amlogic@lists.infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=narmstrong@baylibre.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).