From: Maxime Ripard <maxime.ripard-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>
To: Icenowy Zheng <icenowy-ymACFijhrKM@public.gmane.org>
Cc: Chen-Yu Tsai <wens-jdAy2FN1RRM@public.gmane.org>,
Stephen Boyd <sboyd-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>,
Linus Walleij
<linus.walleij-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>,
linux-doc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-clk-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-gpio-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-sunxi-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org
Subject: Re: [PATCH 4/5] ARM: dts: sunxi: add dtsi file for V3s SoC
Date: Tue, 10 Jan 2017 19:21:06 +0100 [thread overview]
Message-ID: <20170110182106.7q7uduxxqbzg4squ@lukather> (raw)
In-Reply-To: <20170103151629.19447-5-icenowy-ymACFijhrKM@public.gmane.org>
[-- Attachment #1: Type: text/plain, Size: 338 bytes --]
On Tue, Jan 03, 2017 at 11:16:28PM +0800, Icenowy Zheng wrote:
> + uart0_pins_a: uart0@0 {
> + pins = "PB8", "PB9";
> + function = "uart0";
> + bias-pull-up;
Why do you need a pullup here?
Looks good otherwise.
Thanks!
Maxime
--
Maxime Ripard, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
next prev parent reply other threads:[~2017-01-10 18:21 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-03 15:16 [PATCH 0/5] add support for Allwinner V3s SoC Icenowy Zheng
[not found] ` <20170103151629.19447-1-icenowy-ymACFijhrKM@public.gmane.org>
2017-01-03 15:16 ` [PATCH 1/5] arm: sunxi: add support for " Icenowy Zheng
[not found] ` <20170103151629.19447-2-icenowy-ymACFijhrKM@public.gmane.org>
2017-01-10 18:09 ` Maxime Ripard
2017-01-11 19:40 ` Icenowy Zheng
[not found] ` <2706391484163632-/w1NKm4lK9luio3avFS2gg@public.gmane.org>
2017-01-12 17:17 ` Maxime Ripard
2017-01-03 15:16 ` [PATCH 2/5] clk: sunxi-ng: add support for V3s CCU Icenowy Zheng
[not found] ` <20170103151629.19447-3-icenowy-ymACFijhrKM@public.gmane.org>
2017-01-10 18:10 ` Maxime Ripard
2017-01-11 19:39 ` Icenowy Zheng
[not found] ` <2705031484163593-/w1NKm4lK9luio3avFS2gg@public.gmane.org>
2017-01-11 19:44 ` Icenowy Zheng
[not found] ` <2714901484163893-/w1NKm4lK9luio3avFS2gg@public.gmane.org>
2017-01-12 17:19 ` Maxime Ripard
2017-01-03 15:16 ` [PATCH 3/5] pinctrl: sunxi: add driver for V3s SoC Icenowy Zheng
[not found] ` <20170103151629.19447-4-icenowy-ymACFijhrKM@public.gmane.org>
2017-01-10 18:18 ` Maxime Ripard
2017-01-11 15:24 ` Linus Walleij
2017-01-03 15:16 ` [PATCH 4/5] ARM: dts: sunxi: add dtsi file " Icenowy Zheng
[not found] ` <20170103151629.19447-5-icenowy-ymACFijhrKM@public.gmane.org>
2017-01-10 18:21 ` Maxime Ripard [this message]
2017-01-03 15:16 ` [PATCH 5/5] ARM: dts: sunxi: add support for Lichee Pi Zero board Icenowy Zheng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170110182106.7q7uduxxqbzg4squ@lukather \
--to=maxime.ripard-wi1+55scjutkeb57/3fjtnbpr1lh4cv8@public.gmane.org \
--cc=devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=icenowy-ymACFijhrKM@public.gmane.org \
--cc=linus.walleij-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org \
--cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
--cc=linux-clk-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-doc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-gpio-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-sunxi-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org \
--cc=sboyd-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org \
--cc=wens-jdAy2FN1RRM@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).