[PATCH 0/3] pc104: Mask PC/104 Kconfig options

[PATCH 0/3] pc104: Mask PC/104 Kconfig options

[William Breathitt Gray]

PC/104 form factor devices serve a specific niche of embedded system
users. Since PC/104 devices and hardware are typically used by just a
subset of Linux users, it would be appropriate to filter PC/104 related
Kconfig options for those uninterested.

This patchset introduces the PC104 Kconfig option, and uses it to mask
PC/104 specific device drivers and options, so that only those users
interested in PC/104 related Kconfig options are exposed to them.

William Breathitt Gray (3):
  pc104: Introduce the PC104 Kconfig option
  gpio: pc104: Mask PC/104 drivers via PC104 Kconfig option
  iio: pc104: Mask PC/104 drivers via the PC104 Kconfig option

 drivers/gpio/Kconfig        | 8 ++++----
 drivers/iio/adc/Kconfig     | 2 +-
 drivers/iio/counter/Kconfig | 2 +-
 init/Kconfig                | 7 +++++++
 4 files changed, 13 insertions(+), 6 deletions(-)

-- 
2.11.0

[PATCH 1/3] pc104: Introduce the PC104 Kconfig option

[William Breathitt Gray]

PC/104 form factor devices serve a specific niche of embedded system
users; most Linux users will not have PC/104 form factor devices. This
patch introduces the PC104 Kconfig option, which should be used to
filter PC/104 specific device drivers and options, so that only those
users interested in PC/104 related options are exposed to them.

Signed-off-by: William Breathitt Gray <vilhelm.gray@gmail.com>
---
 init/Kconfig | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/init/Kconfig b/init/Kconfig
index 223b734abccd..12841d75a04d 100644
--- a/init/Kconfig
+++ b/init/Kconfig
@@ -1716,6 +1716,13 @@ config PERF_USE_VMALLOC
 	help
 	  See tools/perf/design.txt for details
 
+config PC104
+	bool "PC/104 support"
+	help
+	  Expose PC/104 form factor device drivers and options available for
+	  selection and configuration. Enable this option if your target
+	  machine has a PC/104 bus.
+
 menu "Kernel Performance Events And Counters"
 
 config PERF_EVENTS
-- 
2.11.0

[PATCH 2/3] gpio: pc104: Mask PC/104 drivers via PC104 Kconfig option

[William Breathitt Gray]

PC/104 drivers should be hidden on machines which do not support PC/104
devices. This patch adds the PC104 Kconfig option as a dependency for
the relevant PC/104 device driver Kconfig options.

Cc: Linus Walleij <linus.walleij@linaro.org>
Cc: Alexandre Courbot <gnurou@gmail.com>
Signed-off-by: William Breathitt Gray <vilhelm.gray@gmail.com>
---
 drivers/gpio/Kconfig | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/drivers/gpio/Kconfig b/drivers/gpio/Kconfig
index d5d36549ecc1..ad7084d98c60 100644
--- a/drivers/gpio/Kconfig
+++ b/drivers/gpio/Kconfig
@@ -539,7 +539,7 @@ menu "Port-mapped I/O GPIO drivers"
 
 config GPIO_104_DIO_48E
 	tristate "ACCES 104-DIO-48E GPIO support"
-	depends on ISA_BUS_API
+	depends on PC104 && ISA_BUS_API
 	select GPIOLIB_IRQCHIP
 	help
 	  Enables GPIO support for the ACCES 104-DIO-48E series (104-DIO-48E,
@@ -549,7 +549,7 @@ config GPIO_104_DIO_48E
 
 config GPIO_104_IDIO_16
 	tristate "ACCES 104-IDIO-16 GPIO support"
-	depends on ISA_BUS_API
+	depends on PC104 && ISA_BUS_API
 	select GPIOLIB_IRQCHIP
 	help
 	  Enables GPIO support for the ACCES 104-IDIO-16 family (104-IDIO-16,
@@ -560,7 +560,7 @@ config GPIO_104_IDIO_16
 
 config GPIO_104_IDI_48
 	tristate "ACCES 104-IDI-48 GPIO support"
-	depends on ISA_BUS_API
+	depends on PC104 && ISA_BUS_API
 	select GPIOLIB_IRQCHIP
 	help
 	  Enables GPIO support for the ACCES 104-IDI-48 family (104-IDI-48A,
@@ -580,7 +580,7 @@ config GPIO_F7188X
 
 config GPIO_GPIO_MM
 	tristate "Diamond Systems GPIO-MM GPIO support"
-	depends on ISA_BUS_API
+	depends on PC104 && ISA_BUS_API
 	help
 	  Enables GPIO support for the Diamond Systems GPIO-MM and GPIO-MM-12.
 
-- 
2.11.0

Re: [PATCH 2/3] gpio: pc104: Mask PC/104 drivers via PC104 Kconfig option

[Linus Walleij]

On Tue, Jan 10, 2017 at 7:51 PM, William Breathitt Gray
<vilhelm.gray@gmail.com> wrote:

> PC/104 drivers should be hidden on machines which do not support PC/104
> devices. This patch adds the PC104 Kconfig option as a dependency for
> the relevant PC/104 device driver Kconfig options.
>
> Cc: Linus Walleij <linus.walleij@linaro.org>
> Cc: Alexandre Courbot <gnurou@gmail.com>
> Signed-off-by: William Breathitt Gray <vilhelm.gray@gmail.com>

Patch applied.

Yours,
Linus Walleij

[PATCH 3/3] iio: pc104: Mask PC/104 drivers via the PC104 Kconfig option

[William Breathitt Gray]

PC/104 drivers should be hidden on machines which do not support PC/104
devices. This patch adds the PC104 Kconfig option as a dependency for
the relevant PC/104 device driver Kconfig options.

Cc: Jonathan Cameron <jic23-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
Cc: Hartmut Knaack <knaack.h-Mmb7MZpHnFY@public.gmane.org>
Cc: Lars-Peter Clausen <lars-Qo5EllUWu/uELgA04lAiVw@public.gmane.org>
Cc: Peter Meerwald-Stadler <pmeerw-jW+XmwGofnusTnJN9+BGXg@public.gmane.org>
Signed-off-by: William Breathitt Gray <vilhelm.gray-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
---
 drivers/iio/adc/Kconfig     | 2 +-
 drivers/iio/counter/Kconfig | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/iio/adc/Kconfig b/drivers/iio/adc/Kconfig
index 9c8b558ba19e..dc897b443a17 100644
--- a/drivers/iio/adc/Kconfig
+++ b/drivers/iio/adc/Kconfig
@@ -465,7 +465,7 @@ config STM32_ADC
 
 config STX104
 	tristate "Apex Embedded Systems STX104 driver"
-	depends on X86 && ISA_BUS_API
+	depends on PC104 && X86 && ISA_BUS_API
 	select GPIOLIB
 	help
 	  Say yes here to build support for the Apex Embedded Systems STX104
diff --git a/drivers/iio/counter/Kconfig b/drivers/iio/counter/Kconfig
index 44627f6e4861..b37e5fc03149 100644
--- a/drivers/iio/counter/Kconfig
+++ b/drivers/iio/counter/Kconfig
@@ -7,7 +7,7 @@ menu "Counters"
 
 config 104_QUAD_8
 	tristate "ACCES 104-QUAD-8 driver"
-	depends on X86 && ISA_BUS_API
+	depends on PC104 && X86 && ISA_BUS_API
 	help
 	  Say yes here to build support for the ACCES 104-QUAD-8 quadrature
 	  encoder counter/interface device family (104-QUAD-8, 104-QUAD-4).
-- 
2.11.0

Re: [PATCH 3/3] iio: pc104: Mask PC/104 drivers via the PC104 Kconfig option

[Jonathan Cameron]

On 10/01/17 18:51, William Breathitt Gray wrote:
> PC/104 drivers should be hidden on machines which do not support PC/104
> devices. This patch adds the PC104 Kconfig option as a dependency for
> the relevant PC/104 device driver Kconfig options.
> 
> Cc: Jonathan Cameron <jic23@kernel.org>
> Cc: Hartmut Knaack <knaack.h@gmx.de>
> Cc: Lars-Peter Clausen <lars@metafoo.de>
> Cc: Peter Meerwald-Stadler <pmeerw@pmeerw.net>
> Signed-off-by: William Breathitt Gray <vilhelm.gray@gmail.com>
Acked-by: Jonathan Cameron <jic23@kernel.org>

Now the question is how to merge this one.  Let me know if you
want me to take this one via IIO after the first patch is in.
If you want to take it another route I'm fine with that.

Jonathan
> ---
>  drivers/iio/adc/Kconfig     | 2 +-
>  drivers/iio/counter/Kconfig | 2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/iio/adc/Kconfig b/drivers/iio/adc/Kconfig
> index 9c8b558ba19e..dc897b443a17 100644
> --- a/drivers/iio/adc/Kconfig
> +++ b/drivers/iio/adc/Kconfig
> @@ -465,7 +465,7 @@ config STM32_ADC
>  
>  config STX104
>  	tristate "Apex Embedded Systems STX104 driver"
> -	depends on X86 && ISA_BUS_API
> +	depends on PC104 && X86 && ISA_BUS_API
>  	select GPIOLIB
>  	help
>  	  Say yes here to build support for the Apex Embedded Systems STX104
> diff --git a/drivers/iio/counter/Kconfig b/drivers/iio/counter/Kconfig
> index 44627f6e4861..b37e5fc03149 100644
> --- a/drivers/iio/counter/Kconfig
> +++ b/drivers/iio/counter/Kconfig
> @@ -7,7 +7,7 @@ menu "Counters"
>  
>  config 104_QUAD_8
>  	tristate "ACCES 104-QUAD-8 driver"
> -	depends on X86 && ISA_BUS_API
> +	depends on PC104 && X86 && ISA_BUS_API
>  	help
>  	  Say yes here to build support for the ACCES 104-QUAD-8 quadrature
>  	  encoder counter/interface device family (104-QUAD-8, 104-QUAD-4).
> 

Re: [PATCH 3/3] iio: pc104: Mask PC/104 drivers via the PC104 Kconfig option

[William Breathitt Gray]

On Tue, Jan 10, 2017 at 09:13:02PM +0000, Jonathan Cameron wrote:
>On 10/01/17 18:51, William Breathitt Gray wrote:
>> PC/104 drivers should be hidden on machines which do not support PC/104
>> devices. This patch adds the PC104 Kconfig option as a dependency for
>> the relevant PC/104 device driver Kconfig options.
>> 
>> Cc: Jonathan Cameron <jic23-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
>> Cc: Hartmut Knaack <knaack.h-Mmb7MZpHnFY@public.gmane.org>
>> Cc: Lars-Peter Clausen <lars-Qo5EllUWu/uELgA04lAiVw@public.gmane.org>
>> Cc: Peter Meerwald-Stadler <pmeerw-jW+XmwGofnusTnJN9+BGXg@public.gmane.org>
>> Signed-off-by: William Breathitt Gray <vilhelm.gray-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
>Acked-by: Jonathan Cameron <jic23-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
>
>Now the question is how to merge this one.  Let me know if you
>want me to take this one via IIO after the first patch is in.
>If you want to take it another route I'm fine with that.
>
>Jonathan

This is such a simple patchset that I envision Greg K-H picking up all
three patches via driver-core; however, I'm pretty indifferent about the
ultimate path in the end. I'll leave it up to Greg K-H to decide.

William Breathitt Gray

Re: [PATCH 3/3] iio: pc104: Mask PC/104 drivers via the PC104 Kconfig option

[Linus Walleij]

On Tue, Jan 10, 2017 at 10:45 PM, William Breathitt Gray
<vilhelm.gray@gmail.com> wrote:
> On Tue, Jan 10, 2017 at 09:13:02PM +0000, Jonathan Cameron wrote:
>>On 10/01/17 18:51, William Breathitt Gray wrote:
>>> PC/104 drivers should be hidden on machines which do not support PC/104
>>> devices. This patch adds the PC104 Kconfig option as a dependency for
>>> the relevant PC/104 device driver Kconfig options.
>>>
>>> Cc: Jonathan Cameron <jic23@kernel.org>
>>> Cc: Hartmut Knaack <knaack.h@gmx.de>
>>> Cc: Lars-Peter Clausen <lars@metafoo.de>
>>> Cc: Peter Meerwald-Stadler <pmeerw@pmeerw.net>
>>> Signed-off-by: William Breathitt Gray <vilhelm.gray@gmail.com>
>>Acked-by: Jonathan Cameron <jic23@kernel.org>
>>
>>Now the question is how to merge this one.  Let me know if you
>>want me to take this one via IIO after the first patch is in.
>>If you want to take it another route I'm fine with that.
>>
>>Jonathan
>
> This is such a simple patchset that I envision Greg K-H picking up all
> three patches via driver-core; however, I'm pretty indifferent about the
> ultimate path in the end. I'll leave it up to Greg K-H to decide.

As long as Greg merges the first patch we can merge the two
others orthogonally I think.

It's just Kconfig symbols, not things that break compile.

(But I bet someone will come with automated warnings about
unused symbols in the kernel...)

Yours,
Linus Walleij

Re: [PATCH 3/3] iio: pc104: Mask PC/104 drivers via the PC104 Kconfig option

[Greg KH]

On Wed, Jan 11, 2017 at 04:45:26PM +0100, Linus Walleij wrote:
> On Tue, Jan 10, 2017 at 10:45 PM, William Breathitt Gray
> <vilhelm.gray@gmail.com> wrote:
> > On Tue, Jan 10, 2017 at 09:13:02PM +0000, Jonathan Cameron wrote:
> >>On 10/01/17 18:51, William Breathitt Gray wrote:
> >>> PC/104 drivers should be hidden on machines which do not support PC/104
> >>> devices. This patch adds the PC104 Kconfig option as a dependency for
> >>> the relevant PC/104 device driver Kconfig options.
> >>>
> >>> Cc: Jonathan Cameron <jic23@kernel.org>
> >>> Cc: Hartmut Knaack <knaack.h@gmx.de>
> >>> Cc: Lars-Peter Clausen <lars@metafoo.de>
> >>> Cc: Peter Meerwald-Stadler <pmeerw@pmeerw.net>
> >>> Signed-off-by: William Breathitt Gray <vilhelm.gray@gmail.com>
> >>Acked-by: Jonathan Cameron <jic23@kernel.org>
> >>
> >>Now the question is how to merge this one.  Let me know if you
> >>want me to take this one via IIO after the first patch is in.
> >>If you want to take it another route I'm fine with that.
> >>
> >>Jonathan
> >
> > This is such a simple patchset that I envision Greg K-H picking up all
> > three patches via driver-core; however, I'm pretty indifferent about the
> > ultimate path in the end. I'll leave it up to Greg K-H to decide.
> 
> As long as Greg merges the first patch we can merge the two
> others orthogonally I think.
> 
> It's just Kconfig symbols, not things that break compile.
> 
> (But I bet someone will come with automated warnings about
> unused symbols in the kernel...)

We already have that tool, scripts/checkkconfigsymbols.pl :)

I'll go merge this first patch now.

thanks,

greg k-h

Re: [PATCH 0/3] pc104: Mask PC/104 Kconfig options

[Linus Walleij]

On Tue, Jan 10, 2017 at 7:50 PM, William Breathitt Gray
<vilhelm.gray@gmail.com> wrote:

> PC/104 form factor devices serve a specific niche of embedded system
> users. Since PC/104 devices and hardware are typically used by just a
> subset of Linux users, it would be appropriate to filter PC/104 related
> Kconfig options for those uninterested.
>
> This patchset introduces the PC104 Kconfig option, and uses it to mask
> PC/104 specific device drivers and options, so that only those users
> interested in PC/104 related Kconfig options are exposed to them.

Tell me when/if the PC104 option is merged and I can merge the GPIO
patch.

Yours,
Linus Walleij

Re: [PATCH 0/3] pc104: Mask PC/104 Kconfig options

[William Breathitt Gray]

On Wed, Jan 11, 2017 at 04:26:19PM +0100, Linus Walleij wrote:
>On Tue, Jan 10, 2017 at 7:50 PM, William Breathitt Gray
><vilhelm.gray@gmail.com> wrote:
>
>> PC/104 form factor devices serve a specific niche of embedded system
>> users. Since PC/104 devices and hardware are typically used by just a
>> subset of Linux users, it would be appropriate to filter PC/104 related
>> Kconfig options for those uninterested.
>>
>> This patchset introduces the PC104 Kconfig option, and uses it to mask
>> PC/104 specific device drivers and options, so that only those users
>> interested in PC/104 related Kconfig options are exposed to them.
>
>Tell me when/if the PC104 option is merged and I can merge the GPIO
>patch.
>
>Yours,
>Linus Walleij

Jonathan and Linus,

Now that the PC104 option is merged for 4.11, it should be all right to
merge in the GPIO and IIO patches without worry of warnings. Please
merge the relevant patch to your respective tree after you pull in the
PC104 option.

Thank you,

William Breathitt Gray

Re: [PATCH 0/3] pc104: Mask PC/104 Kconfig options

[Jonathan Cameron]

On 01/03/17 20:46, William Breathitt Gray wrote:
> On Wed, Jan 11, 2017 at 04:26:19PM +0100, Linus Walleij wrote:
>> On Tue, Jan 10, 2017 at 7:50 PM, William Breathitt Gray
>> <vilhelm.gray@gmail.com> wrote:
>>
>>> PC/104 form factor devices serve a specific niche of embedded system
>>> users. Since PC/104 devices and hardware are typically used by just a
>>> subset of Linux users, it would be appropriate to filter PC/104 related
>>> Kconfig options for those uninterested.
>>>
>>> This patchset introduces the PC104 Kconfig option, and uses it to mask
>>> PC/104 specific device drivers and options, so that only those users
>>> interested in PC/104 related Kconfig options are exposed to them.
>>
>> Tell me when/if the PC104 option is merged and I can merge the GPIO
>> patch.
>>
>> Yours,
>> Linus Walleij
> 
> Jonathan and Linus,
> 
> Now that the PC104 option is merged for 4.11, it should be all right to
> merge in the GPIO and IIO patches without worry of warnings. Please
> merge the relevant patch to your respective tree after you pull in the
> PC104 option.
If it looks like I've forgotten this, feel free to poke me again!

At least replying to you should get it back into my recent threads
in my email client ;)

Jonathan
> 
> Thank you,
> 
> William Breathitt Gray
> --
> To unsubscribe from this list: send the line "unsubscribe linux-iio" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> 

Re: [PATCH 0/3] pc104: Mask PC/104 Kconfig options

[Jonathan Cameron]

On 05/03/17 12:48, Jonathan Cameron wrote:
> On 01/03/17 20:46, William Breathitt Gray wrote:
>> On Wed, Jan 11, 2017 at 04:26:19PM +0100, Linus Walleij wrote:
>>> On Tue, Jan 10, 2017 at 7:50 PM, William Breathitt Gray
>>> <vilhelm.gray-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> wrote:
>>>
>>>> PC/104 form factor devices serve a specific niche of embedded system
>>>> users. Since PC/104 devices and hardware are typically used by just a
>>>> subset of Linux users, it would be appropriate to filter PC/104 related
>>>> Kconfig options for those uninterested.
>>>>
>>>> This patchset introduces the PC104 Kconfig option, and uses it to mask
>>>> PC/104 specific device drivers and options, so that only those users
>>>> interested in PC/104 related Kconfig options are exposed to them.
>>>
>>> Tell me when/if the PC104 option is merged and I can merge the GPIO
>>> patch.
>>>
>>> Yours,
>>> Linus Walleij
>>
>> Jonathan and Linus,
>>
>> Now that the PC104 option is merged for 4.11, it should be all right to
>> merge in the GPIO and IIO patches without worry of warnings. Please
>> merge the relevant patch to your respective tree after you pull in the
>> PC104 option.
> If it looks like I've forgotten this, feel free to poke me again!
> 
> At least replying to you should get it back into my recent threads
> in my email client ;)
> 
Done,. Applied to the togreg branch of iio.git and pushed out as
testing for the autobuilders to play with it.

Thanks,

Jonathan
> Jonathan
>>
>> Thank you,
>>
>> William Breathitt Gray
>> --
>> To unsubscribe from this list: send the line "unsubscribe linux-iio" in
>> the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
>> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>>
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-iio" in
> the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>