From: Colin King <colin.king@canonical.com>
To: Linus Walleij <linus.walleij@linaro.org>,
Lokesh Vutla <lokeshvutla@ti.com>,
Tony Lindgren <tony@atomide.com>, Nishanth Menon <nm@ti.com>,
linux-gpio@vger.kernel.org
Cc: linux-kernel@vger.kernel.org
Subject: [PATCH] pinctrl: remove redundant pin < 0 check on unsigned int
Date: Fri, 13 Jan 2017 13:20:39 +0000 [thread overview]
Message-ID: <20170113132039.19830-1-colin.king@canonical.com> (raw)
From: Colin Ian King <colin.king@canonical.com>
pin is an unsigned int and therefore can never be < 0 so
this check is redudant. Remove the check and the associated
dev_err error message.
Fixes CoverityScan CID#1396438 ("Unsigned compared against 0")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
drivers/pinctrl/ti/pinctrl-ti-iodelay.c | 6 ------
1 file changed, 6 deletions(-)
diff --git a/drivers/pinctrl/ti/pinctrl-ti-iodelay.c b/drivers/pinctrl/ti/pinctrl-ti-iodelay.c
index 3b86d3d..a345166 100644
--- a/drivers/pinctrl/ti/pinctrl-ti-iodelay.c
+++ b/drivers/pinctrl/ti/pinctrl-ti-iodelay.c
@@ -665,12 +665,6 @@ static void ti_iodelay_pin_dbg_show(struct pinctrl_dev *pctldev,
r = iod->reg_data;
offset = ti_iodelay_pin_to_offset(iod, pin);
- if (pin < 0) {
- dev_err(iod->dev, "invalid pin offset for pin%i\n", pin);
-
- return;
- }
-
pd = &iod->pa[pin];
cfg = pd->drv_data;
--
2.10.2
next reply other threads:[~2017-01-13 13:20 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-13 13:20 Colin King [this message]
2017-01-13 20:41 ` [PATCH] pinctrl: remove redundant pin < 0 check on unsigned int Nishanth Menon
2017-01-18 9:24 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170113132039.19830-1-colin.king@canonical.com \
--to=colin.king@canonical.com \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lokeshvutla@ti.com \
--cc=nm@ti.com \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).