From: Mika Westerberg <mika.westerberg@linux.intel.com>
To: Johan Hovold <johan@kernel.org>
Cc: Linus Walleij <linus.walleij@linaro.org>,
Alexandre Courbot <gnurou@gmail.com>,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
Neil Armstrong <narmstrong@baylibre.com>,
linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 3/3] pinctrl / gpio: Introduce .set_config() callback for GPIO chips
Date: Tue, 24 Jan 2017 13:11:30 +0200 [thread overview]
Message-ID: <20170124111130.GE17297@lahna.fi.intel.com> (raw)
In-Reply-To: <20170123171107.GC32404@localhost>
On Mon, Jan 23, 2017 at 06:11:07PM +0100, Johan Hovold wrote:
> On Mon, Jan 23, 2017 at 03:34:34PM +0300, Mika Westerberg wrote:
> > Currently we already have two pin configuration related callbacks
> > available for GPIO chips .set_single_ended() and .set_debounce(). In
> > future we expect to have even more, which does not scale well if we need
> > to add yet another callback to the GPIO chip structure for each possible
> > configuration parameter.
> >
> > Better solution is to reuse what we already have available in the
> > generic pinconf.
> >
> > To support this, we introduce a new .set_config() callback for GPIO
> > chips. The callback takes a single packed pin configuration value as
> > parameter. This can then be extended easily beyond what is currently
> > supported by just adding new types to the generic pinconf enum.
> >
> > If the GPIO driver is backed up by a pinctrl driver the GPIO driver can
> > just assign gpiochip_generic_config() (introduced in this patch) to
> > .set_config and that will take care configuration requests are directed
> > to the pinctrl driver.
> >
> > We then convert the existing drivers over .set_config() and finally
> > remove the .set_single_ended() and .set_debounce() callbacks.
> >
> > Suggested-by: Linus Walleij <linus.walleij@linaro.org>
> > Signed-off-by: Mika Westerberg <mika.westerberg@linux.intel.com>
> > ---
> > Documentation/gpio/driver.txt | 9 +++--
> > drivers/gpio/gpio-bcm-kona.c | 14 ++++++-
> > drivers/gpio/gpio-dln2.c | 12 ++++--
> > drivers/gpio/gpio-dwapb.c | 14 ++++++-
> > drivers/gpio/gpio-ep93xx.c | 11 ++++--
> > drivers/gpio/gpio-f7188x.c | 19 +++++----
> > drivers/gpio/gpio-lp873x.c | 14 +++----
> > drivers/gpio/gpio-max77620.c | 20 +++++-----
> > drivers/gpio/gpio-menz127.c | 34 +++++++++++-----
> > drivers/gpio/gpio-merrifield.c | 14 ++++++-
> > drivers/gpio/gpio-omap.c | 14 ++++++-
> > drivers/gpio/gpio-tc3589x.c | 15 ++++---
> > drivers/gpio/gpio-tegra.c | 14 ++++++-
> > drivers/gpio/gpio-tps65218.c | 14 +++----
> > drivers/gpio/gpio-vx855.c | 13 ++++---
> > drivers/gpio/gpio-wcove.c | 13 +++----
> > drivers/gpio/gpio-wm831x.c | 21 +++++-----
> > drivers/gpio/gpio-wm8994.c | 13 +++----
> > drivers/gpio/gpiolib.c | 56 +++++++++++++++++----------
> > drivers/pinctrl/mediatek/pinctrl-mtk-common.c | 14 ++++++-
> > drivers/pinctrl/pinctrl-amd.c | 14 ++++++-
> > drivers/pinctrl/pinctrl-sx150x.c | 55 +++++++-------------------
> > drivers/staging/greybus/gpio.c | 15 ++++---
> > drivers/usb/serial/cp210x.c | 13 ++++---
>
> For greybus and USB serial:
>
> Acked-by: Johan Hovold <johan@kernel.org>
Thanks!
> Note however that this patch fails to apply to linux-next (conflicts in
> pinctrl as well as staging).
Indeed, it does. I did the series on top of v4.10-rc5 but looks like
there are some changes in linux-next that I missed.
I'll rebase the series on top of linux-next and resend.
next prev parent reply other threads:[~2017-01-24 11:11 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-23 12:34 [PATCH v2 0/3] pinctrl / gpio: Allow GPIO chips to use generic pinconfig Mika Westerberg
2017-01-23 12:34 ` [PATCH v2 1/3] pinctrl: Widen the generic pinconf argument from 16 to 24 bits Mika Westerberg
2017-01-23 12:34 ` [PATCH v2 2/3] pinctrl: Allow configuration of pins from gpiolib based drivers Mika Westerberg
2017-01-23 12:34 ` [PATCH v2 3/3] pinctrl / gpio: Introduce .set_config() callback for GPIO chips Mika Westerberg
2017-01-23 17:11 ` Johan Hovold
2017-01-24 11:11 ` Mika Westerberg [this message]
2017-01-24 12:53 ` Linus Walleij
2017-01-24 12:57 ` Mika Westerberg
2017-01-24 13:45 ` Johan Hovold
2017-01-24 14:22 ` Mika Westerberg
2017-01-25 10:09 ` Mika Westerberg
2017-01-26 14:29 ` Linus Walleij
2017-01-23 14:24 ` [PATCH v2 0/3] pinctrl / gpio: Allow GPIO chips to use generic pinconfig Andy Shevchenko
2017-01-26 14:25 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170124111130.GE17297@lahna.fi.intel.com \
--to=mika.westerberg@linux.intel.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=gnurou@gmail.com \
--cc=johan@kernel.org \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=narmstrong@baylibre.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).