Linux GPIO subsystem development
 help / color / mirror / Atom feed
From: Wolfram Sang <wsa@the-dreams.de>
To: Jacopo Mondi <jacopo+renesas@jmondi.org>
Cc: magnus.damm@gmail.com, laurent.pinchart@ideasonboard.com,
	geert+renesas@glider.be, chris.brandt@renesas.com,
	linus.walleij@linaro.org, linux-renesas-soc@vger.kernel.org,
	linux-gpio@vger.kernel.org
Subject: Re: [PATCH v3 1/8] pinctrl: sh-pfc: Add r7s72100 PFC driver
Date: Thu, 26 Jan 2017 18:14:31 +0100	[thread overview]
Message-ID: <20170126171431.inq5xf36ltllfrlr@ninjato> (raw)
In-Reply-To: <1484568772-18137-2-git-send-email-jacopo+renesas@jmondi.org>

[-- Attachment #1: Type: text/plain, Size: 1166 bytes --]


Just some very minor nits... Probably not worth the resend.

On Mon, Jan 16, 2017 at 01:12:45PM +0100, Jacopo Mondi wrote:
> From: Magnus Damm <damm@opensource.se>
> 
> Squash commits in Geert's renesas-driver/genmai-gpio-and-pfc branch that
> add support for r7s72100 PFC.
> This squash combines commits for Magnus' original driver, several
> "groups" definitions and minor fixes on top to forward-port it to a more
> recent kernel (v4.10)
> 
> Signed-off-by: Magnus Damm <damm@opensource.se>
> Signed-off-by: Wolfram Sang <wsa@sang-engineering.com>

I'd prefer the "wsa+renesas@..." address here, too.

> Signed-off-by: Simon Horman <horms+renesas@verge.net.au>
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
> Signed-off-by: Jacopo Mondi <jacopo+renesas@jmondi.org>

...

> diff --git a/drivers/pinctrl/sh-pfc/pfc-r7s72100.c b/drivers/pinctrl/sh-pfc/pfc-r7s72100.c
> new file mode 100644
> index 0000000..72e1dff
> --- /dev/null
> +++ b/drivers/pinctrl/sh-pfc/pfc-r7s72100.c
> @@ -0,0 +1,529 @@
> +/*
> + * R7S72100 processor support
> + *
> + * Copyright (C) 2013  Renesas Electronics Corporation

2013-2017?


[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

  reply	other threads:[~2017-01-26 17:14 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-01-16 12:12 [PATCH v3 0/8] Renesas RZ PFC and GPIO driver Jacopo Mondi
2017-01-16 12:12 ` [PATCH v3 1/8] pinctrl: sh-pfc: Add r7s72100 PFC driver Jacopo Mondi
2017-01-26 17:14   ` Wolfram Sang [this message]
2017-01-16 12:12 ` [PATCH v3 2/8] pinctrl: sh-pfc: r7s72100: Configure I/O mode Jacopo Mondi
2017-01-16 12:12 ` [PATCH v3 3/8] gpio: gpio-rz: GPIO driver for Renesas RZ series Jacopo Mondi
2017-01-18 13:58   ` Linus Walleij
2017-01-18 14:06     ` Geert Uytterhoeven
2017-01-19  9:27       ` Linus Walleij
2017-01-19  9:36         ` Geert Uytterhoeven
2017-01-19  9:38           ` Linus Walleij
2017-01-19  9:48             ` Geert Uytterhoeven
2017-01-18 15:40     ` jacopo mondi
2017-01-16 12:12 ` [PATCH v3 4/8] arm: dts: r7s72100: GPIO and PFC device nodes Jacopo Mondi
2017-01-16 12:12 ` [PATCH v3 5/8] arm: dts: r7s72100-genmai: SCIF2 PINCTRL configuration Jacopo Mondi
2017-01-16 12:12 ` [PATCH v3 6/8] arm: dts: r7s72100-genmai: LED1 and LED2 support Jacopo Mondi
2017-01-16 12:12 ` [PATCH v3 7/8] arm: dts: r7s72100-genmai:Add ethernet PFC node Jacopo Mondi
2017-01-16 12:12 ` [PATCH v3 8/8] arm: dts: r7s72100-genmai: Add pinctrl for RSPI Jacopo Mondi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170126171431.inq5xf36ltllfrlr@ninjato \
    --to=wsa@the-dreams.de \
    --cc=chris.brandt@renesas.com \
    --cc=geert+renesas@glider.be \
    --cc=jacopo+renesas@jmondi.org \
    --cc=laurent.pinchart@ideasonboard.com \
    --cc=linus.walleij@linaro.org \
    --cc=linux-gpio@vger.kernel.org \
    --cc=linux-renesas-soc@vger.kernel.org \
    --cc=magnus.damm@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox