* [PATCH v1] pinctrl: broxton: No need to take pointer of a pointer
@ 2017-01-26 15:10 Andy Shevchenko
2017-01-26 17:29 ` Mika Westerberg
2017-01-30 13:45 ` Linus Walleij
0 siblings, 2 replies; 3+ messages in thread
From: Andy Shevchenko @ 2017-01-26 15:10 UTC (permalink / raw)
To: Linus Walleij, Mika Westerberg, linux-gpio; +Cc: Andy Shevchenko
There is no need to take pointer of a pointer to an array of SoC data in
platform driver.
Do it in the same way as it's done for ACPI.
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
drivers/pinctrl/intel/pinctrl-broxton.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/pinctrl/intel/pinctrl-broxton.c b/drivers/pinctrl/intel/pinctrl-broxton.c
index 21bff8cca3ed..e6e6fd112585 100644
--- a/drivers/pinctrl/intel/pinctrl-broxton.c
+++ b/drivers/pinctrl/intel/pinctrl-broxton.c
@@ -1004,8 +1004,8 @@ static const struct acpi_device_id bxt_pinctrl_acpi_match[] = {
MODULE_DEVICE_TABLE(acpi, bxt_pinctrl_acpi_match);
static const struct platform_device_id bxt_pinctrl_platform_ids[] = {
- { "apollolake-pinctrl", (kernel_ulong_t)&apl_pinctrl_soc_data },
- { "broxton-pinctrl", (kernel_ulong_t)&bxt_pinctrl_soc_data },
+ { "apollolake-pinctrl", (kernel_ulong_t)apl_pinctrl_soc_data },
+ { "broxton-pinctrl", (kernel_ulong_t)bxt_pinctrl_soc_data },
{ },
};
--
2.11.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH v1] pinctrl: broxton: No need to take pointer of a pointer
2017-01-26 15:10 [PATCH v1] pinctrl: broxton: No need to take pointer of a pointer Andy Shevchenko
@ 2017-01-26 17:29 ` Mika Westerberg
2017-01-30 13:45 ` Linus Walleij
1 sibling, 0 replies; 3+ messages in thread
From: Mika Westerberg @ 2017-01-26 17:29 UTC (permalink / raw)
To: Andy Shevchenko; +Cc: Linus Walleij, linux-gpio
On Thu, Jan 26, 2017 at 05:10:38PM +0200, Andy Shevchenko wrote:
> There is no need to take pointer of a pointer to an array of SoC data in
> platform driver.
>
> Do it in the same way as it's done for ACPI.
>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Acked-by: Mika Westerberg <mika.westerberg@linux.intel.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH v1] pinctrl: broxton: No need to take pointer of a pointer
2017-01-26 15:10 [PATCH v1] pinctrl: broxton: No need to take pointer of a pointer Andy Shevchenko
2017-01-26 17:29 ` Mika Westerberg
@ 2017-01-30 13:45 ` Linus Walleij
1 sibling, 0 replies; 3+ messages in thread
From: Linus Walleij @ 2017-01-30 13:45 UTC (permalink / raw)
To: Andy Shevchenko; +Cc: Mika Westerberg, linux-gpio@vger.kernel.org
On Thu, Jan 26, 2017 at 4:10 PM, Andy Shevchenko
<andriy.shevchenko@linux.intel.com> wrote:
> There is no need to take pointer of a pointer to an array of SoC data in
> platform driver.
>
> Do it in the same way as it's done for ACPI.
>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Patch applied with Mika's ACK.
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-01-30 13:54 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-01-26 15:10 [PATCH v1] pinctrl: broxton: No need to take pointer of a pointer Andy Shevchenko
2017-01-26 17:29 ` Mika Westerberg
2017-01-30 13:45 ` Linus Walleij
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).