From: Krzysztof Kozlowski <krzk@kernel.org>
To: Marek Szyprowski <m.szyprowski@samsung.com>
Cc: linux-gpio@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-samsung-soc@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org,
Sylwester Nawrocki <s.nawrocki@samsung.com>,
Linus Walleij <linus.walleij@linaro.org>,
Tomasz Figa <tomasz.figa@gmail.com>,
Lee Jones <lee.jones@linaro.org>,
Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
Subject: Re: [PATCH v2 6/8] mfd: exynos-lpass: Add support for clocks
Date: Thu, 26 Jan 2017 22:09:53 +0200 [thread overview]
Message-ID: <20170126200953.sfyd64qk34th4suh@kozik-lap> (raw)
In-Reply-To: <1485419634-28331-7-git-send-email-m.szyprowski@samsung.com>
On Thu, Jan 26, 2017 at 09:33:52AM +0100, Marek Szyprowski wrote:
> Exynos LPASS requires some clocks to be enabled to make any access to its
> registers. This patch adds code for handling such clocks. For current set
> of registers it is enough to keep sfr0_ctrl clock enabled. Till now it
> worked only because those clocks were enabled by bootloader and driver
> probe() happened before they were disabled by clock core because of lack
> of users. Handling those clocks is also needed to make it possible to
> enable support for audio power domain.
>
> This patch requires adding sfr0_ctrl clock to device tree.
>
> Signed-off-by: Marek Szyprowski <m.szyprowski@samsung.com>
> ---
> .../devicetree/bindings/mfd/samsung,exynos5433-lpass.txt | 6 ++++++
> drivers/mfd/exynos-lpass.c | 10 ++++++++++
> 2 files changed, 16 insertions(+)
>
Thanks for changes. Looks good now.
Reviewed-by: Krzysztof Kozlowski <krzk@kernel.org>
Best regards,
Krzysztof
next prev parent reply other threads:[~2017-01-26 20:09 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20170126083401eucas1p20b4794fe46ccf2189bf734f0d8e3c536@eucas1p2.samsung.com>
2017-01-26 8:33 ` [PATCH v2 0/8] Pad retentions support for Exynos5433 Marek Szyprowski
[not found] ` <CGME20170126083401eucas1p24b0f04c62332e0b6e446ecca83145bc5@eucas1p2.samsung.com>
2017-01-26 8:33 ` [PATCH v2 1/8] soc: samsung: pmu: Add dummy support for Exynos5433 SoC Marek Szyprowski
2017-01-26 19:57 ` Krzysztof Kozlowski
[not found] ` <CGME20170126083401eucas1p289b69e3694b91e83983cd6e09aa7053c@eucas1p2.samsung.com>
2017-01-26 8:33 ` [PATCH v2 2/8] pinctrl: samsung: Ensure that pad retention is disabled on driver init Marek Szyprowski
[not found] ` <CGME20170126083402eucas1p187d3d31f62544fc46fae99fc5f74dbfe@eucas1p1.samsung.com>
2017-01-26 8:33 ` [PATCH v2 3/8] pinctrl: samsung: Add support for pad retention control for Exynos5433 SoCs Marek Szyprowski
2017-01-26 19:48 ` Krzysztof Kozlowski
2017-01-27 18:02 ` Krzysztof Kozlowski
2017-01-30 10:39 ` Marek Szyprowski
2017-01-26 19:57 ` Krzysztof Kozlowski
[not found] ` <CGME20170126083403eucas1p1ad75fe027047dc240b9afd651c7713a5@eucas1p1.samsung.com>
2017-01-26 8:33 ` [PATCH v2 4/8] arm64: dts: exynos: Add clocks to Exynos5433 LPASS module Marek Szyprowski
2017-01-26 20:08 ` Krzysztof Kozlowski
[not found] ` <CGME20170126083403eucas1p2328ed884334b453ffb1faac3c745cec3@eucas1p2.samsung.com>
2017-01-26 8:33 ` [PATCH v2 5/8] mfd: exynos-lpass: Remove pad retention control Marek Szyprowski
2017-01-26 9:36 ` Sylwester Nawrocki
2017-02-01 13:24 ` Rob Herring
2017-02-08 10:56 ` Lee Jones
[not found] ` <CGME20170126083404eucas1p132ce7a0792505367f6a001f21e9d1632@eucas1p1.samsung.com>
2017-01-26 8:33 ` [PATCH v2 6/8] mfd: exynos-lpass: Add support for clocks Marek Szyprowski
2017-01-26 20:09 ` Krzysztof Kozlowski [this message]
2017-02-01 13:24 ` Rob Herring
2017-02-08 10:57 ` Lee Jones
[not found] ` <CGME20170126083405eucas1p29a888fa3896e2bd131e23585f7d033d9@eucas1p2.samsung.com>
[not found] ` <1485419634-28331-1-git-send-email-m.szyprowski-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
2017-01-26 8:33 ` [PATCH v2 7/8] mfd: exynos-lpass: Add missing remove() function Marek Szyprowski
[not found] ` <1485419634-28331-8-git-send-email-m.szyprowski-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
2017-01-26 20:11 ` Krzysztof Kozlowski
2017-02-08 10:57 ` Lee Jones
[not found] ` <CGME20170126083406eucas1p20148fa4f3ca70d333400c806dd490aef@eucas1p2.samsung.com>
2017-01-26 8:33 ` [PATCH v2 8/8] mfd: exynos-lpass: Add runtime PM support Marek Szyprowski
[not found] ` <1485419634-28331-9-git-send-email-m.szyprowski-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
2017-02-08 10:58 ` Lee Jones
2017-01-26 9:50 ` [PATCH v2 0/8] Pad retentions support for Exynos5433 Linus Walleij
2017-01-26 10:37 ` Marek Szyprowski
[not found] ` <CACRpkdawiAp3xqVd7J5ZAd2dQ=X09DGybyw0EVp=07w8-ccKfA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2017-01-26 14:32 ` Krzysztof Kozlowski
2017-01-26 15:47 ` Linus Walleij
2017-01-27 19:46 ` Krzysztof Kozlowski
2017-01-30 9:57 ` Marek Szyprowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170126200953.sfyd64qk34th4suh@kozik-lap \
--to=krzk@kernel.org \
--cc=b.zolnierkie@samsung.com \
--cc=devicetree@vger.kernel.org \
--cc=lee.jones@linaro.org \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=m.szyprowski@samsung.com \
--cc=s.nawrocki@samsung.com \
--cc=tomasz.figa@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).