From: Jean Delvare <jdelvare@suse.de>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: Linus Walleij <linus.walleij@linaro.org>,
Mika Westerberg <mika.westerberg@linux.intel.com>,
linux-gpio@vger.kernel.org,
Cristina Ciocan <cristina.ciocan@intel.com>
Subject: Re: [PATCH v1 2/3] pinctrl: baytrail: Debounce register is one per community
Date: Fri, 27 Jan 2017 15:06:06 +0100 [thread overview]
Message-ID: <20170127150606.0dcc6c6a@endymion> (raw)
In-Reply-To: <1485523639.2133.355.camel@linux.intel.com>
On Fri, 27 Jan 2017 15:27:19 +0200, Andy Shevchenko wrote:
> On Fri, 2017-01-27 at 10:21 +0100, Jean Delvare wrote:
> > That break isn't needed ;-)
>
> Would be better to have in my opinion. I already did myself some
> mistakes regarding to missed break.
OK, fine with me.
> > The code looks sane to me, although I can't verify its correctness
> > without a datasheet.
>
> Datasheet is public.
>
> Intel® Atom™ Processor Z3600 and Z3700 Series Datasheet (Volume 2 of 2)
> Number: 329518-002
Apparently it was removed in December 2014 and replaced by a more
concise document...
https://communities.intel.com/thread/57313
But no big deal, I trust your fix is correct.
--
Jean Delvare
SUSE L3 Support
next prev parent reply other threads:[~2017-01-27 14:07 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-26 17:24 [PATCH v1 0/3] pinctrl: baytrail: Fix debounce feature Andy Shevchenko
2017-01-26 17:24 ` [PATCH v1 1/3] pinctrl: baytrail: Rectify debounce support (part 2) Andy Shevchenko
2017-01-27 9:14 ` Jean Delvare
2017-01-27 13:28 ` Andy Shevchenko
2017-01-27 9:34 ` Mika Westerberg
2017-01-30 14:47 ` Linus Walleij
2017-01-26 17:24 ` [PATCH v1 2/3] pinctrl: baytrail: Debounce register is one per community Andy Shevchenko
2017-01-27 9:21 ` Jean Delvare
2017-01-27 13:27 ` Andy Shevchenko
2017-01-27 14:06 ` Jean Delvare [this message]
2017-01-27 9:35 ` Mika Westerberg
2017-01-30 14:49 ` Linus Walleij
2017-01-26 17:24 ` [PATCH v1 3/3] pinctrl: baytrail: Add debounce to debug output Andy Shevchenko
2017-01-27 9:40 ` Mika Westerberg
2017-01-27 10:07 ` Jean Delvare
2017-01-30 14:51 ` Linus Walleij
2017-01-30 15:13 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170127150606.0dcc6c6a@endymion \
--to=jdelvare@suse.de \
--cc=andriy.shevchenko@linux.intel.com \
--cc=cristina.ciocan@intel.com \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=mika.westerberg@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).