Re: [PATCH v3 03/10] clk: sunxi-ng: rename sun8i-h3 driver to sunxi-h3-h5

Maxime Ripard
2017-01-30T09:03:07Z

[-- Attachment #1: Type: text/plain, Size: 1898 bytes --]

Hi,

On Sun, Jan 29, 2017 at 10:33:24AM +0800, Icenowy Zheng wrote:
> As the CCU in the Allwinner H5 SoC is very similar to the one in H3,
> rename the H3 driver to sunxi-h3-h5 so that it can be extended with H5
> support.
>
> Signed-off-by: Icenowy Zheng <icenowy-ymACFijhrKM@public.gmane.org>
> ---
> The original PATCH v2 3/9 is splited into two patches in v3, this one renames
> the H3 driver to h3-h5, and the next one finally add H5 support to it.
>
> drivers/clk/sunxi-ng/Kconfig | 4 +-
> drivers/clk/sunxi-ng/Makefile | 2 +-
> .../sunxi-ng/{ccu-sun8i-h3.c => ccu-sunxi-h3-h5.c} | 42 +++---
> .../sunxi-ng/{ccu-sun8i-h3.h => ccu-sunxi-h3-h5.h} | 10 +-
> include/dt-bindings/clock/sun8i-h3-ccu.h | 146 +--------------------
> include/dt-bindings/clock/sunxi-h3-h5-ccu.h | 145 ++++++++++++++++++++
> include/dt-bindings/reset/sun8i-h3-ccu.h | 104 +--------------
> include/dt-bindings/reset/sunxi-h3-h5-ccu.h | 103 +++++++++++++++
> 8 files changed, 282 insertions(+), 274 deletions(-)
> rename drivers/clk/sunxi-ng/{ccu-sun8i-h3.c => ccu-sunxi-h3-h5.c} (96%)
> rename drivers/clk/sunxi-ng/{ccu-sun8i-h3.h => ccu-sunxi-h3-h5.h} (88%)
> mode change 100644 => 120000 include/dt-bindings/clock/sun8i-h3-ccu.h
> create mode 100644 include/dt-bindings/clock/sunxi-h3-h5-ccu.h
> mode change 100644 => 120000 include/dt-bindings/reset/sun8i-h3-ccu.h
> create mode 100644 include/dt-bindings/reset/sunxi-h3-h5-ccu.h

Please generate your patches with -M

> -static void __init sun8i_h3_ccu_setup(struct device_node *node)
> +static void __init sunxi_h3_h5_ccu_init(struct device_node *node,
> + const struct sunxi_ccu_desc *desc)
> {

The indentation should be on the opening parenthesis.

Maxime

--
Maxime Ripard, Free Electrons
Embedded Linux and Kernel engineering