From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mika Westerberg Subject: Re: PROBLEM: Baytrail tablet touchscreen fails after pinctrl commit [3ae02c14d964499da76b5ef4d8912710902e64f8] Date: Tue, 31 Jan 2017 12:21:13 +0200 Message-ID: <20170131102113.GR17297@lahna.fi.intel.com> References: <6306d18a-d5d3-3e89-5f41-2a45d3de1398@uwyo.edu> <1483812841.26691.7.camel@linux.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from mga04.intel.com ([192.55.52.120]:32931 "EHLO mga04.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751349AbdAaKYm (ORCPT ); Tue, 31 Jan 2017 05:24:42 -0500 Content-Disposition: inline In-Reply-To: Sender: linux-gpio-owner@vger.kernel.org List-Id: linux-gpio@vger.kernel.org To: Dmitry Torokhov Cc: Andy Shevchenko , "Robert R. Howell" , Heikki Krogerus , "linux-gpio@vger.kernel.org" , Jiri Kosina , Benjamin Tissoires , "linux-input@vger.kernel.org" , Linus Walleij On Mon, Jan 30, 2017 at 04:52:27PM -0800, Dmitry Torokhov wrote: > On Sat, Jan 7, 2017 at 10:14 AM, Andy Shevchenko > wrote: > > On Fri, 2017-01-06 at 02:30 -0700, Robert R. Howell wrote: > >> [1.] Baytrail tablet touchscreen fails after pinctrl commit > >> [3ae02c14d964499da76b5ef4d8912710902e64f8] > >> > >> [2.] Beginning with kernel 4.10-rc1 (and continuing with 4.10-rc2) > >> the > >> touchscreen on two Baytrail devices, an ASUS T100TA and a Toshiba > >> Encore > >> 8, no longer works. They did work properly up though at least 4.9.0. > >> As > >> indicated in the DMESG output appended below, the ATML1000 > >> touchscreen > >> controller fails to reset and initialize properly on boot. The reset > >> command issued through i2c_hid appears to time out after its 5 second > >> wait for completion. (There are similar problems with an i2c > >> orientation sensor.) Using git bisect I've found that the problem > >> begins with commit [3ae02c14d964499da76b5ef4d8912710902e64f8] > >> pinctrl: intel: set default handler to be handle_bad_irq() > >> > >> I've appended the git bisect log output at the end. Reverting that > >> single commit (tested with 4.10-rc2) fixes the problem. > > > > Thanks for the report. For me it looks like that commit actually > > discovers other problems we have in the code somewhere. > > > > Yeah, I confirm the issue on T100TA. I will investigate this next week. > > This still happens on chromeOS Baytrail devices with -rc6 here as > well. Can we revert this and try again in 4.11 timeframe? Are you sure you have commit 49c030962638 ("pinctrl: baytrail: Do not add all GPIOs to IRQ domain")? That is supposed to fix the issue if I understand correctly.