* [PATCH] gpio: mcp23s08: Select REGMAP/REGMAP_I2C to fix build error
@ 2017-02-02 10:13 Axel Lin
2017-02-02 13:56 ` Sebastian Reichel
2017-02-04 20:25 ` Linus Walleij
0 siblings, 2 replies; 3+ messages in thread
From: Axel Lin @ 2017-02-02 10:13 UTC (permalink / raw)
To: Linus Walleij; +Cc: Sebastian Reichel, Alexandre Courbot, linux-gpio, Axel Lin
This driver now using devm_regmap_init/devm_regmap_init_i2c, so it needs
to select REGMAP/REGMAP_I2C accordingly.
Fixes: ("3d84fdb3f0b5 gpio: mcp23s08: use regmap")
Signed-off-by: Axel Lin <axel.lin@ingics.com>
---
drivers/gpio/Kconfig | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/gpio/Kconfig b/drivers/gpio/Kconfig
index 2d77392..28e6219 100644
--- a/drivers/gpio/Kconfig
+++ b/drivers/gpio/Kconfig
@@ -1213,6 +1213,8 @@ config GPIO_MCP23S08
tristate "Microchip MCP23xxx I/O expander"
depends on OF_GPIO
select GPIOLIB_IRQCHIP
+ select REGMAP_I2C if I2C
+ select REGMAP if SPI_MASTER
help
SPI/I2C driver for Microchip MCP23S08/MCP23S17/MCP23008/MCP23017
I/O expanders.
--
2.9.3
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] gpio: mcp23s08: Select REGMAP/REGMAP_I2C to fix build error
2017-02-02 10:13 [PATCH] gpio: mcp23s08: Select REGMAP/REGMAP_I2C to fix build error Axel Lin
@ 2017-02-02 13:56 ` Sebastian Reichel
2017-02-04 20:25 ` Linus Walleij
1 sibling, 0 replies; 3+ messages in thread
From: Sebastian Reichel @ 2017-02-02 13:56 UTC (permalink / raw)
To: Axel Lin; +Cc: Linus Walleij, Alexandre Courbot, linux-gpio
[-- Attachment #1: Type: text/plain, Size: 902 bytes --]
Hi,
On Thu, Feb 02, 2017 at 06:13:06PM +0800, Axel Lin wrote:
> This driver now using devm_regmap_init/devm_regmap_init_i2c, so it needs
> to select REGMAP/REGMAP_I2C accordingly.
>
> Fixes: ("3d84fdb3f0b5 gpio: mcp23s08: use regmap")
> Signed-off-by: Axel Lin <axel.lin@ingics.com>
> ---
> drivers/gpio/Kconfig | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/gpio/Kconfig b/drivers/gpio/Kconfig
> index 2d77392..28e6219 100644
> --- a/drivers/gpio/Kconfig
> +++ b/drivers/gpio/Kconfig
> @@ -1213,6 +1213,8 @@ config GPIO_MCP23S08
> tristate "Microchip MCP23xxx I/O expander"
> depends on OF_GPIO
> select GPIOLIB_IRQCHIP
> + select REGMAP_I2C if I2C
> + select REGMAP if SPI_MASTER
> help
> SPI/I2C driver for Microchip MCP23S08/MCP23S17/MCP23008/MCP23017
> I/O expanders.
Acked-By: Sebastian Reichel <sre@kernel.org>
-- Sebastian
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] gpio: mcp23s08: Select REGMAP/REGMAP_I2C to fix build error
2017-02-02 10:13 [PATCH] gpio: mcp23s08: Select REGMAP/REGMAP_I2C to fix build error Axel Lin
2017-02-02 13:56 ` Sebastian Reichel
@ 2017-02-04 20:25 ` Linus Walleij
1 sibling, 0 replies; 3+ messages in thread
From: Linus Walleij @ 2017-02-04 20:25 UTC (permalink / raw)
To: Axel Lin; +Cc: Sebastian Reichel, Alexandre Courbot, linux-gpio@vger.kernel.org
On Thu, Feb 2, 2017 at 11:13 AM, Axel Lin <axel.lin@ingics.com> wrote:
> This driver now using devm_regmap_init/devm_regmap_init_i2c, so it needs
> to select REGMAP/REGMAP_I2C accordingly.
>
> Fixes: ("3d84fdb3f0b5 gpio: mcp23s08: use regmap")
> Signed-off-by: Axel Lin <axel.lin@ingics.com>
Patch applied with Sebastian's ACK.
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-02-04 20:25 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-02-02 10:13 [PATCH] gpio: mcp23s08: Select REGMAP/REGMAP_I2C to fix build error Axel Lin
2017-02-02 13:56 ` Sebastian Reichel
2017-02-04 20:25 ` Linus Walleij
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).