From: Sebastian Reichel <sre@kernel.org>
To: Axel Lin <axel.lin@ingics.com>
Cc: Linus Walleij <linus.walleij@linaro.org>,
Alexandre Courbot <gnurou@gmail.com>,
linux-gpio@vger.kernel.org
Subject: Re: [PATCH] gpio: mcp23s08: Select REGMAP/REGMAP_I2C to fix build error
Date: Thu, 2 Feb 2017 14:56:35 +0100 [thread overview]
Message-ID: <20170202135634.p7lebviiadcfagvy@earth> (raw)
In-Reply-To: <20170202101306.24976-1-axel.lin@ingics.com>
[-- Attachment #1: Type: text/plain, Size: 902 bytes --]
Hi,
On Thu, Feb 02, 2017 at 06:13:06PM +0800, Axel Lin wrote:
> This driver now using devm_regmap_init/devm_regmap_init_i2c, so it needs
> to select REGMAP/REGMAP_I2C accordingly.
>
> Fixes: ("3d84fdb3f0b5 gpio: mcp23s08: use regmap")
> Signed-off-by: Axel Lin <axel.lin@ingics.com>
> ---
> drivers/gpio/Kconfig | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/gpio/Kconfig b/drivers/gpio/Kconfig
> index 2d77392..28e6219 100644
> --- a/drivers/gpio/Kconfig
> +++ b/drivers/gpio/Kconfig
> @@ -1213,6 +1213,8 @@ config GPIO_MCP23S08
> tristate "Microchip MCP23xxx I/O expander"
> depends on OF_GPIO
> select GPIOLIB_IRQCHIP
> + select REGMAP_I2C if I2C
> + select REGMAP if SPI_MASTER
> help
> SPI/I2C driver for Microchip MCP23S08/MCP23S17/MCP23008/MCP23017
> I/O expanders.
Acked-By: Sebastian Reichel <sre@kernel.org>
-- Sebastian
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2017-02-02 13:56 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-02 10:13 [PATCH] gpio: mcp23s08: Select REGMAP/REGMAP_I2C to fix build error Axel Lin
2017-02-02 13:56 ` Sebastian Reichel [this message]
2017-02-04 20:25 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170202135634.p7lebviiadcfagvy@earth \
--to=sre@kernel.org \
--cc=axel.lin@ingics.com \
--cc=gnurou@gmail.com \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox