From: Jamie Iles <jamie@jamieiles.com>
To: Hoan Tran <hotran@apm.com>
Cc: Jamie Iles <jamie@jamieiles.com>,
Linus Walleij <linus.walleij@linaro.org>,
Andy Shevchenko <andy.shevchenko@gmail.com>,
Weike Chen <alvin.chen@intel.com>,
Alexandre Courbot <gnurou@gmail.com>,
Sebastian Andrzej Siewior <bigeasy@linutronix.de>,
"linux-gpio@vger.kernel.org" <linux-gpio@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Loc Ho <lho@apm.com>, Duc Dang <dhdang@apm.com>
Subject: Re: [PATCH] gpio: dwapb: Add support for next generation of X-Gene SoC
Date: Wed, 15 Feb 2017 11:20:01 +0000 [thread overview]
Message-ID: <20170215112001.GA30801@page> (raw)
In-Reply-To: <CAFHUOYxxygE4ouZySwvLr3=xBPSATk0XqpMDVL=EZcciV7FNRA@mail.gmail.com>
Hi Hoan,
On Tue, Feb 14, 2017 at 05:22:09PM -0800, Hoan Tran wrote:
> Hi Linus, Jamie and all,
>
> Do you have any comments on this patch?
I think that the CONFIG_ACPI ifdef can be removed to clean it up -
acpi_match_device() returns NULL for !CONFIG_ACPI.
Other than that, looks good to me.
Jamie
prev parent reply other threads:[~2017-02-15 11:20 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-31 19:43 [PATCH] gpio: dwapb: Add support for next generation of X-Gene SoC Hoan Tran
2017-02-02 19:47 ` Andy Shevchenko
2017-02-03 1:18 ` Hoan Tran
2017-02-06 10:21 ` Linus Walleij
2017-02-06 23:49 ` Hoan Tran
2017-02-07 9:18 ` Andy Shevchenko
2017-02-13 9:38 ` Jamie Iles
2017-02-15 1:22 ` Hoan Tran
2017-02-15 11:20 ` Jamie Iles [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170215112001.GA30801@page \
--to=jamie@jamieiles.com \
--cc=alvin.chen@intel.com \
--cc=andy.shevchenko@gmail.com \
--cc=bigeasy@linutronix.de \
--cc=dhdang@apm.com \
--cc=gnurou@gmail.com \
--cc=hotran@apm.com \
--cc=lho@apm.com \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).