From: Krzysztof Kozlowski <krzk@kernel.org>
To: Charles Keepax <ckeepax@opensource.wolfsonmicro.com>
Cc: linus.walleij@linaro.org, tomasz.figa@gmail.com,
s.nawrocki@samsung.com, linux-gpio@vger.kernel.org,
linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org,
patches@opensource.wolfsonmicro.com
Subject: Re: [PATCH 4/4] pinctrl: samsung: Remove unused local variable
Date: Wed, 15 Feb 2017 19:43:03 +0200 [thread overview]
Message-ID: <20170215174303.2547hgentg6pldgo@kozik-lap> (raw)
In-Reply-To: <1486980666-7143-4-git-send-email-ckeepax@opensource.wolfsonmicro.com>
On Mon, Feb 13, 2017 at 10:11:06AM +0000, Charles Keepax wrote:
> Signed-off-by: Charles Keepax <ckeepax@opensource.wolfsonmicro.com>
"The local variable drvdata is not used in samsung_gpio_set_direction()"?
Reviewed-by: Krzysztof Kozlowski <krzk@kernel.org>
Best regards,
Krzysztof
> ---
> drivers/pinctrl/samsung/pinctrl-samsung.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/pinctrl/samsung/pinctrl-samsung.c b/drivers/pinctrl/samsung/pinctrl-samsung.c
> index f291cbf..eb08f30 100644
> --- a/drivers/pinctrl/samsung/pinctrl-samsung.c
> +++ b/drivers/pinctrl/samsung/pinctrl-samsung.c
> @@ -566,13 +566,11 @@ static int samsung_gpio_set_direction(struct gpio_chip *gc,
> {
> const struct samsung_pin_bank_type *type;
> struct samsung_pin_bank *bank;
> - struct samsung_pinctrl_drv_data *drvdata;
> void __iomem *reg;
> u32 data, mask, shift;
>
> bank = gpiochip_get_data(gc);
> type = bank->type;
> - drvdata = bank->drvdata;
>
> reg = bank->pctl_base + bank->pctl_offset
> + type->reg_offset[PINCFG_TYPE_FUNC];
> --
> 2.1.4
>
next prev parent reply other threads:[~2017-02-15 17:43 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-13 10:11 [PATCH 1/4] pinctrl: Fix trivial spelling typo in a comment Charles Keepax
2017-02-13 10:11 ` [PATCH 2/4] pinctrl: samsung: Register pinctrl before GPIO Charles Keepax
2017-02-15 17:36 ` Krzysztof Kozlowski
2017-02-13 10:11 ` [PATCH 3/4] pinctrl: samsung: Use devres version of gpiochip_add_data Charles Keepax
2017-02-15 17:39 ` Krzysztof Kozlowski
2017-02-13 10:11 ` [PATCH 4/4] pinctrl: samsung: Remove unused local variable Charles Keepax
2017-02-15 17:43 ` Krzysztof Kozlowski [this message]
2017-02-16 10:39 ` Charles Keepax
2017-02-22 14:32 ` [PATCH 1/4] pinctrl: Fix trivial spelling typo in a comment Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170215174303.2547hgentg6pldgo@kozik-lap \
--to=krzk@kernel.org \
--cc=ckeepax@opensource.wolfsonmicro.com \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=patches@opensource.wolfsonmicro.com \
--cc=s.nawrocki@samsung.com \
--cc=tomasz.figa@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox