linux-gpio.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Charles Keepax <ckeepax@opensource.wolfsonmicro.com>
To: Krzysztof Kozlowski <krzk@kernel.org>
Cc: linus.walleij@linaro.org, tomasz.figa@gmail.com,
	s.nawrocki@samsung.com, linux-gpio@vger.kernel.org,
	linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org,
	patches@opensource.wolfsonmicro.com
Subject: Re: [PATCH 4/4] pinctrl: samsung: Remove unused local variable
Date: Thu, 16 Feb 2017 10:39:01 +0000	[thread overview]
Message-ID: <20170216103901.GD30007@localhost.localdomain> (raw)
In-Reply-To: <20170215174303.2547hgentg6pldgo@kozik-lap>

On Wed, Feb 15, 2017 at 07:43:03PM +0200, Krzysztof Kozlowski wrote:
> On Mon, Feb 13, 2017 at 10:11:06AM +0000, Charles Keepax wrote:
> > Signed-off-by: Charles Keepax <ckeepax@opensource.wolfsonmicro.com>
> 
> "The local variable drvdata is not used in samsung_gpio_set_direction()"?
> 
> Reviewed-by: Krzysztof Kozlowski <krzk@kernel.org>
> 

Thanks, will update the commit messages with your
recommendations and resend.

Thanks,
Charles

  reply	other threads:[~2017-02-16 10:38 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-02-13 10:11 [PATCH 1/4] pinctrl: Fix trivial spelling typo in a comment Charles Keepax
2017-02-13 10:11 ` [PATCH 2/4] pinctrl: samsung: Register pinctrl before GPIO Charles Keepax
2017-02-15 17:36   ` Krzysztof Kozlowski
2017-02-13 10:11 ` [PATCH 3/4] pinctrl: samsung: Use devres version of gpiochip_add_data Charles Keepax
2017-02-15 17:39   ` Krzysztof Kozlowski
2017-02-13 10:11 ` [PATCH 4/4] pinctrl: samsung: Remove unused local variable Charles Keepax
2017-02-15 17:43   ` Krzysztof Kozlowski
2017-02-16 10:39     ` Charles Keepax [this message]
2017-02-22 14:32 ` [PATCH 1/4] pinctrl: Fix trivial spelling typo in a comment Linus Walleij

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170216103901.GD30007@localhost.localdomain \
    --to=ckeepax@opensource.wolfsonmicro.com \
    --cc=krzk@kernel.org \
    --cc=linus.walleij@linaro.org \
    --cc=linux-gpio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-samsung-soc@vger.kernel.org \
    --cc=patches@opensource.wolfsonmicro.com \
    --cc=s.nawrocki@samsung.com \
    --cc=tomasz.figa@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).