From: Ralph Sennhauser <ralph.sennhauser@gmail.com>
To: linux-gpio@vger.kernel.org
Cc: Ralph Sennhauser <ralph.sennhauser@gmail.com>,
Linus Walleij <linus.walleij@linaro.org>,
Alexandre Courbot <gnurou@gmail.com>,
open list <linux-kernel@vger.kernel.org>
Subject: [PATCH 1/6] gpio: mvebu: checkpatch: block comment fixes
Date: Thu, 16 Mar 2017 07:33:56 +0100 [thread overview]
Message-ID: <20170316063402.8667-2-ralph.sennhauser@gmail.com> (raw)
In-Reply-To: <20170316063402.8667-1-ralph.sennhauser@gmail.com>
Fix issues in block comments reported by checkpatch.
Signed-off-by: Ralph Sennhauser <ralph.sennhauser@gmail.com>
---
drivers/gpio/gpio-mvebu.c | 24 ++++++++++++++++--------
1 file changed, 16 insertions(+), 8 deletions(-)
diff --git a/drivers/gpio/gpio-mvebu.c b/drivers/gpio/gpio-mvebu.c
index a649556..a2351f3 100644
--- a/drivers/gpio/gpio-mvebu.c
+++ b/drivers/gpio/gpio-mvebu.c
@@ -62,9 +62,11 @@
#define GPIO_EDGE_MASK_MV78200_OFF(cpu) ((cpu) ? 0x30 : 0x18)
#define GPIO_LEVEL_MASK_MV78200_OFF(cpu) ((cpu) ? 0x34 : 0x1C)
-/* The Armada XP has per-CPU registers for interrupt cause, interrupt
+/*
+ * The Armada XP has per-CPU registers for interrupt cause, interrupt
* mask and interrupt level mask. Those are relative to the
- * percpu_membase. */
+ * percpu_membase.
+ */
#define GPIO_EDGE_CAUSE_ARMADAXP_OFF(cpu) ((cpu) * 0x4)
#define GPIO_EDGE_MASK_ARMADAXP_OFF(cpu) (0x10 + (cpu) * 0x4)
#define GPIO_LEVEL_MASK_ARMADAXP_OFF(cpu) (0x20 + (cpu) * 0x4)
@@ -239,8 +241,10 @@ static int mvebu_gpio_direction_input(struct gpio_chip *chip, unsigned pin)
int ret;
u32 u;
- /* Check with the pinctrl driver whether this pin is usable as
- * an input GPIO */
+ /*
+ * Check with the pinctrl driver whether this pin is usable as
+ * an input GPIO
+ */
ret = pinctrl_gpio_direction_input(chip->base + pin);
if (ret)
return ret;
@@ -262,8 +266,10 @@ static int mvebu_gpio_direction_output(struct gpio_chip *chip, unsigned pin,
int ret;
u32 u;
- /* Check with the pinctrl driver whether this pin is usable as
- * an output GPIO */
+ /*
+ * Check with the pinctrl driver whether this pin is usable as
+ * an output GPIO
+ */
ret = pinctrl_gpio_direction_output(chip->base + pin);
if (ret)
return ret;
@@ -712,8 +718,10 @@ static int mvebu_gpio_probe(struct platform_device *pdev)
if (IS_ERR(mvchip->membase))
return PTR_ERR(mvchip->membase);
- /* The Armada XP has a second range of registers for the
- * per-CPU registers */
+ /*
+ * The Armada XP has a second range of registers for the
+ * per-CPU registers
+ */
if (soc_variant == MVEBU_GPIO_SOC_VARIANT_ARMADAXP) {
res = platform_get_resource(pdev, IORESOURCE_MEM, 1);
mvchip->percpu_membase = devm_ioremap_resource(&pdev->dev,
--
2.10.2
next prev parent reply other threads:[~2017-03-16 6:33 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-16 6:33 [PATCH 0/6] gpio: mvebu: prepatatory cleanup for pwm-fan support Ralph Sennhauser
2017-03-16 6:33 ` Ralph Sennhauser [this message]
2017-03-16 15:40 ` [PATCH 1/6] gpio: mvebu: checkpatch: block comment fixes Linus Walleij
2017-03-16 6:33 ` [PATCH 2/6] gpio: mvebu: start multiline block comments with blank line Ralph Sennhauser
2017-03-16 15:41 ` Linus Walleij
2017-03-16 6:33 ` [PATCH 3/6] gpio: mvebu: checkpatch: unsigned int fixes Ralph Sennhauser
2017-03-16 15:42 ` Linus Walleij
2017-03-16 6:33 ` [PATCH 4/6] gpio: mvebu: checkpatch: whitespace fixes Ralph Sennhauser
2017-03-16 15:42 ` Linus Walleij
2017-03-16 6:34 ` [PATCH 5/6] gpio: mvebu: extra " Ralph Sennhauser
2017-03-16 15:43 ` Linus Walleij
2017-03-16 6:34 ` [PATCH 6/6] gpio: mvebu: let the compiler inline Ralph Sennhauser
2017-03-16 15:44 ` Linus Walleij
2017-03-17 9:08 ` Ralph Sennhauser
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170316063402.8667-2-ralph.sennhauser@gmail.com \
--to=ralph.sennhauser@gmail.com \
--cc=gnurou@gmail.com \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).