* [PATCH] pinctrl: sh-pfc: r8a7791: fix SCIF2 pinmux data
@ 2017-03-30 20:20 Sergei Shtylyov
2017-03-31 10:53 ` Geert Uytterhoeven
0 siblings, 1 reply; 2+ messages in thread
From: Sergei Shtylyov @ 2017-03-30 20:20 UTC (permalink / raw)
To: Laurent Pinchart, Geert Uytterhoeven, Linus Walleij,
linux-renesas-soc, linux-gpio
Cc: Sergei Shtylyov
[-- Attachment #1: pinctrl-sh-pfc-r8a7791-fix-SCIF2-pinmux-data.patch --]
[-- Type: text/plain, Size: 1185 bytes --]
PINMUX_IPSR_MSEL() macro invocation for the TX2 signal has apparently wrong
1st argument -- most probably a result of cut&paste programming...
Fixes: 508845196238 ("pinctrl: sh-pfc: r8a7791 PFC support")
Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
---
This patch is against the 'fixes' branch of Linus Walleij's 'linux-pinctrl.git'
repo plus 2 R8A7791 fixes posted yesterday.
drivers/pinctrl/sh-pfc/pfc-r8a7791.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Index: linux-pinctrl/drivers/pinctrl/sh-pfc/pfc-r8a7791.c
===================================================================
--- linux-pinctrl.orig/drivers/pinctrl/sh-pfc/pfc-r8a7791.c
+++ linux-pinctrl/drivers/pinctrl/sh-pfc/pfc-r8a7791.c
@@ -1103,7 +1103,7 @@ static const u16 pinmux_data[] = {
PINMUX_IPSR_MSEL(IP6_5_3, FMIN_E, SEL_FM_4),
PINMUX_IPSR_GPSR(IP6_7_6, AUDIO_CLKOUT),
PINMUX_IPSR_MSEL(IP6_7_6, MSIOF1_SS1_B, SEL_SOF1_1),
- PINMUX_IPSR_MSEL(IP6_5_3, TX2, SEL_SCIF2_0),
+ PINMUX_IPSR_MSEL(IP6_7_6, TX2, SEL_SCIF2_0),
PINMUX_IPSR_MSEL(IP6_7_6, SCIFA2_TXD, SEL_SCIFA2_0),
PINMUX_IPSR_GPSR(IP6_9_8, IRQ0),
PINMUX_IPSR_MSEL(IP6_9_8, SCIFB1_RXD_D, SEL_SCIFB1_3),
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] pinctrl: sh-pfc: r8a7791: fix SCIF2 pinmux data
2017-03-30 20:20 [PATCH] pinctrl: sh-pfc: r8a7791: fix SCIF2 pinmux data Sergei Shtylyov
@ 2017-03-31 10:53 ` Geert Uytterhoeven
0 siblings, 0 replies; 2+ messages in thread
From: Geert Uytterhoeven @ 2017-03-31 10:53 UTC (permalink / raw)
To: Sergei Shtylyov
Cc: Laurent Pinchart, Geert Uytterhoeven, Linus Walleij,
Linux-Renesas, linux-gpio@vger.kernel.org
On Thu, Mar 30, 2017 at 10:20 PM, Sergei Shtylyov
<sergei.shtylyov@cogentembedded.com> wrote:
> PINMUX_IPSR_MSEL() macro invocation for the TX2 signal has apparently wrong
> 1st argument -- most probably a result of cut&paste programming...
>
> Fixes: 508845196238 ("pinctrl: sh-pfc: r8a7791 PFC support")
> Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-03-31 10:53 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-03-30 20:20 [PATCH] pinctrl: sh-pfc: r8a7791: fix SCIF2 pinmux data Sergei Shtylyov
2017-03-31 10:53 ` Geert Uytterhoeven
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).