linux-gpio.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] pinctrl: sh-pfc: r8a7791: fix IPSR comment typos
@ 2017-03-31 20:29 Sergei Shtylyov
  2017-04-03  7:21 ` Geert Uytterhoeven
  0 siblings, 1 reply; 2+ messages in thread
From: Sergei Shtylyov @ 2017-03-31 20:29 UTC (permalink / raw)
  To: Laurent Pinchart, Geert Uytterhoeven, Linus Walleij,
	linux-renesas-soc, linux-gpio
  Cc: Sergei Shtylyov

[-- Attachment #1: pinctrl-sh-pfc-r8a7791-fix-IPSR-comment-typos.patch --]
[-- Type: text/plain, Size: 1322 bytes --]

The IPSR field names in the comments have been fat-fingered in a couple
places --  fix those silly typos...

Fixes: 508845196238 ("pinctrl: sh-pfc: r8a7791 PFC support")
Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>

---
This patch is against the 'fixes' branch of Linus Walleij's 'linux-pinctrl.git'
repo plus  3 R8A7791 fixes posted in the last couple days...

 drivers/pinctrl/sh-pfc/pfc-r8a7791.c |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Index: linux-pinctrl/drivers/pinctrl/sh-pfc/pfc-r8a7791.c
===================================================================
--- linux-pinctrl.orig/drivers/pinctrl/sh-pfc/pfc-r8a7791.c
+++ linux-pinctrl/drivers/pinctrl/sh-pfc/pfc-r8a7791.c
@@ -5711,7 +5711,7 @@ static const struct pinmux_cfg_reg pinmu
 	},
 	{ PINMUX_CFG_REG_VAR("IPSR2", 0xE6060028, 32,
 			     2, 3, 2, 2, 2, 2, 3, 3, 3, 3, 2, 2, 3) {
-		/* IP2_31_20 [2] */
+		/* IP2_31_30 [2] */
 		0, 0, 0, 0,
 		/* IP2_29_27 [3] */
 		FN_EX_CS3_N, FN_ATADIR0_N, FN_MSIOF2_TXD,
@@ -6042,7 +6042,7 @@ static const struct pinmux_cfg_reg pinmu
 		/* IP10_24_22 [3] */
 		FN_VI0_R1, FN_VI2_DATA2, FN_GLO_I1_B, FN_TS_SCK0_C, FN_ATAG1_N,
 		0, 0, 0,
-		/* IP10_21_29 [3] */
+		/* IP10_21_19 [3] */
 		FN_VI0_R0, FN_VI2_DATA1, FN_GLO_I0_B,
 		FN_TS_SDATA0_C, FN_ATACS11_N,
 		0, 0, 0,


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] pinctrl: sh-pfc: r8a7791: fix IPSR comment typos
  2017-03-31 20:29 [PATCH] pinctrl: sh-pfc: r8a7791: fix IPSR comment typos Sergei Shtylyov
@ 2017-04-03  7:21 ` Geert Uytterhoeven
  0 siblings, 0 replies; 2+ messages in thread
From: Geert Uytterhoeven @ 2017-04-03  7:21 UTC (permalink / raw)
  To: Sergei Shtylyov
  Cc: Laurent Pinchart, Geert Uytterhoeven, Linus Walleij,
	Linux-Renesas, linux-gpio@vger.kernel.org

Hi Sergii,

On Fri, Mar 31, 2017 at 10:29 PM, Sergei Shtylyov
<sergei.shtylyov@cogentembedded.com> wrote:
> The IPSR field names in the comments have been fat-fingered in a couple
> places --  fix those silly typos...

Thanks!

> Fixes: 508845196238 ("pinctrl: sh-pfc: r8a7791 PFC support")
> Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>

Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>

> ---
> This patch is against the 'fixes' branch of Linus Walleij's 'linux-pinctrl.git'
> repo plus  3 R8A7791 fixes posted in the last couple days...
>
>  drivers/pinctrl/sh-pfc/pfc-r8a7791.c |    4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> Index: linux-pinctrl/drivers/pinctrl/sh-pfc/pfc-r8a7791.c
> ===================================================================
> --- linux-pinctrl.orig/drivers/pinctrl/sh-pfc/pfc-r8a7791.c
> +++ linux-pinctrl/drivers/pinctrl/sh-pfc/pfc-r8a7791.c
> @@ -5711,7 +5711,7 @@ static const struct pinmux_cfg_reg pinmu
>         },
>         { PINMUX_CFG_REG_VAR("IPSR2", 0xE6060028, 32,
>                              2, 3, 2, 2, 2, 2, 3, 3, 3, 3, 2, 2, 3) {
> -               /* IP2_31_20 [2] */
> +               /* IP2_31_30 [2] */
>                 0, 0, 0, 0,
>                 /* IP2_29_27 [3] */
>                 FN_EX_CS3_N, FN_ATADIR0_N, FN_MSIOF2_TXD,

There's another one a few lines below:

-                  /* IP2_12_0 [3] */
+                 /* IP2_12_10 [3] */

I'll fix that up when applying...

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2017-04-03  7:21 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-03-31 20:29 [PATCH] pinctrl: sh-pfc: r8a7791: fix IPSR comment typos Sergei Shtylyov
2017-04-03  7:21 ` Geert Uytterhoeven

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).