* [PATCH] pinctrl: cherryview: Add terminate entry for dmi_system_id tables
@ 2017-04-25 6:22 Wei Yongjun
2017-04-25 9:10 ` Mika Westerberg
2017-04-28 7:36 ` Linus Walleij
0 siblings, 2 replies; 3+ messages in thread
From: Wei Yongjun @ 2017-04-25 6:22 UTC (permalink / raw)
To: Mika Westerberg, Heikki Krogerus, Linus Walleij; +Cc: Wei Yongjun, linux-gpio
From: Wei Yongjun <weiyongjun1@huawei.com>
Make sure dmi_system_id tables are NULL terminated.
Fixes: 703650278372 ("pinctrl: cherryview: Add a quirk to make Acer
Chromebook keyboard work again")
Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
---
drivers/pinctrl/intel/pinctrl-cherryview.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/pinctrl/intel/pinctrl-cherryview.c b/drivers/pinctrl/intel/pinctrl-cherryview.c
index 9ff7901..1d09097 100644
--- a/drivers/pinctrl/intel/pinctrl-cherryview.c
+++ b/drivers/pinctrl/intel/pinctrl-cherryview.c
@@ -1542,7 +1542,8 @@ static const struct dmi_system_id chv_no_valid_mask[] = {
DMI_MATCH(DMI_PRODUCT_NAME, "Edgar"),
DMI_MATCH(DMI_BIOS_DATE, "05/21/2016"),
},
- }
+ },
+ {}
};
static int chv_gpio_probe(struct chv_pinctrl *pctrl, int irq)
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] pinctrl: cherryview: Add terminate entry for dmi_system_id tables
2017-04-25 6:22 [PATCH] pinctrl: cherryview: Add terminate entry for dmi_system_id tables Wei Yongjun
@ 2017-04-25 9:10 ` Mika Westerberg
2017-04-28 7:36 ` Linus Walleij
1 sibling, 0 replies; 3+ messages in thread
From: Mika Westerberg @ 2017-04-25 9:10 UTC (permalink / raw)
To: Wei Yongjun; +Cc: Heikki Krogerus, Linus Walleij, Wei Yongjun, linux-gpio
On Tue, Apr 25, 2017 at 06:22:05AM +0000, Wei Yongjun wrote:
> From: Wei Yongjun <weiyongjun1@huawei.com>
>
> Make sure dmi_system_id tables are NULL terminated.
>
> Fixes: 703650278372 ("pinctrl: cherryview: Add a quirk to make Acer
> Chromebook keyboard work again")
> Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
I was just going to send similar patch but you were faster :)
Definitely right thing to do, thanks for fixing it.
Acked-by: Mika Westerberg <mika.westerberg@linux.intel.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] pinctrl: cherryview: Add terminate entry for dmi_system_id tables
2017-04-25 6:22 [PATCH] pinctrl: cherryview: Add terminate entry for dmi_system_id tables Wei Yongjun
2017-04-25 9:10 ` Mika Westerberg
@ 2017-04-28 7:36 ` Linus Walleij
1 sibling, 0 replies; 3+ messages in thread
From: Linus Walleij @ 2017-04-28 7:36 UTC (permalink / raw)
To: Wei Yongjun
Cc: Mika Westerberg, Heikki Krogerus, Wei Yongjun,
linux-gpio@vger.kernel.org
On Tue, Apr 25, 2017 at 8:22 AM, Wei Yongjun <weiyj.lk@gmail.com> wrote:
> From: Wei Yongjun <weiyongjun1@huawei.com>
>
> Make sure dmi_system_id tables are NULL terminated.
>
> Fixes: 703650278372 ("pinctrl: cherryview: Add a quirk to make Acer
> Chromebook keyboard work again")
> Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
Patch applied with Mika's ACK.
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-04-28 7:36 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-04-25 6:22 [PATCH] pinctrl: cherryview: Add terminate entry for dmi_system_id tables Wei Yongjun
2017-04-25 9:10 ` Mika Westerberg
2017-04-28 7:36 ` Linus Walleij
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).