From: Maxime Ripard <maxime.ripard-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>
To: Icenowy Zheng <icenowy-h8G6r0blFSE@public.gmane.org>
Cc: Rob Herring <robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
Chen-Yu Tsai <wens-jdAy2FN1RRM@public.gmane.org>,
Linus Walleij
<linus.walleij-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>,
linux-doc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-clk-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-gpio-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-sunxi-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org
Subject: Re: [PATCH v2 03/10] pinctrl: sunxi: add A20 support to A10 driver
Date: Thu, 4 May 2017 16:02:20 +0200 [thread overview]
Message-ID: <20170504140220.26kguf3trz7ocylv@lukather> (raw)
In-Reply-To: <20170504135006.16483-4-icenowy-h8G6r0blFSE@public.gmane.org>
[-- Attachment #1: Type: text/plain, Size: 669 bytes --]
On Thu, May 04, 2017 at 09:49:59PM +0800, Icenowy Zheng wrote:
> static const struct of_device_id sun4i_a10_pinctrl_match[] = {
> - { .compatible = "allwinner,sun4i-a10-pinctrl", },
> + {
> + .compatible = "allwinner,sun4i-a10-pinctrl",
> + .data = (void *)PINCTRL_SUN4I_A10
> + },
> + {
> + .compatible = "allwinner,sun7i-a20-pinctrl",
> + .data = (void *)PINCTRL_SUN7I_A20
> + },
> {}
> };
This means you're going to have two drivers probing for the same
device: this driver, and the old one. This is not ok, and probably
introduces some corner cases.
Maxime
--
Maxime Ripard, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
next prev parent reply other threads:[~2017-05-04 14:02 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-04 13:49 [PATCH v2 00/10] Initial Allwinner R40 support Icenowy Zheng
[not found] ` <20170504135006.16483-1-icenowy-h8G6r0blFSE@public.gmane.org>
2017-05-04 13:49 ` [PATCH v2 01/10] arm: sunxi: add support for R40 SoC Icenowy Zheng
[not found] ` <20170504135006.16483-2-icenowy-h8G6r0blFSE@public.gmane.org>
2017-05-05 3:35 ` Chen-Yu Tsai
2017-05-04 13:49 ` [PATCH v2 02/10] pinctrl: sunxi: add definitions for add A20 and R40 support to A10 driver Icenowy Zheng
[not found] ` <20170504135006.16483-3-icenowy-h8G6r0blFSE@public.gmane.org>
2017-05-04 14:04 ` Maxime Ripard
2017-05-04 14:07 ` Icenowy Zheng
[not found] ` <318E9984-9F5A-41C3-A3E0-52D5ECA05212-h8G6r0blFSE@public.gmane.org>
2017-05-04 14:40 ` Maxime Ripard
2017-05-04 13:49 ` [PATCH v2 03/10] pinctrl: sunxi: add A20 " Icenowy Zheng
[not found] ` <20170504135006.16483-4-icenowy-h8G6r0blFSE@public.gmane.org>
2017-05-04 14:02 ` Maxime Ripard [this message]
2017-05-04 14:03 ` Icenowy Zheng
[not found] ` <83062089-19CD-4805-A6DC-2C25D75621FF-h8G6r0blFSE@public.gmane.org>
2017-05-04 14:41 ` Maxime Ripard
2017-05-04 14:45 ` Icenowy Zheng
[not found] ` <52C75207-6F41-4B3F-8953-F4F040358792-h8G6r0blFSE@public.gmane.org>
2017-05-05 19:49 ` Maxime Ripard
2017-05-04 13:50 ` [PATCH v2 04/10] pinctrl: sunxi: switch A20's pinctrl driver to use the A10 version Icenowy Zheng
[not found] ` <20170504135006.16483-5-icenowy-h8G6r0blFSE@public.gmane.org>
2017-05-11 14:41 ` Linus Walleij
2017-05-04 13:50 ` [PATCH v2 05/10] dt-bindings: add compatible string for Allwinner R40 pinctrl Icenowy Zheng
[not found] ` <20170504135006.16483-6-icenowy-h8G6r0blFSE@public.gmane.org>
2017-05-08 16:44 ` Rob Herring
2017-05-04 13:50 ` [PATCH v2 06/10] pinctrl: sunxi: add support of R40 to A10 pinctrl driver Icenowy Zheng
2017-05-04 13:50 ` [PATCH v2 07/10] dt-bindings: add compatible string for Allwinner R40 CCU Icenowy Zheng
2017-05-08 16:44 ` Rob Herring
2017-05-04 13:50 ` [PATCH v2 08/10] clk: sunxi-ng: support R40 SoC Icenowy Zheng
[not found] ` <20170504135006.16483-9-icenowy-h8G6r0blFSE@public.gmane.org>
2017-05-04 14:23 ` Maxime Ripard
2017-05-04 13:50 ` [PATCH v2 09/10] ARM: dts: sun8i: Add basic dtsi file for Allwinner R40 Icenowy Zheng
[not found] ` <20170504135006.16483-10-icenowy-h8G6r0blFSE@public.gmane.org>
2017-05-04 14:31 ` Maxime Ripard
2017-05-04 13:50 ` [PATCH v2 10/10] ARM: dts: sun8i: Add board dts file for Banana Pi M2 Ultra Icenowy Zheng
[not found] ` <20170504135006.16483-11-icenowy-h8G6r0blFSE@public.gmane.org>
2017-05-04 14:39 ` Maxime Ripard
2017-05-11 13:44 ` Linus Walleij
2017-05-22 8:48 ` [PATCH v2 00/10] Initial Allwinner R40 support Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170504140220.26kguf3trz7ocylv@lukather \
--to=maxime.ripard-wi1+55scjutkeb57/3fjtnbpr1lh4cv8@public.gmane.org \
--cc=devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=icenowy-h8G6r0blFSE@public.gmane.org \
--cc=linus.walleij-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org \
--cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
--cc=linux-clk-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-doc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-gpio-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-sunxi-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org \
--cc=robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
--cc=wens-jdAy2FN1RRM@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox