From mboxrd@z Thu Jan 1 00:00:00 1970 From: Maxime Ripard Subject: Re: [PATCH v2 02/10] pinctrl: sunxi: add definitions for add A20 and R40 support to A10 driver Date: Thu, 4 May 2017 16:04:31 +0200 Message-ID: <20170504140431.zhpcxvphxnxj7ipq@lukather> References: <20170504135006.16483-1-icenowy@aosc.io> <20170504135006.16483-3-icenowy@aosc.io> Reply-To: maxime.ripard-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="kgqcsg4xoxy3tnku" Return-path: Sender: linux-sunxi-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org Content-Disposition: inline In-Reply-To: <20170504135006.16483-3-icenowy-h8G6r0blFSE@public.gmane.org> List-Post: , List-Help: , List-Archive: , List-Unsubscribe: , To: Icenowy Zheng Cc: Rob Herring , Chen-Yu Tsai , Linus Walleij , linux-doc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-clk-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-gpio-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-sunxi-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org List-Id: linux-gpio@vger.kernel.org --kgqcsg4xoxy3tnku Content-Type: text/plain; charset=UTF-8 Content-Disposition: inline On Thu, May 04, 2017 at 09:49:58PM +0800, Icenowy Zheng wrote: > Allwinner A10, A20 and R40 SoCs have similar GPIO layout. > > Add SoC definitions in pinctrl-sunxi.h, in order to merge A20 support > into A10 driver, and add R40 support into it. While your commit log is good, the commit title is misleading since you're not adding it to the A10 driver. You just adding SoC IDs definitions Maxime -- Maxime Ripard, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com --kgqcsg4xoxy3tnku--