From mboxrd@z Thu Jan 1 00:00:00 1970 From: Shawn Guo Subject: Re: [PATCH 1/5] pinctrl: imx: add generic pin config core support Date: Mon, 15 May 2017 18:56:16 +0800 Message-ID: <20170515105615.GN8471@dragon> References: <1494592686-30967-1-git-send-email-aisheng.dong@nxp.com> <1494592686-30967-2-git-send-email-aisheng.dong@nxp.com> <20170515083500.GL8471@dragon> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from mail.kernel.org ([198.145.29.99]:39792 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752872AbdEOK4l (ORCPT ); Mon, 15 May 2017 06:56:41 -0400 Content-Disposition: inline In-Reply-To: Sender: linux-gpio-owner@vger.kernel.org List-Id: linux-gpio@vger.kernel.org To: "A.S. Dong" Cc: Andy Duan , Jacky Bai , "linus.walleij@linaro.org" , "stefan@agner.ch" , "linux-gpio@vger.kernel.org" , "kernel@pengutronix.de" , "linux-arm-kernel@lists.infradead.org" On Mon, May 15, 2017 at 08:56:18AM +0000, A.S. Dong wrote: > > > @@ -489,17 +547,29 @@ static int imx_pinctrl_parse_groups(struct > > device_node *np, > > > pin_size = SHARE_FSL_PIN_SIZE; > > > else > > > pin_size = FSL_PIN_SIZE; > > > + > > > + if (info->generic_pinconf) > > > + pin_size -= 4; > > > + > > > /* Initialise group */ > > > grp->name = np->name; > > > > > > /* > > > - * the binding format is fsl,pins = , > > > + * the binding format is pins = , > > > > This is not correct for generic pinconf bindings. CONIFIG shouldn't be > > there. > > > > Yes, that's for legacy stuff. If that's for legacy bindings, you shouldn't change 'fsl,pins' to 'pins', right? Shawn