linux-gpio.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Shawn Guo <shawnguo@kernel.org>
To: "A.S. Dong" <aisheng.dong@nxp.com>
Cc: Mark Rutland <mark.rutland@arm.com>,
	"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
	Andy Duan <fugang.duan@nxp.com>, Jacky Bai <ping.bai@nxp.com>,
	"linus.walleij@linaro.org" <linus.walleij@linaro.org>,
	"stefan@agner.ch" <stefan@agner.ch>,
	"linux-gpio@vger.kernel.org" <linux-gpio@vger.kernel.org>,
	Rob Herring <robh+dt@kernel.org>,
	"kernel@pengutronix.de" <kernel@pengutronix.de>,
	"linux-arm-kernel@lists.infradead.org"
	<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH 3/5] dt-bindings: pinctrl: add imx7ulp pinctrl binding doc
Date: Mon, 15 May 2017 20:59:07 +0800	[thread overview]
Message-ID: <20170515125905.GV8471@dragon> (raw)
In-Reply-To: <AM3PR04MB3069C788C96EE2854C2C68080E10@AM3PR04MB306.eurprd04.prod.outlook.com>

On Mon, May 15, 2017 at 12:41:09PM +0000, A.S. Dong wrote:
> > On Mon, May 15, 2017 at 12:06:19PM +0000, A.S. Dong wrote:
> > > > > @@ -0,0 +1,56 @@
> > > > > +* Freescale i.MX7ULP IOMUX Controller
> > > > > +
> > > > > +Please refer to fsl,imx-pinctrl.txt in this directory for common
> > > > > +binding part and usage.
> > > >
> > > > Are imx7ulp-pinctrl bindings more alike to fsl,imx-pinctrl.txt or
> > > > generic pinctrl-bindings.txt?  My personal feeling is that it might
> > > > be better to take pinctrl-bindings.txt as the reference base and
> > > > highlight how imx7ulp- pinctrl bindings differ from it.
> > > >
> > >
> > > It seems still more like fsl,imx-pinctrl.txt.
> > >
> > > I know fsl,imx-pinctrl.txt is a bit out of date, especially after we
> > > add generic pinconf.
> > >
> > > I plan to update it later after adding generic pin conf support to
> > > legacy SoCs (MX6 & 7) as well, do you think it's ok?
> > 
> > Please do not.  Let's use generic pinconf support only for new SoCs, and
> > not bother with legacy SoCs.
> > 
> 
> I wonder there may be some guys interested more in generic Pinconfig format
> rather than old one when they add new board support, or someone else
> adding the support for legacy SoCs as the pinctrl-imx core already
> supports it after this patch series.

I would take this as an unnecessary churn on existing code and increase
of maintenance burden.  So that's definitely a NO from me.

Shawn

  reply	other threads:[~2017-05-15 12:59 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-05-12 12:38 [PATCH 0/5] pinctrl: imx: add generic pin config and imx7ulp support Dong Aisheng
2017-05-12 12:38 ` [PATCH 1/5] pinctrl: imx: add generic pin config core support Dong Aisheng
2017-05-15  8:35   ` Shawn Guo
2017-05-15  8:56     ` A.S. Dong
2017-05-15 10:56       ` Shawn Guo
2017-05-15 11:16         ` A.S. Dong
2017-05-15 11:56           ` Shawn Guo
2017-05-15 12:07             ` A.S. Dong
2017-05-12 12:38 ` [PATCH 2/5] pinctrl: imx: add soc specific mux_mode mask and shift property Dong Aisheng
2017-05-15  8:52   ` Shawn Guo
2017-05-15  9:00     ` A.S. Dong
2017-05-15 10:59       ` Shawn Guo
2017-05-15 11:04         ` A.S. Dong
2017-05-12 12:38 ` [PATCH 2/5] pinctrl: pinctrl-imx: " Dong Aisheng
2017-05-12 13:32   ` A.S. Dong
2017-05-12 12:38 ` [PATCH 3/5] dt-bindings: pinctrl: add imx7ulp pinctrl binding doc Dong Aisheng
2017-05-15 11:43   ` Shawn Guo
2017-05-15 12:06     ` A.S. Dong
     [not found]       ` <AM3PR04MB3069C90F23CF9C9CC84BA7580E10-f56W/S9L6NSIzFHTN1kKrAfhPeD8jYilXA4E9RH9d+qIuWR1G4zioA@public.gmane.org>
2017-05-15 12:20         ` Shawn Guo
2017-05-15 12:41           ` A.S. Dong
2017-05-15 12:59             ` Shawn Guo [this message]
2017-05-15 13:12               ` A.S. Dong
     [not found]   ` <1494592686-30967-5-git-send-email-aisheng.dong-3arQi8VN3Tc@public.gmane.org>
2017-05-15 13:31     ` Shawn Guo
2017-05-15 13:32       ` A.S. Dong
2017-05-12 12:38 ` [PATCH 4/5] pinctrl: imx: add imx7ulp driver Dong Aisheng
2017-05-12 12:38 ` [PATCH 5/5] pinctrl: imx: fix debug message for SHARE_MUX_CONF_REG case Dong Aisheng
2017-05-15 12:05   ` Shawn Guo
2017-05-15 12:08     ` A.S. Dong

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170515125905.GV8471@dragon \
    --to=shawnguo@kernel.org \
    --cc=aisheng.dong@nxp.com \
    --cc=devicetree@vger.kernel.org \
    --cc=fugang.duan@nxp.com \
    --cc=kernel@pengutronix.de \
    --cc=linus.walleij@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-gpio@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=ping.bai@nxp.com \
    --cc=robh+dt@kernel.org \
    --cc=stefan@agner.ch \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).