From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Wolfram Sang <wsa@the-dreams.de>
Cc: linux-i2c@vger.kernel.org, Steven Miao <realmz6@gmail.com>,
Michael Hennerich <michael.hennerich@analog.com>,
Linus Walleij <linus.walleij@linaro.org>,
Alexandre Courbot <gnurou@gmail.com>,
adi-buildroot-devel@lists.sourceforge.net,
linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org,
linux-input@vger.kernel.org
Subject: Re: [PATCH 3/3] gpio: adp5588: move header file out of I2C realm
Date: Mon, 22 May 2017 16:40:26 -0700 [thread overview]
Message-ID: <20170522234026.GD12016@dtor-ws> (raw)
In-Reply-To: <20170521215727.1243-4-wsa@the-dreams.de>
On Sun, May 21, 2017 at 11:57:27PM +0200, Wolfram Sang wrote:
> include/linux/i2c is not for client devices. Move the header file to a
> more appropriate location.
>
> Signed-off-by: Wolfram Sang <wsa@the-dreams.de>
> ---
>
> This driver could also go via the input-tree or my tree. I don't really care
> and just picked some subsystem :) Let me know if you are okay with that.
Acked-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
>
> arch/blackfin/mach-bf537/boards/stamp.c | 2 +-
> drivers/gpio/gpio-adp5588.c | 2 +-
> drivers/input/keyboard/adp5588-keys.c | 2 +-
> include/linux/{i2c => platform_data}/adp5588.h | 0
> 4 files changed, 3 insertions(+), 3 deletions(-)
> rename include/linux/{i2c => platform_data}/adp5588.h (100%)
>
> diff --git a/arch/blackfin/mach-bf537/boards/stamp.c b/arch/blackfin/mach-bf537/boards/stamp.c
> index eaec7b4832a29a..24985e658c19cd 100644
> --- a/arch/blackfin/mach-bf537/boards/stamp.c
> +++ b/arch/blackfin/mach-bf537/boards/stamp.c
> @@ -22,7 +22,7 @@
> #include <linux/usb/isp1362.h>
> #endif
> #include <linux/i2c.h>
> -#include <linux/i2c/adp5588.h>
> +#include <linux/platform_data/adp5588.h>
> #include <linux/etherdevice.h>
> #include <linux/ata_platform.h>
> #include <linux/irq.h>
> diff --git a/drivers/gpio/gpio-adp5588.c b/drivers/gpio/gpio-adp5588.c
> index c0f718b1231727..e717f8dc39667c 100644
> --- a/drivers/gpio/gpio-adp5588.c
> +++ b/drivers/gpio/gpio-adp5588.c
> @@ -16,7 +16,7 @@
> #include <linux/interrupt.h>
> #include <linux/irq.h>
>
> -#include <linux/i2c/adp5588.h>
> +#include <linux/platform_data/adp5588.h>
>
> #define DRV_NAME "adp5588-gpio"
>
> diff --git a/drivers/input/keyboard/adp5588-keys.c b/drivers/input/keyboard/adp5588-keys.c
> index 53fe9a3fb6204d..f9d273c8b30695 100644
> --- a/drivers/input/keyboard/adp5588-keys.c
> +++ b/drivers/input/keyboard/adp5588-keys.c
> @@ -20,7 +20,7 @@
> #include <linux/gpio.h>
> #include <linux/slab.h>
>
> -#include <linux/i2c/adp5588.h>
> +#include <linux/platform_data/adp5588.h>
>
> /* Key Event Register xy */
> #define KEY_EV_PRESSED (1 << 7)
> diff --git a/include/linux/i2c/adp5588.h b/include/linux/platform_data/adp5588.h
> similarity index 100%
> rename from include/linux/i2c/adp5588.h
> rename to include/linux/platform_data/adp5588.h
> --
> 2.11.0
>
--
Dmitry
next prev parent reply other threads:[~2017-05-22 23:40 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-21 21:57 [PATCH 0/3] gpio: move include files out of include/linux/i2c Wolfram Sang
2017-05-21 21:57 ` [PATCH 1/3] gpio: max732x: move header file out of I2C realm Wolfram Sang
2017-05-23 9:34 ` Linus Walleij
2017-05-21 21:57 ` [PATCH 2/3] gpio: pcf857x: " Wolfram Sang
2017-05-23 9:35 ` Linus Walleij
2017-05-25 8:52 ` Sekhar Nori
2017-05-21 21:57 ` [PATCH 3/3] gpio: adp5588: " Wolfram Sang
2017-05-22 23:40 ` Dmitry Torokhov [this message]
2017-05-25 17:09 ` Wolfram Sang
2017-05-29 11:37 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170522234026.GD12016@dtor-ws \
--to=dmitry.torokhov@gmail.com \
--cc=adi-buildroot-devel@lists.sourceforge.net \
--cc=gnurou@gmail.com \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=michael.hennerich@analog.com \
--cc=realmz6@gmail.com \
--cc=wsa@the-dreams.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).