From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dmitry Torokhov Subject: Re: [PATCH 3/3] gpio: adp5588: move header file out of I2C realm Date: Mon, 22 May 2017 16:40:26 -0700 Message-ID: <20170522234026.GD12016@dtor-ws> References: <20170521215727.1243-1-wsa@the-dreams.de> <20170521215727.1243-4-wsa@the-dreams.de> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <20170521215727.1243-4-wsa@the-dreams.de> Sender: linux-i2c-owner@vger.kernel.org To: Wolfram Sang Cc: linux-i2c@vger.kernel.org, Steven Miao , Michael Hennerich , Linus Walleij , Alexandre Courbot , adi-buildroot-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org, linux-input@vger.kernel.org List-Id: linux-gpio@vger.kernel.org On Sun, May 21, 2017 at 11:57:27PM +0200, Wolfram Sang wrote: > include/linux/i2c is not for client devices. Move the header file to a > more appropriate location. > > Signed-off-by: Wolfram Sang > --- > > This driver could also go via the input-tree or my tree. I don't really care > and just picked some subsystem :) Let me know if you are okay with that. Acked-by: Dmitry Torokhov > > arch/blackfin/mach-bf537/boards/stamp.c | 2 +- > drivers/gpio/gpio-adp5588.c | 2 +- > drivers/input/keyboard/adp5588-keys.c | 2 +- > include/linux/{i2c => platform_data}/adp5588.h | 0 > 4 files changed, 3 insertions(+), 3 deletions(-) > rename include/linux/{i2c => platform_data}/adp5588.h (100%) > > diff --git a/arch/blackfin/mach-bf537/boards/stamp.c b/arch/blackfin/mach-bf537/boards/stamp.c > index eaec7b4832a29a..24985e658c19cd 100644 > --- a/arch/blackfin/mach-bf537/boards/stamp.c > +++ b/arch/blackfin/mach-bf537/boards/stamp.c > @@ -22,7 +22,7 @@ > #include > #endif > #include > -#include > +#include > #include > #include > #include > diff --git a/drivers/gpio/gpio-adp5588.c b/drivers/gpio/gpio-adp5588.c > index c0f718b1231727..e717f8dc39667c 100644 > --- a/drivers/gpio/gpio-adp5588.c > +++ b/drivers/gpio/gpio-adp5588.c > @@ -16,7 +16,7 @@ > #include > #include > > -#include > +#include > > #define DRV_NAME "adp5588-gpio" > > diff --git a/drivers/input/keyboard/adp5588-keys.c b/drivers/input/keyboard/adp5588-keys.c > index 53fe9a3fb6204d..f9d273c8b30695 100644 > --- a/drivers/input/keyboard/adp5588-keys.c > +++ b/drivers/input/keyboard/adp5588-keys.c > @@ -20,7 +20,7 @@ > #include > #include > > -#include > +#include > > /* Key Event Register xy */ > #define KEY_EV_PRESSED (1 << 7) > diff --git a/include/linux/i2c/adp5588.h b/include/linux/platform_data/adp5588.h > similarity index 100% > rename from include/linux/i2c/adp5588.h > rename to include/linux/platform_data/adp5588.h > -- > 2.11.0 > -- Dmitry