From mboxrd@z Thu Jan 1 00:00:00 1970 From: Lee Jones Subject: Re: [PATCH 1/3] gpio: Add new flags to control sleep status of GPIOs Date: Tue, 23 May 2017 09:51:02 +0100 Message-ID: <20170523085102.hgr7yovshqy5arkq@dell> References: <1494948714-15203-1-git-send-email-ckeepax@opensource.wolfsonmicro.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Return-path: Content-Disposition: inline In-Reply-To: Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Linus Walleij Cc: Charles Keepax , Rob Herring , Mark Rutland , Alexandre Courbot , "linux-gpio-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , "devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , "open list:WOLFSON MICROELECTRONICS DRIVERS" List-Id: linux-gpio@vger.kernel.org On Tue, 23 May 2017, Linus Walleij wrote: > On Tue, May 16, 2017 at 5:31 PM, Charles Keepax > wrote: > > > Add new flags to allow users to specify that they are not concerned with > > the status of GPIOs whilst in a sleep/low power state. > > > > Signed-off-by: Charles Keepax > > Would be nice to have some opinion from the DT maintainers about > this but seems all right to me. Not sure if it makes a difference, but Rob Acked the bindings already. > > +++ b/include/dt-bindings/gpio/gpio.h > > @@ -21,6 +21,10 @@ > > #define GPIO_LINE_OPEN_SOURCE 0 > > #define GPIO_LINE_OPEN_DRAIN 4 > > > > +/* Bit 3 express GPIO suspend/resume persistence */ > > +#define GPIO_SLEEP_MAINTAIN_VALUE 0 > > +#define GPIO_SLEEP_MAY_LOOSE_VALUE 8 > > + > > /* > > * Open Drain/Collector is the combination of single-ended open drain interface. > > * Open Source/Emitter is the combination of single-ended open source interface. > > Please move the define below the comment and macros below it, > that is using the defines right above... > > Yours, > Linus Walleij -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html