From: Paul Gortmaker <paul.gortmaker@windriver.com>
To: Krzysztof Kozlowski <krzk@kernel.org>
Cc: linux-kernel@vger.kernel.org, Tomasz Figa <tomasz.figa@gmail.com>,
Thomas Abraham <thomas.ab@samsung.com>,
Linus Walleij <linus.walleij@linaro.org>,
linux-samsung-soc@vger.kernel.org, linux-gpio@vger.kernel.org
Subject: Re: [PATCH 1/3] pinctrl: samsung: clean up modular vs. non-modular distinctions
Date: Tue, 23 May 2017 11:54:44 -0400 [thread overview]
Message-ID: <20170523155444.GE11504@windriver.com> (raw)
In-Reply-To: <CAJKOXPcJDFw2-EW+dGvL1AtVwXWkxAQ6cnF0o6GGgaaxeqBqug@mail.gmail.com>
[Re: [PATCH 1/3] pinctrl: samsung: clean up modular vs. non-modular distinctions] On 23/05/2017 (Tue 16:51) Krzysztof Kozlowski wrote:
> On Mon, May 22, 2017 at 10:56 PM, Paul Gortmaker
> <paul.gortmaker@windriver.com> wrote:
> > Fixups here tend to be more all over the map vs. some of the other
> > repeated/systematic ones we've seen elsewhere.
> >
> > We remove module.h from code that isn't doing anything modular at
> > all; if they have __init sections, then replace it with init.h
> >
> > A couple drivers have module_exit() code that is essentially orphaned,
> > and so we remove that.
> >
> > There are no module_init replacements, so we have no concerns wrt.
> > initcall ordering changes as per some of the other cleanups.
> >
> > Also note that MODULE_DEVICE_TABLE is a no-op for non-modular code.
> >
> > We also delete the MODULE_LICENSE tag etc. since all that information
> > was (or is now) contained at the top of the file in the comments.
> >
> > Cc: Tomasz Figa <tomasz.figa@gmail.com>
> > Cc: Thomas Abraham <thomas.ab@samsung.com>
> > Cc: Linus Walleij <linus.walleij@linaro.org>
> > Cc: linux-samsung-soc@vger.kernel.org
> > Cc: linux-gpio@vger.kernel.org
> > Acked-by: Sylwester Nawrocki <s.nawrocki@samsung.com>
> > Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com>
>
> These are quite old entries of maintainers. I guess you add Cc-entries
> once per git commit but no problem - I have it from the lists.
Actually what happend is it got sent quite some time ago, but Linus
didn't merge it because he wanted some Acks[1] and a resend. Shortly
after Sylwester provided an ack.
So with that in mind, I decided to restart with the most simple pinctrl
patches 1st, and hence it took a while to finally get back to this one
in the final series. But I didn't want to change an ack'd patch.
Not that it matters, but just in case you were curious.
Thanks,
Paul.
[1] https://marc.info/?l=linux-kernel&m=145803185919692&w=2
>
> Thanks, applied.
>
> Best regards, Krzysztof
next prev parent reply other threads:[~2017-05-23 15:54 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-22 20:56 [PATCH 0/3] pinctrl: bcm/samsung/tegra: make bool code non-modular Paul Gortmaker
2017-05-22 20:56 ` [PATCH 1/3] pinctrl: samsung: clean up modular vs. non-modular distinctions Paul Gortmaker
2017-05-23 14:51 ` Krzysztof Kozlowski
2017-05-23 15:54 ` Paul Gortmaker [this message]
2017-05-29 8:24 ` Linus Walleij
[not found] ` <20170522205648.23545-1-paul.gortmaker-CWA4WttNNZF54TAoqtyWWQ@public.gmane.org>
2017-05-22 20:56 ` [PATCH 2/3] pinctrl: tegra: " Paul Gortmaker
2017-05-29 8:25 ` Linus Walleij
2017-05-29 8:33 ` [PATCH 0/3] pinctrl: bcm/samsung/tegra: make bool code non-modular Linus Walleij
2017-05-22 20:56 ` [PATCH 3/3] pinctrl: bcm: clean up modular vs. non-modular distinctions Paul Gortmaker
2017-05-23 20:11 ` Stefan Wahren
2017-05-23 22:15 ` Scott Branden
2017-05-24 0:12 ` Paul Gortmaker
2017-05-24 0:25 ` Florian Fainelli
2017-05-24 0:37 ` Scott Branden
2017-05-24 0:42 ` Florian Fainelli
2017-05-24 0:34 ` Scott Branden
2017-05-29 8:31 ` Linus Walleij
2017-05-29 16:35 ` Scott Branden
2017-05-30 7:41 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170523155444.GE11504@windriver.com \
--to=paul.gortmaker@windriver.com \
--cc=krzk@kernel.org \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=thomas.ab@samsung.com \
--cc=tomasz.figa@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).