From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ralph Sennhauser Subject: Re: [PATCH v6 1/4] gpio: mvebu: Add limited PWM support Date: Wed, 31 May 2017 14:26:14 +0200 Message-ID: <20170531142614.5f32fca6@gmail.com> References: <20170414154056.32055-1-ralph.sennhauser@gmail.com> <20170414154056.32055-2-ralph.sennhauser@gmail.com> <87tw42tqdr.fsf@free-electrons.com> <20170530165101.73ae0bf6@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Return-path: In-Reply-To: Sender: linux-pwm-owner@vger.kernel.org To: Richard Genoud , Gregory CLEMENT Cc: Linus Walleij , "linux-gpio@vger.kernel.org" , Andrew Lunn , Thierry Reding , Alexandre Courbot , Rob Herring , Mark Rutland , Jason Cooper , Sebastian Hesselbarth , Russell King , "linux-pwm@vger.kernel.org" , "devicetree@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" List-Id: linux-gpio@vger.kernel.org On Tue, 30 May 2017 17:35:33 +0200 Richard Genoud wrote: =20 > Hi Ralph, >=20 > I have the functional spec (no NDA needed, but it's not the full > one) : A38x-Functional-Spec-PU0A.pdf > https://marvellcorp.wufoo.com/forms/marvell-armada-38x-functional-specifi= cations/ > (just an email needed, no blood signing nor chicken slaughtering) > There are the GPIO Blink Counter A/B is ON/OFF Duration Registers as > well as the Blink Enable Registers. >=20 Hi Richard, Thanks for the link, as the terms only talk about materials obtained from www.marvell.com this one from wufoo.com should be exempt ;) Also at a glance looks like the complete one. Also says "Functional Specifications =E2=80=93 Unrestricted". Maybe you want to re-download it. Regardless, as you said the blinking registers are all described. So it's probably safe to assume 39x will have them as well. > I've done a pwm with different periods (8ms, 4ms, 100ns). > Looking at the scope, it seems to work pretty well :) >=20 > >> > >> And it makes me realized that I missed the bad naming of the > >> compatible string. We don't use family name for the compatible > >> string, but the name of the first SoC compatible with. So in this > >> case we should use "marvell,armada-370", as it is still in rc and > >> not yet deployed. What about fixing the name now? =20 Gregory, Knowing it's not limited to 370/XP makes "marvell,armada-370-gpio" an obviously better choice for the compatible string. Guess you didn't mean to drop the "-gpio" suffix. Will work on a patch changing the compatible string / documentation for 4.12 and an updated patch for armada 370/XP dtsi as well as a patch adding the properties to 38x for 4.13+. Expect them tomorrow, probably won't get around to it today anymore. Ralph