From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jean Delvare Subject: Re: [PATCH v2 2/3] pinctrl: cherryview: Add terminate entry for dmi_system_id tables Date: Thu, 1 Jun 2017 11:30:50 +0200 Message-ID: <20170601113050.6b216736@endymion> References: <20170517102514.89744-1-mika.westerberg@linux.intel.com> <20170517102514.89744-3-mika.westerberg@linux.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Return-path: Received: from mx2.suse.de ([195.135.220.15]:49946 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751202AbdFAJax (ORCPT ); Thu, 1 Jun 2017 05:30:53 -0400 In-Reply-To: <20170517102514.89744-3-mika.westerberg@linux.intel.com> Sender: linux-gpio-owner@vger.kernel.org List-Id: linux-gpio@vger.kernel.org To: Mika Westerberg Cc: Linus Walleij , Heikki Krogerus , Andy Shevchenko , Dmitry Torokhov , Wei Yongjun , bbaude@redhat.com, mildred-bug.kernel@mildred.fr, barnacs@justletit.be, lvuksta@gmail.com, linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org, Kelly French On Wed, 17 May 2017 13:25:13 +0300, Mika Westerberg wrote: > From: Wei Yongjun > > Make sure dmi_system_id tables are NULL terminated. > > Fixes: 703650278372 ("pinctrl: cherryview: Add a quirk to make Acer Chromebook keyboard work again") > Signed-off-by: Wei Yongjun > Signed-off-by: Mika Westerberg > --- > drivers/pinctrl/intel/pinctrl-cherryview.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/pinctrl/intel/pinctrl-cherryview.c b/drivers/pinctrl/intel/pinctrl-cherryview.c > index 2debba62fac9..e35d0fe4c737 100644 > --- a/drivers/pinctrl/intel/pinctrl-cherryview.c > +++ b/drivers/pinctrl/intel/pinctrl-cherryview.c > @@ -1547,7 +1547,8 @@ static const struct dmi_system_id chv_no_valid_mask[] = { > DMI_MATCH(DMI_PRODUCT_NAME, "Edgar"), > DMI_MATCH(DMI_BIOS_DATE, "05/21/2016"), > }, > - } > + }, > + {} > }; > > static int chv_gpio_probe(struct chv_pinctrl *pctrl, int irq) Reviewed-by: Jean Delvare This should go to stable trees IMHO. -- Jean Delvare SUSE L3 Support