* [REGRESSION next] gpio-keys broken with commit 2233bf7a92e7 ("gpio: mvebu: switch to regmap for register access")
@ 2017-06-09 6:50 Ralph Sennhauser
2017-06-09 10:12 ` Gregory CLEMENT
0 siblings, 1 reply; 2+ messages in thread
From: Ralph Sennhauser @ 2017-06-09 6:50 UTC (permalink / raw)
To: Thomas Petazzoni; +Cc: linux-gpio, linux-kernel, Linus Walleij, Gregory CLEMENT
Hi Thomas,
Commit 2233bf7a92e7 ("gpio: mvebu: switch to regmap for register
access") in next-20170607 breaks gpio-keys on an armada-385 (Linksys
WRT3200ACM), noticed due to missing /dev/input/event0 and the below
dmesg output.
# dmesg -l 0,1,2,3
[ 2.421130] genirq: Setting trigger mode 3 for irq 49 failed (mvebu_gpio_irq_set_type+0x0/0x168)
[ 2.429953] gpio-keys gpio-keys: Unable to claim irq 49; error -22
After reverting the offending commit all works again.
Ralph
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [REGRESSION next] gpio-keys broken with commit 2233bf7a92e7 ("gpio: mvebu: switch to regmap for register access")
2017-06-09 6:50 [REGRESSION next] gpio-keys broken with commit 2233bf7a92e7 ("gpio: mvebu: switch to regmap for register access") Ralph Sennhauser
@ 2017-06-09 10:12 ` Gregory CLEMENT
0 siblings, 0 replies; 2+ messages in thread
From: Gregory CLEMENT @ 2017-06-09 10:12 UTC (permalink / raw)
To: Ralph Sennhauser
Cc: Thomas Petazzoni, linux-gpio, linux-kernel, Linus Walleij
Hi Ralph,
On ven., juin 09 2017, Ralph Sennhauser <ralph.sennhauser@gmail.com> wrote:
> Hi Thomas,
>
> Commit 2233bf7a92e7 ("gpio: mvebu: switch to regmap for register
> access") in next-20170607 breaks gpio-keys on an armada-385 (Linksys
> WRT3200ACM), noticed due to missing /dev/input/event0 and the below
> dmesg output.
>
> # dmesg -l 0,1,2,3
> [ 2.421130] genirq: Setting trigger mode 3 for irq 49 failed (mvebu_gpio_irq_set_type+0x0/0x168)
> [ 2.429953] gpio-keys gpio-keys: Unable to claim irq 49; error -22
>
>
> After reverting the offending commit all works again.
I found the bug and I've just sent a fix for it (use the v2 as the first
version was wrong).
Thanks for the report,
Gregory
>
> Ralph
--
Gregory Clement, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-06-09 10:12 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-06-09 6:50 [REGRESSION next] gpio-keys broken with commit 2233bf7a92e7 ("gpio: mvebu: switch to regmap for register access") Ralph Sennhauser
2017-06-09 10:12 ` Gregory CLEMENT
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).