From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ralph Sennhauser Subject: Re: [PATCHv2 1/2] gpio: mvebu: fix blink counter register selection Date: Fri, 9 Jun 2017 10:03:22 +0200 Message-ID: <20170609100322.765adf7f@gmail.com> References: <20170601121826.14685-1-richard.genoud@gmail.com> <20170601121826.14685-2-richard.genoud@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: Sender: linux-pwm-owner@vger.kernel.org To: Linus Walleij Cc: Richard Genoud , Alexandre Courbot , Andrew Lunn , Gregory Clement , Jason Cooper , "linux-arm-kernel@lists.infradead.org" , "linux-gpio@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "linux-pwm@vger.kernel.org" , Mark Rutland , Rob Herring , Russell King , Sebastian Hesselbarth , Thierry Reding List-Id: linux-gpio@vger.kernel.org On Fri, 9 Jun 2017 09:37:55 +0200 Linus Walleij wrote: > On Thu, Jun 1, 2017 at 2:18 PM, Richard Genoud > wrote: > > > The blink counter A was always selected because 0 was forced in the > > blink select counter register. > > The variable 'set' was obviously there to be used as the register > > value, selecting the B counter when id==1 and A counter when id==0. > > > > Tested on clearfog-pro (Marvell 88F6828) > > > > Fixes: 757642f9a584 ("gpio: mvebu: Add limited PWM support") > > Reviewed-by: Gregory CLEMENT > > Reviewed-by: Ralph Sennhauser > > Signed-off-by: Richard Genoud > > Patch applied for fixes. > > It appears this will clash with patches on the development branch :( Hi Linus, The commit 2233bf7a92e7 ("gpio: mvebu: switch to regmap for register access") which you likely mean breaks gpio-keys, reported about an hour ago, so you might just want to drop that one for now instead as it needs mor work anyway. Ralph