From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ralph Sennhauser Subject: Re: [PATCH v2] gpio: mvebu: fix regmap_update_bits usage Date: Fri, 9 Jun 2017 14:21:44 +0200 Message-ID: <20170609142144.5f6c916b@gmail.com> References: <20170609100917.26660-1-gregory.clement@free-electrons.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Return-path: Received: from mail-wr0-f194.google.com ([209.85.128.194]:36748 "EHLO mail-wr0-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751572AbdFIMVs (ORCPT ); Fri, 9 Jun 2017 08:21:48 -0400 In-Reply-To: <20170609100917.26660-1-gregory.clement@free-electrons.com> Sender: linux-gpio-owner@vger.kernel.org List-Id: linux-gpio@vger.kernel.org To: Gregory CLEMENT Cc: Linus Walleij , linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, Jason Cooper , Andrew Lunn , Sebastian Hesselbarth , Thomas Petazzoni , linux-arm-kernel@lists.infradead.org, Chris Packham On Fri, 9 Jun 2017 12:09:17 +0200 Gregory CLEMENT wrote: > In some place in the driver regmap_update_bits was misused. Indeed the > last argument is not the value of the bit (or group of bits) itself > but the mask value inside the register. > > So when setting the bit N, then the value must be BIT(N) and not 1. > > CC: Chris Packham > CC: Ralph Sennhauser > Signed-off-by: Gregory CLEMENT > --- Hi Gregory, Tested-by: Ralph Sennhauser Thanks for the prompt fix Ralph