From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tony Lindgren Subject: Re: [PATCH v2] PM / wakeirq: Convert to SRCU Date: Mon, 26 Jun 2017 03:15:57 -0700 Message-ID: <20170626101557.GV3730@atomide.com> References: <20170624135320.GS3721@linux.vnet.ibm.com> <20170625144559.GA3721@linux.vnet.ibm.com> <20170625182926.GB3721@linux.vnet.ibm.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from muru.com ([72.249.23.125]:48854 "EHLO muru.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751353AbdFZKQC (ORCPT ); Mon, 26 Jun 2017 06:16:02 -0400 Content-Disposition: inline In-Reply-To: <20170625182926.GB3721@linux.vnet.ibm.com> Sender: linux-gpio-owner@vger.kernel.org List-Id: linux-gpio@vger.kernel.org To: "Paul E. McKenney" Cc: Thomas Gleixner , Brian Norris , Heiko Stuebner , Linus Walleij , linux-rockchip@lists.infradead.org, Julia Cartwright , LKML , linux-gpio@vger.kernel.org, John Keeping , linux-pm@vger.kernel.org, Doug Anderson , Peter Zijlstra , "Rafael J. Wysocki" * Paul E. McKenney [170625 11:29]: > On Sun, Jun 25, 2017 at 07:31:13PM +0200, Thomas Gleixner wrote: > > The wakeirq infrastructure uses RCU to protect the list of wakeirqs. That > > breaks the irq bus locking infrastructure, which is allows sleeping > > functions to be called so interrupt controllers behind slow busses, > > e.g. i2c, can be handled. > > > > The wakeirq functions hold rcu_read_lock and call into irq functions, which > > in case of interrupts using the irq bus locking will trigger a > > might_sleep() splat. > > > > Convert the wakeirq infrastructure to Sleepable RCU and unbreak it. > > > > Fixes: 4990d4fe327b ("PM / Wakeirq: Add automated device wake IRQ handling") > > Reported-by: Brian Norris > > Suggested-by: Paul E. McKenney > > Signed-off-by: Thomas Gleixner > > Looks good to me! > > Reviewed-by: Paul E. McKenney And still works for me! Tested-by: Tony Lindgren