From: Brian Norris <briannorris@chromium.org>
To: Tony Lindgren <tony@atomide.com>
Cc: "Thomas Gleixner" <tglx@linutronix.de>,
"Heiko Stuebner" <heiko@sntech.de>,
"Linus Walleij" <linus.walleij@linaro.org>,
linux-rockchip@lists.infradead.org,
"Julia Cartwright" <julia@ni.com>,
LKML <linux-kernel@vger.kernel.org>,
linux-gpio@vger.kernel.org, "John Keeping" <john@metanate.com>,
linux-pm@vger.kernel.org, "Doug Anderson" <dianders@chromium.org>,
"Paul E. McKenney" <paulmck@linux.vnet.ibm.com>,
"Peter Zijlstra" <peterz@infradead.org>,
"David.Wu" <david.wu@rock-chips.com>,
'黄涛' <huangtao@rock-chips.com>
Subject: Re: [PATCH for 4.12] Revert "pinctrl: rockchip: avoid hardirq-unsafe functions in irq_chip"
Date: Tue, 27 Jun 2017 00:07:33 -0700 [thread overview]
Message-ID: <20170627070731.GA23083@google.com> (raw)
In-Reply-To: <20170627062409.GX3730@atomide.com>
On Mon, Jun 26, 2017 at 11:24:09PM -0700, Tony Lindgren wrote:
> Hmm so how come drivers/bluetooth/btusb.c can't use the generic
> dev_pm_set_dedicated_wake_irq()? Can you please take a look?
I took a look previously, and last time I did, there were too many bugs
for it to be useful. You may have fixed the ones I reported w.r.t.
assumptions about runtime PM.
I also recall there being some difficulty with supporting
level-triggered interrupts that way. (This signal has no device-level
mask, and it triggers for all sorts of BT activity. There may not be a
relevant "edge".)
> If there are issues remaining let's rather fix them so we can get rid
> of the custom tinkering of wake-up events in the drivers.
That's nice, but that doesn't answer my questions. Perhaps that's a side
project. The point is that we're clearly violating the documented APIs.
Brian
next prev parent reply other threads:[~2017-06-27 7:07 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-17 22:56 [4.12 REGRESSION] pinctrl: rockchip: sleeping function called from atomic context Brian Norris
2017-05-27 2:19 ` Brian Norris
2017-06-23 20:59 ` [PATCH for 4.12] Revert "pinctrl: rockchip: avoid hardirq-unsafe functions in irq_chip" Brian Norris
2017-06-23 21:10 ` Heiko Stuebner
2017-06-23 22:12 ` Thomas Gleixner
2017-06-23 22:40 ` Paul E. McKenney
2017-06-24 9:21 ` Thomas Gleixner
2017-06-27 0:06 ` Brian Norris
2017-06-27 6:24 ` Tony Lindgren
2017-06-27 7:07 ` Brian Norris [this message]
2017-06-27 7:32 ` Tony Lindgren
2017-06-27 13:01 ` Thomas Gleixner
2017-06-27 13:06 ` Thomas Gleixner
2017-06-27 17:23 ` Brian Norris
2017-06-27 18:07 ` Thomas Gleixner
2017-06-27 13:26 ` Heiko Stübner
2017-06-27 16:35 ` Thomas Gleixner
2017-06-29 13:05 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170627070731.GA23083@google.com \
--to=briannorris@chromium.org \
--cc=david.wu@rock-chips.com \
--cc=dianders@chromium.org \
--cc=heiko@sntech.de \
--cc=huangtao@rock-chips.com \
--cc=john@metanate.com \
--cc=julia@ni.com \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=paulmck@linux.vnet.ibm.com \
--cc=peterz@infradead.org \
--cc=tglx@linutronix.de \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).