From mboxrd@z Thu Jan 1 00:00:00 1970 From: Brian Norris Subject: Re: [PATCH for 4.12] Revert "pinctrl: rockchip: avoid hardirq-unsafe functions in irq_chip" Date: Tue, 27 Jun 2017 00:07:33 -0700 Message-ID: <20170627070731.GA23083@google.com> References: <20170517225634.GA11404@google.com> <20170527021900.GA119873@google.com> <20170623205911.GA143883@google.com> <20170627000622.GA63039@google.com> <20170627062409.GX3730@atomide.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <20170627062409.GX3730@atomide.com> Sender: linux-pm-owner@vger.kernel.org To: Tony Lindgren Cc: Thomas Gleixner , Heiko Stuebner , Linus Walleij , linux-rockchip@lists.infradead.org, Julia Cartwright , LKML , linux-gpio@vger.kernel.org, John Keeping , linux-pm@vger.kernel.org, Doug Anderson , "Paul E. McKenney" , Peter Zijlstra , "David.Wu" , =?utf-8?B?J+m7hOa2myc=?= List-Id: linux-gpio@vger.kernel.org On Mon, Jun 26, 2017 at 11:24:09PM -0700, Tony Lindgren wrote: > Hmm so how come drivers/bluetooth/btusb.c can't use the generic > dev_pm_set_dedicated_wake_irq()? Can you please take a look? I took a look previously, and last time I did, there were too many bugs for it to be useful. You may have fixed the ones I reported w.r.t. assumptions about runtime PM. I also recall there being some difficulty with supporting level-triggered interrupts that way. (This signal has no device-level mask, and it triggers for all sorts of BT activity. There may not be a relevant "edge".) > If there are issues remaining let's rather fix them so we can get rid > of the custom tinkering of wake-up events in the drivers. That's nice, but that doesn't answer my questions. Perhaps that's a side project. The point is that we're clearly violating the documented APIs. Brian